Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210824152423.300346181@fuller.cnet> <20210824152646.706875395@fuller.cnet>
 <CAFki+Lnso5j+cbDsd74+YM+-sT-zTYuymyJLY2Sw1ho3SHW74Q@mail.gmail.com> <20210901173401.GB48995@fuller.cnet>
In-Reply-To: <20210901173401.GB48995@fuller.cnet>
From:   Nitesh Lal <nilal@redhat.com>
Date:   Wed, 1 Sep 2021 13:49:53 -0400
Message-ID: <CAFki+L=wYqKZon8TRdMhOHfS3goh7yHXQFDb7RXM=iOJeZJBPw@mail.gmail.com>
Subject: Re: [patch V3 2/8] add prctl task isolation prctl docs and samples
To:     Marcelo Tosatti <mtosatti@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Alex Belits <abelits@belits.com>, Peter Xu <peterx@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 1, 2021 at 1:38 PM Marcelo Tosatti <mtosatti@redhat.com> wrote:
>
> On Wed, Sep 01, 2021 at 09:11:56AM -0400, Nitesh Lal wrote:
> > On Tue, Aug 24, 2021 at 11:42 AM Marcelo Tosatti <mtosatti@redhat.com> wrote:
> > >
> > > Add documentation and userspace sample code for prctl
> > > task isolation interface.
> > >
> > > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > >
> > > ---
> > >  Documentation/userspace-api/task_isolation.rst |  211 +++++++++++++++++++++++++
> > >  samples/Kconfig                                |    7
> > >  samples/Makefile                               |    1
> > >  samples/task_isolation/Makefile                |    9 +
> > >  samples/task_isolation/task_isol.c             |   83 +++++++++
> > >  samples/task_isolation/task_isol.h             |    9 +
> > >  samples/task_isolation/task_isol_userloop.c    |   56 ++++++
> > >  7 files changed, 376 insertions(+)
> >
> > [...]
> >
> > > +       if (ret) {
> > > +               perror("mlock");
> > > +               return EXIT_FAILURE;
> > > +       }
> > > +
> > > +       ret = task_isol_setup();
> > > +       if (ret)
> > > +               return EXIT_FAILURE;
> >
> > The above check condition should be 'ret == -1', isn't it?
>
> task_isol_setup returns 0 on success, so fail to see the point
> of testing for ret == -1 rather than ret != 0 ?
>

Hmm, could be something that I misinterpreted.
I will double-check.

-- 
Thanks
Nitesh