Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: s5p-jpeg: Make use of the helper function
 devm_platform_ioremap_resource()
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210901055609.7679-1-caihuoqing@baidu.com>
From:   Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Message-ID: <d734bf08-1fb0-2805-1b67-b79f3d9efe7e@gmail.com>
Date:   Wed, 1 Sep 2021 11:18:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210901055609.7679-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Cai Huoqing,

Thank you for the patch.

W dniu 01.09.2021 o 07:56, Cai Huoqing pisze:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index d402e456f27d..1faff037cdf7 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
>   static int s5p_jpeg_probe(struct platform_device *pdev)
>   {
>   	struct s5p_jpeg *jpeg;
> -	struct resource *res;
>   	int i, ret;
>   
>   	/* JPEG IP abstraction struct */
> @@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
>   	jpeg->dev = &pdev->dev;
>   
>   	/* memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
> +	jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(jpeg->regs))
>   		return PTR_ERR(jpeg->regs);
>   
>