Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp875649pxb; Wed, 1 Sep 2021 11:52:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcqNakkJz0tm3zNbbi5TM08UtKKEmq2Ab2Cq+MFaJM8D/bC9V5HwYh5DaL7mVWl2Dl1vSc X-Received: by 2002:a17:906:8469:: with SMTP id hx9mr966412ejc.455.1630522348195; Wed, 01 Sep 2021 11:52:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630522348; cv=none; d=google.com; s=arc-20160816; b=XN886UAE2gWufLgOmBBJ4+l1bQoUux2IZhdcOUwO+TROT2JkX4cIWalVEQp3cg8wuT 7IzLo8jZGtkt4P0ydpvB6ULNdGLsJFkBaLnfZW7M/tu3KALYPb9dtbGzryj4oJYEEAlp DsKNgTbhr4uHMNRJNEeJmQ55TN+1RYAFkWA227oXWny5/VGlQzig5na6WsrVz+y0RiWQ DIWJ2ccXnmhiLyfJF//nvljm4kMmtSRw1UYA8M/x7g8KwitGSCPKzSJgrZOhF8OV60nq zY6RLr0WIRlSQWBSqrbED/jCZMF4scX5+qJy7mwmwl4Mm9x5sIuCjkV9dTWSC6U8CKOt 7MIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:reply-to:references:cc:to:subject:dkim-signature; bh=mGF36vXRHxNHdwxpyQvz+ZltDA0mtlFjM2CiuZ/EQKs=; b=ldpldbefq52QetK3MhJrOxYQRn2XEGM3mezTVA4vOoZZCbvWLvEazjhaP0UYKoyyEv 3JAJ8kM7RCoHK0Zo3iWNxoKxF0fHJ0UHpGg9/aHCrRwb0jN4ccP9uscCJekN2b3zSDKg chI+M60tL1bosMh3UWAhd0aIoX0wSoVlg+8tbShZm+HNA5eAZ5MpMkPbxRX5BsmDfciP ijB4QcyDPVbNJC81mS7cD2Zz3O1Yjsv+gfEdKJ1Py5tUlT2aQ1rAkfCn0A7EkO13oJ8K 5zKh4hC2lZEmpts4xPMlZjBE2JT1FQrO9qHwjx1iH5v2zLQ3k1LZERZOwiJ4whmSJ/cs X+og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=U5+byBP8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si382052edq.463.2021.09.01.11.52.04; Wed, 01 Sep 2021 11:52:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=U5+byBP8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241232AbhIALMX (ORCPT + 99 others); Wed, 1 Sep 2021 07:12:23 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:45500 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240150AbhIALMW (ORCPT ); Wed, 1 Sep 2021 07:12:22 -0400 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EB6563D7; Wed, 1 Sep 2021 13:11:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630494684; bh=HInr+c+TDIZIVFqwjq0Hfi0Gm4yXp7wNGXxxBqGvUY4=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=U5+byBP8kaMpurkoq+nDNAT2q9W0dnNRxyj/aqLH9mlZnacLfpoE2alrpBCuWw5MH HcIh6UuBejXMrFfy/nKuNbdkCb9QkNzCppFuZIQ/bYUcAaS3VFC4y6GKh3LLlxsnLG +bVXkEKLgNxfcWwBpZmGtXMJEcvW3pX4xCwI5dsM= Subject: Re: [PATCH] drm/shmobile: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210831135731.4776-1-caihuoqing@baidu.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Wed, 1 Sep 2021 12:11:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831135731.4776-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/2021 14:57, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > index 7db01904d18d..80078a9fd7f6 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -192,7 +192,6 @@ static int shmob_drm_probe(struct platform_device *pdev) > struct shmob_drm_platform_data *pdata = pdev->dev.platform_data; > struct shmob_drm_device *sdev; > struct drm_device *ddev; > - struct resource *res; > unsigned int i; > int ret; > > @@ -215,8 +214,7 @@ static int shmob_drm_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, sdev); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - sdev->mmio = devm_ioremap_resource(&pdev->dev, res); > + sdev->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(sdev->mmio)) > return PTR_ERR(sdev->mmio); > >