Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp875671pxb; Wed, 1 Sep 2021 11:52:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxckLR3MOtcUNxBBjDVdnrUecQsT45OshIshWGM0MeVPW/Y2rSVRx+a5V1azddrQyihFxt0 X-Received: by 2002:a05:6402:3584:: with SMTP id y4mr1050969edc.183.1630522349873; Wed, 01 Sep 2021 11:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630522349; cv=none; d=google.com; s=arc-20160816; b=RdeavoXOIFQHraaqAcGrU0VBiJ8r1iZHJVa14nj69hYIzrUzf7Uu+U08eokrxtCxDP kOkHYTBKxr2C5X4U6hLGWfVm7sm/VIrO1xOn5duV2pQQc6GriKY623VztMTlMgI4Fyr7 gG2H8m4qTyuatUDq+mGLjuo4L1h35gp96wyk56kTmIyNCWR4YqIoENspAzd+ctOfLkkY v2k6CC1458UwxSlWjX7pmp3mrM67n2BRUomB3wXhcZZjn3tsKZLbH8dMnVtwyj3X/oo7 czxywF+rPUGbFBgmdpZ8S6kL/Dwm0lKfxmiDp4oyusSLXVAwNr6iEIeazzMukAJeFO9o 827g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+7LJFbJmOjscJwmK5YTcR3FHQTGg8/0EDaixlmQwPOM=; b=emtUsjKT9ExYFQjbHelPgHF6vLG6U4xJ7G+l3KP+ZzS/79BNtEqsy1y+V/lZW/GCuS jED1DzDzuBxLGh3vD2CpDjVQSV1fXwWFgjUVjX7Ce5XrlYUqiNKkUW30QFjue6JD5xUS V4uyZbnzhKsTiVGQ9lR5jrPJVCJgj32ahu2DDvDZZkL8GM4IXdq7GPb40GBD5TcWr/GF hsGcB05lHzrelKhxcNfcFYKeP4orqLtKniotlPq9Y5i3DzQvTLdvmFanQ2uAxAPxyx0S ZgrMYBAIjnhKoCtc7+R2Fmy27DfKkeQyi7QaWQeW34X+zt/PvUDvPBWi9oq58cH2CWUo qW4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rsa46M9Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si713835ejo.390.2021.09.01.11.52.06; Wed, 01 Sep 2021 11:52:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rsa46M9Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232300AbhIAM1h (ORCPT + 99 others); Wed, 1 Sep 2021 08:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:56610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244092AbhIAM1d (ORCPT ); Wed, 1 Sep 2021 08:27:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A2E260ED4; Wed, 1 Sep 2021 12:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630499197; bh=+95puD2BYAaa9vTYS2vsdR0EF+bGjM954LfvMy7ryn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rsa46M9YOv9rl7ShAJ8NcG15qt2fimyWgFTGFt949KoD/cy9inr77+GlFsmKuoD2t iVSXsalXTugyet2euydlpI8Xy/ahNKU26wmKjHEXb9XtakRzsQyc4XWnlDRchAVl1b EvscEWy3b2LfiL64BlqoxWJaXs+dZcH4rWrA3y5U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Paul=20Gr=C3=B6=C3=9Fel?= , Willy Tarreau , Johan Hovold Subject: [PATCH 4.4 02/10] Revert "USB: serial: ch341: fix character loss at high transfer rates" Date: Wed, 1 Sep 2021 14:26:16 +0200 Message-Id: <20210901122248.133229336@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210901122248.051808371@linuxfoundation.org> References: <20210901122248.051808371@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit df7b16d1c00ecb3da3a30c999cdb39f273c99a2f upstream. This reverts commit 3c18e9baee0ef97510dcda78c82285f52626764b. These devices do not appear to send a zero-length packet when the transfer size is a multiple of the bulk-endpoint max-packet size. This means that incoming data may not be processed by the driver until a short packet is received or the receive buffer is full. Revert back to using endpoint-sized receive buffers to avoid stalled reads. Reported-by: Paul Größel Link: https://bugzilla.kernel.org/show_bug.cgi?id=214131 Fixes: 3c18e9baee0e ("USB: serial: ch341: fix character loss at high transfer rates") Cc: stable@vger.kernel.org Cc: Willy Tarreau Link: https://lore.kernel.org/r/20210824121926.19311-1-johan@kernel.org Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/ch341.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -585,7 +585,6 @@ static struct usb_serial_driver ch341_de .owner = THIS_MODULE, .name = "ch341-uart", }, - .bulk_in_size = 512, .id_table = id_table, .num_ports = 1, .open = ch341_open,