Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
CC:     bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Ziljstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 3/3] selftests/bpf: add test for
 bpf_get_branch_snapshot
Thread-Topic: [PATCH v4 bpf-next 3/3] selftests/bpf: add test for
 bpf_get_branch_snapshot
Thread-Index: AQHXnslOGJvfh6WSokmD54fWNMz0G6uOkIyAgADCPYA=
Date:   Wed, 1 Sep 2021 15:43:59 +0000
Message-ID: <44C43497-13EC-4F05-B15B-40531D5C3852@fb.com>
References: <20210901003517.3953145-1-songliubraving@fb.com>
 <20210901003517.3953145-4-songliubraving@fb.com>
 <CAEf4BzZrEcZFNSH=YDi_NmT2oqaOhmgQvPv0THXKy4haEzBFvQ@mail.gmail.com>
In-Reply-To: <CAEf4BzZrEcZFNSH=YDi_NmT2oqaOhmgQvPv0THXKy4haEzBFvQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0njHRCyVZUFYz9WW4bUXfgnHcB/ANcejYAj0Wa0Fe5zotMGQglz9WdRalPSt?=
 =?us-ascii?Q?cMRUrfGZVmpCIk1ZYiXlWCZItF+yrXwm6ZIA0hxtyIIiYDX+MOjtGdfiWSmz?=
 =?us-ascii?Q?EyySrRX9JFqtpTxHtEMzzR/26eYZXlyuOXVPWipOEYDNpk60vydxPxRq7Zqr?=
 =?us-ascii?Q?j6mMBF7g6k3CRez0XaqUrGTQO3Mu6/ZvRS/Ikphk+i3s/7+Eawhl1ih3hSCX?=
 =?us-ascii?Q?ODkTn1EJYepp6Y/qrgIVQAaWi0jPNZ11jrj4QpKdKXBIFl7b38LUv10zBir4?=
 =?us-ascii?Q?55pPNFRrZKiu0aPSV7ZpGFngm3pqfT9pbKxXu2SahNOIYWVNypM01kffK17q?=
 =?us-ascii?Q?dlPF0H2cNqMpjTSd24tOtkfxQHYr1KZKpfsbK8wNWAeZ50EPsg+RWsWvriJU?=
 =?us-ascii?Q?aOmC13O6Ie3xArVQkIxTrJIh6++RgmreykYUksVV/9gRhkMeJZVSN5KS4cMJ?=
 =?us-ascii?Q?YCvtMAbylfHl9qa8Dt0uxG78vnzuCQVbnqytfoa0nMF8uxusVflBx18rCDzq?=
 =?us-ascii?Q?PHqac1JdDLrFEaiQRxB7nKxwnAprWsLYYLLqvBI0xrWFmV7/dUSnTsr5kkrV?=
 =?us-ascii?Q?5Qw/UZTh76CWs+Wyb1tRa0kMiHO5OjYWVwKWqsanx7fLjNYUbcq+qaWjXXbq?=
 =?us-ascii?Q?1mbzJWu3xGMCCeuVFPmTFpwkvNNa25Mn4wBeuJy+sBHIPzyyU71kO2HmPg5T?=
 =?us-ascii?Q?F2rxZs4BIVgU8sQE1FGvxUkSIOM2+J651g36BQgdEuZED+SKsPR1pK99VbRn?=
 =?us-ascii?Q?xFGd3xDLLCW05f1cUeD7HiwKD9mgrl2BGkhPqrMtiZeBFNyA3eR3S7RNX9uT?=
 =?us-ascii?Q?znBtetjxRIgHrbE1Wz8MwM5opFja36CVZiVfm3VK7XGVMHp8OT0rdWV5Ab+A?=
 =?us-ascii?Q?3GfcsRldrPzfNOTYB7J0Tb82eXdO7dsB9zzuP7n/c8oJzd+tbbikW5ux6Avv?=
 =?us-ascii?Q?9Og+2VwalhdtFAQl6i1qpbKbKmUI0ucfbtfa1odcawpLHhfGX9J3cuO9c4Xz?=
 =?us-ascii?Q?AMkfEN3JEvNhibyFVTK12Vpwq/e5jvzFjJhuXkzgyQvK1znz+9vgh6p8Hs04?=
 =?us-ascii?Q?1d0CprZgsT6OtyRn9nws0IXA6hwktvKfOwdGOWunLdqzY76WEheAVqp8Xsdq?=
 =?us-ascii?Q?QJ4ZU3Ujl3R2Lf/RvEcXoZXkgBAWfARNcWXLg6judPAl5SA42jbH7u1Q3D9s?=
 =?us-ascii?Q?h8XG/bPBenDqRyXUoLlAvSd9NfEBzPeUS0AMAX1N3ytMkmDeQQUTSjJxBUxt?=
 =?us-ascii?Q?+98O4eEU2oyfn4Six+qSrLmgVydQUpLcqzwajyElC7wjlJQXZQ4SEyc3UVUr?=
 =?us-ascii?Q?Ic0yDRZjpLm1ej2SJ6fzAHGZ0jzDeJyNRu++VYqzhn2S+EgXqNXcHIheTdw0?=
 =?us-ascii?Q?yF6wyv4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1874CC15773AED48B866AF32E20050B2@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef6fe033-1c2e-4271-0027-08d96d5f50e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 15:43:59.5793
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fSAC9o1dUSnGXrm5xIZx1QPKOPjqa8GlNd8ij4QyWHpR4ymEaBQXfG3zHi5fkNYlvxWjzOv15rpTkoYQDgzKag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5096
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: CYBYAiuQDncSEjPR9cr4o8krO_qQOV-5
X-Proofpoint-ORIG-GUID: CYBYAiuQDncSEjPR9cr4o8krO_qQOV-5
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-01_05:2021-09-01,2021-09-01 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 adultscore=0
 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0
 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2107140000 definitions=main-2109010091
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 31, 2021, at 9:08 PM, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> 
> On Tue, Aug 31, 2021 at 7:01 PM Song Liu <songliubraving@fb.com> wrote:
>> 
>> This test uses bpf_get_branch_snapshot from a fexit program. The test uses
>> a target function (bpf_testmod_loop_test) and compares the record against
>> kallsyms. If there isn't enough record matching kallsyms, the test fails.
>> 
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
> 
> LGTM, few minor nits below
> 
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
> 
>> .../selftests/bpf/bpf_testmod/bpf_testmod.c   |  14 ++-
>> .../bpf/prog_tests/get_branch_snapshot.c      | 101 ++++++++++++++++++
>> .../selftests/bpf/progs/get_branch_snapshot.c |  44 ++++++++
>> tools/testing/selftests/bpf/trace_helpers.c   |  37 +++++++
>> tools/testing/selftests/bpf/trace_helpers.h   |   5 +
>> 5 files changed, 200 insertions(+), 1 deletion(-)
>> create mode 100644 tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c
>> create mode 100644 tools/testing/selftests/bpf/progs/get_branch_snapshot.c
>> 
> 
> [...]
> 
>> +
>> +void test_get_branch_snapshot(void)
>> +{
>> +       struct get_branch_snapshot *skel = NULL;
>> +       int err;
>> +
>> +       if (create_perf_events()) {
>> +               test__skip();  /* system doesn't support LBR */
>> +               goto cleanup;
>> +       }
>> +
>> +       skel = get_branch_snapshot__open_and_load();
>> +       if (!ASSERT_OK_PTR(skel, "get_branch_snapshot__open_and_load"))
>> +               goto cleanup;
>> +
>> +       err = kallsyms_find("bpf_testmod_loop_test", &skel->bss->address_low);
>> +       if (!ASSERT_OK(err, "kallsyms_find"))
>> +               goto cleanup;
>> +
>> +       err = kallsyms_find_next("bpf_testmod_loop_test", &skel->bss->address_high);
>> +       if (!ASSERT_OK(err, "kallsyms_find_next"))
>> +               goto cleanup;
>> +
>> +       err = get_branch_snapshot__attach(skel);
>> +       if (!ASSERT_OK(err, "get_branch_snapshot__attach"))
>> +               goto cleanup;
>> +
>> +       /* trigger the program */
>> +       system("cat /sys/kernel/bpf_testmod > /dev/null 2>& 1");
> 
> ugh :( see prog_tests/module_attach.c, we can extract and reuse
> trigger_module_test_read() and trigger_module_test_write()

Will fix. 
> 
>> +
>> +       if (skel->bss->total_entries < 16) {
>> +               /* too few entries for the hit/waste test */
>> +               test__skip();
>> +               goto cleanup;
>> +       }
>> +
> 
> [...]
> 
>> +SEC("fexit/bpf_testmod_loop_test")
>> +int BPF_PROG(test1, int n, int ret)
>> +{
>> +       long i;
>> +
>> +       total_entries = bpf_get_branch_snapshot(entries, sizeof(entries), 0);
>> +       total_entries /= sizeof(struct perf_branch_entry);
>> +
>> +       bpf_printk("total_entries %lu\n", total_entries);
>> +
>> +       for (i = 0; i < PERF_MAX_BRANCH_SNAPSHOT; i++) {
>> +               if (i >= total_entries)
>> +                       break;
>> +               if (in_range(entries[i].from) && in_range(entries[i].to))
>> +                       test1_hits++;
>> +               else if (!test1_hits)
>> +                       wasted_entries++;
>> +               bpf_printk("i %d from %llx to %llx", i, entries[i].from,
>> +                          entries[i].to);
> 
> debug leftovers? this will be polluting trace_pipe unnecessarily; same
> for above total_entries bpf_printk()

Oops.. I added/removed it for every version, but forgot this time. Will fix 
in v5. 

Thanks,
Song