Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp884399pxb; Wed, 1 Sep 2021 12:03:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyayz2sG+wnEXXuxzmW0Eu4K6ceB4/pt2mx89UL4MaIL1JJ95tpHfqvQkVzffdzFXExsC9Y X-Received: by 2002:a17:907:9908:: with SMTP id ka8mr1061177ejc.164.1630522999146; Wed, 01 Sep 2021 12:03:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630522999; cv=none; d=google.com; s=arc-20160816; b=CSnT5eOn3/MhrzjqYSdtoKtOQ8mYnldmfJegSUiEnZRuC5PJO+d+g6INX81pFdZuZl RTAR7EaamDt6Oj3oEYHyFFDksahr/TXz1j+/717MbAC+kPUFbzcxcc72aieriOTqHIr+ H5PN761EzZ+wN9fY0FsJ1XC4HKgko9mJURBYgcNttyWFCB2xIDES8xWh6xCn7kzssHPf xDC7eUuh/SB9fRg8LKfko2mWxm3EQIf1toslYEbrd/vwB+zJ5ivhNV4sMUscxLjM1yCL H57W8mSRpJB8GloSJ5H8NAzQxLgVruJcfnudC7TaGJaEZ3WfekrNhyneKNDg2S/Y0Mxt OTog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Xo8uJpNTDPAJpO4ANtyiOylofRDK6dKo+R7EU5AbxUQ=; b=jTwIbH0YGijtVP1TElYFmpwTWWfqebIH4EY5OHreaDP3mPXZDpLY4PPAdy87DUcdFD WZsyTkcJpNew3KDNkmXDtobcOJbIhzMPuWMPaUPvphS/6HAndb6uANcrNqnp0cp7Mam5 lDSGbcHuxilhmpiyx/Ltu88vgwDSWjvqIKIyeXrsSATdRk0kipF/0aNg0pfYNDExc1ih xWTKm8nYIumJ6MTItLLNzAn+YlfWlbHt3NAObWGVkrOziNe7NESpMcqeFglq2cor2Pk4 M2CXSTefyhEVYfou0/WPM584WWZURjoeCNIs3jZPirbEDkf17ctKnTiUDGsQvZ+CZ3Da 6Cyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si308370edd.539.2021.09.01.12.02.31; Wed, 01 Sep 2021 12:03:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231894AbhIAS1k (ORCPT + 99 others); Wed, 1 Sep 2021 14:27:40 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40814 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbhIAS1j (ORCPT ); Wed, 1 Sep 2021 14:27:39 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tonyk) with ESMTPSA id 924CB1F43FDB Subject: Re: [PATCH][next] futex: fix assigned ret variable that is never read To: Colin King Cc: kernel-janitors@vger.kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, Thomas Gleixner , Davidlohr Bueso , Darren Hart , Peter Zijlstra References: <20210818131840.34262-1-colin.king@canonical.com> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: <5682c44f-3a02-c2b1-25d3-36db34b00356@collabora.com> Date: Wed, 1 Sep 2021 15:26:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210818131840.34262-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, Às 10:18 de 18/08/21, Colin King escreveu: > From: Colin Ian King > > Currently the check on the rt_waiter and top_waiter->pi_state is > assigning an error return code to ret but this later gets re-assigned, > hence the check is currently ineffective. I believe the original > intent was to return -EINVAL rather than assign it to ret. Fix this. > > Addresses-Coverity: ("Unused value") > Fixes: dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()") > Signed-off-by: Colin Ian King > --- Reviewed-by: André Almeida