Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp914081pxb; Wed, 1 Sep 2021 12:34:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6vIS5jei/G8wZHO3OylETjIeAbVMryO9SK49slcnOncGbyIVpX4hTWktaKmxXyYNp1NIx X-Received: by 2002:a17:906:180a:: with SMTP id v10mr1223657eje.112.1630524840887; Wed, 01 Sep 2021 12:34:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630524840; cv=none; d=google.com; s=arc-20160816; b=WU5IBwPTCwm2nyOTMmEQNX5UK1PCgj8fanEy7TiS1yakyfDOUVRViNJDqMA4jHPAGT Hz5zjQDj0ktcU/W9PI5jXtwMjt3Nz8tSZi0fOz/wEkVdnsQiPugFpAdiLwCp/Gs//MoP OI+UgAjtz+vIvjP/wVG0v3FrI7MwBsJRoZPGz+AMIPdbAeVyDFoW5CpdPJYPutIiW4V3 aQN77xCtJ29IR/B9nTu5ETTB9Wo5XRzU1kDI1WkjVC16Vvd8smm9QZ3QvFEZ1P9V2wUs 97j/SqJFQTarApLglVWMInpgwiVR2gaK9xSHt7m0x6by0yBLfhnA52ME3uXoH1qxY7O6 0Mxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MCj4496Sd/zJlXRwDsaQxfP5ocEDGyoGqeLlpN72V58=; b=TA+q6Qn/kpv5UsKRrUmTEh7NbS5Z42EDqjOP3k5w0TxqXNzgTf2DotA6GroyBkgUiz V9etgzHIBKKqEE02Nkg0HXCTUAx/Q1wLPP4JpYAt9Qz1E6HuS9CRzzxuQO5oujlJ3IKY QdaupZgfvAGy5rHhR+m4No0trb3CQ52ihD8hE2HFwNqD9+NKBVltG5viY5cGXSwNNBGP kmPz5DPrZ0nSeo5HJZ/44luOp9bonZjcQoT5bXoLwvFpNx9RRgwjxiZIQmqi6TpRw/P/ ACIF1Q6FmdulY6zyjzt8dMYgV1FspcMcXfj8EaEYp8RLokiW0JlGtMT/we9PTAo52xIs aEOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q3mME06q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si549583edj.222.2021.09.01.12.33.15; Wed, 01 Sep 2021 12:34:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q3mME06q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245062AbhIAMdy (ORCPT + 99 others); Wed, 1 Sep 2021 08:33:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:35432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245025AbhIAMcU (ORCPT ); Wed, 1 Sep 2021 08:32:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52A6C610CF; Wed, 1 Sep 2021 12:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630499483; bh=v98xaDog+4rSDrwX6oStY+2c9IVmLIiXLQ0YS0Vilzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q3mME06qaTKOWY+jbwb6o4Apyzefrl7c3OuZ6bmWUSiN7SBIuYV2pnj26a6s85H3e 7ZjC7w1Ghjls4QRHlXbLWgINxNrtK4SebyLyrHlNKN/2AibuDVPVXnOp2SjAlkyhnb O1EKfEhCiE/qk1ju5Q9TQV8uFIA5KwRXvuSuBDCs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Firas JahJah , Yossi Leybovich , Gal Pressman , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.4 17/48] RDMA/efa: Free IRQ vectors on error flow Date: Wed, 1 Sep 2021 14:28:07 +0200 Message-Id: <20210901122253.970935072@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210901122253.388326997@linuxfoundation.org> References: <20210901122253.388326997@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gal Pressman [ Upstream commit dbe986bdfd6dfe6ef24b833767fff4151e024357 ] Make sure to free the IRQ vectors in case the allocation doesn't return the expected number of IRQs. Fixes: b7f5e880f377 ("RDMA/efa: Add the efa module") Link: https://lore.kernel.org/r/20210811151131.39138-2-galpress@amazon.com Reviewed-by: Firas JahJah Reviewed-by: Yossi Leybovich Signed-off-by: Gal Pressman Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/efa/efa_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c index 83858f7e83d0..75dfe9d1564c 100644 --- a/drivers/infiniband/hw/efa/efa_main.c +++ b/drivers/infiniband/hw/efa/efa_main.c @@ -340,6 +340,7 @@ static int efa_enable_msix(struct efa_dev *dev) } if (irq_num != msix_vecs) { + efa_disable_msix(dev); dev_err(&dev->pdev->dev, "Allocated %d MSI-X (out of %d requested)\n", irq_num, msix_vecs); -- 2.30.2