Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp919919pxb; Wed, 1 Sep 2021 12:41:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtmF7CdSF/2hEN3FD89MxCfSgW/mA+cjTI3GlNqbFE7hZwnin1Rf60rQLAgwMTb2IF1D3t X-Received: by 2002:a92:d6c7:: with SMTP id z7mr865513ilp.4.1630525309907; Wed, 01 Sep 2021 12:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630525309; cv=none; d=google.com; s=arc-20160816; b=wQSnH6TmaTDm9Ahn45DjeYL7xaODsjMHAPBY2kqyHsn/JT5N5VcZDPbJIpiBO2pdk7 +XY8MjONEU1r68NizY509jcsPp4G2N3cDy8w1pZ8aNbtjHfYNg/+jl6a71+sForCsAW+ /T6WBZEDIz0tmZI/3yinIeC6xUEjkhgwGi7MeVn6Rbo19RgGS3yp8ZtUIbBworaeR47b 5KlAyxCIIt6BP3dPQDBQZwTRDVl4+jWPe5b9f/TAcAteQmNTAsblkFCSkSYugegtyHhp yKfpqK2uoCQXecp7j5oJ5jasHSTTXpU0ytQk0UmcI3DXdI9zcF/Ls3UzJPmiIAYJSV8S 9LLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+aPK3NQxyorCSzlspPTb1NnNsHOlk0ELxDBjjFKhDOo=; b=TKrBKNfdY7pJSkRlEmGaaVAL/qYeOrmYkmAbCvQlTxYS+tjlDjTLI5gjPXejVIiPR2 eSMG3O650dee5tH1Zz6+EVFcRwKcv1m8Tl2gbSUnQ02nreYGMa3ENNoBmAR5t/jeW4GR kkTNar/VQtoOd+MqgAilHV1z0txMqzUHlO3xi+5OH3PZn743mPVhBwDAc0okuB63eaIM Z7k3o+CcHOBgT1y7R2kexF686eOh7YHpPB47lFPGt48Ef7OhgCnOsKkuQTdtq4x5ZzU6 JjpJOZrwsYFbWXFOrREz3pb6AEY4B2WSMeJ3drn9NaRW/35kL84YXsKk2PKVzM6GT6wa Mmwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=enN72Hog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si330264jaf.102.2021.09.01.12.41.37; Wed, 01 Sep 2021 12:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=enN72Hog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345981AbhIAMtF (ORCPT + 99 others); Wed, 1 Sep 2021 08:49:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345671AbhIAMoz (ORCPT ); Wed, 1 Sep 2021 08:44:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D899D60232; Wed, 1 Sep 2021 12:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630499954; bh=tQD3A6yE/2wZBu1OnHoxU1+z1993gzCtABlXW7ufpp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=enN72HogZcrqW4YSyFblrk89A+UZ5ONvoiQoYwxzhPisheU2108fgoWJVeSwSeAoO RHjz/N6d4kRa5T73oRrJOuUazkh9BkP0GF+gfLpOzidl0B/58wdJnO7F1Ooi1kb2ji RgBzkFfDd2o/W1P/d6QANyYn7Pa95pDYAqm6q9sU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Firas JahJah , Yossi Leybovich , Gal Pressman , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.13 047/113] RDMA/efa: Free IRQ vectors on error flow Date: Wed, 1 Sep 2021 14:28:02 +0200 Message-Id: <20210901122303.544459168@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210901122301.984263453@linuxfoundation.org> References: <20210901122301.984263453@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gal Pressman [ Upstream commit dbe986bdfd6dfe6ef24b833767fff4151e024357 ] Make sure to free the IRQ vectors in case the allocation doesn't return the expected number of IRQs. Fixes: b7f5e880f377 ("RDMA/efa: Add the efa module") Link: https://lore.kernel.org/r/20210811151131.39138-2-galpress@amazon.com Reviewed-by: Firas JahJah Reviewed-by: Yossi Leybovich Signed-off-by: Gal Pressman Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/efa/efa_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c index 816cfd65b7ac..0b61ef0d5983 100644 --- a/drivers/infiniband/hw/efa/efa_main.c +++ b/drivers/infiniband/hw/efa/efa_main.c @@ -356,6 +356,7 @@ static int efa_enable_msix(struct efa_dev *dev) } if (irq_num != msix_vecs) { + efa_disable_msix(dev); dev_err(&dev->pdev->dev, "Allocated %d MSI-X (out of %d requested)\n", irq_num, msix_vecs); -- 2.30.2