Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp937159pxb; Wed, 1 Sep 2021 13:09:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYf6pf6BNhFgC2eMPBVfJn50W/6WphPi4GU/YCmdaWh0jdannsHSbZbtX+max9dLu+l875 X-Received: by 2002:a17:906:58c7:: with SMTP id e7mr1304823ejs.197.1630526982626; Wed, 01 Sep 2021 13:09:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630526982; cv=none; d=google.com; s=arc-20160816; b=xNOnpTThv3DckXSU5QUsR7vs2/+z7AXtBVskD0apP5efzjEOGfhwgojd4DwOn43zRi UDUVX9B+0BVJazn03SsmuhwewFsAzsBLrK0w9/vYVajWyxJZcoZBqiKpn/S/ncEM2m4x S0kztefsHlsIGcVKG9k/XEEZa4a6AEyfH+gNgMf3iuoffV3G4oCiZ/UfsEOrjShka5TV W1CNb+Iz4AMXm9GOcjn2wPCeT2uwjnCgF45byQl/e7FNpdR8fvBtZBVdVTd7D5Xo+BDU Tb5mLN9Rla+l9ZMBRfCPCs+idrMQr/hI+bOCqnjCH4VcUJunt/KJ/rdNh//p+MrX+T6W YUkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=xMRtrXe3M1vVJaRkGQ5o+yZQJhadRFN9gcbbCnaAFSQ=; b=zm6w+2uF5fiwm+QKcWEw7GCWvNh37FHYOD32oFtwyB0i6APNsoKbOECnXrRKOqVETb f3zBJ+1JI3sjcuTuu/vDnyXy6G+qAuU9cTDaYCfsr145ccdC1tZ9NzWdWRCRtm7arrVr kL1dtQJ2yRCevb4lwd2EtvtcwxAFvj4kQRYK7NKTvD1Df9q8mtWJuYdpB3iF/VXoJff8 75uPRfx4zX9hqatYHukbaMYP7P2G47v9LSR1NPOcZATG76qF3kAXI4Vs7VCjXpxtL0+d FHB3r+an4XoAJmFt49gXL/+Ab5ose83rfoBGdvN/Ta34NOJuExa/ea2avq+bPgboyoX2 5PqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wlmp9j2u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs10si803476ejc.193.2021.09.01.13.09.19; Wed, 01 Sep 2021 13:09:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wlmp9j2u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343922AbhIAQD4 (ORCPT + 99 others); Wed, 1 Sep 2021 12:03:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55762 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343748AbhIAQDw (ORCPT ); Wed, 1 Sep 2021 12:03:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630512175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xMRtrXe3M1vVJaRkGQ5o+yZQJhadRFN9gcbbCnaAFSQ=; b=Wlmp9j2uGDTBXavcOtRbZjt5fn8MyjViZK/n85MyTor8+9DwQwwQDuy6IUM81zh7yBrCu0 iiudIGbJnCZcOQ7AXHJzG3wENL6UtqtgOGXYpEo6ibqHrS8EwDlUn72QLkIX7IGWCVxrSM gVGLukvXt8HUv2p6+5OgBfqZ97wbdTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-_faMLM-vMfSyd6CWe7D1pA-1; Wed, 01 Sep 2021 12:02:50 -0400 X-MC-Unique: _faMLM-vMfSyd6CWe7D1pA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9978719611A2; Wed, 1 Sep 2021 16:02:49 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46EB45E253; Wed, 1 Sep 2021 16:02:47 +0000 (UTC) Date: Wed, 1 Sep 2021 18:02:44 +0200 From: Eugene Syromiatnikov To: Cai Huoqing Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Message-ID: <20210901160244.GA5957@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210813120803.101-2-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813120803.101-2-caihuoqing@baidu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > commit <47595e32869f> ("") > indicated the ipx network layer as obsolete in Jan 2018, > updated in the MAINTAINERS file > > now, after being exposed for 3 years to refactoring, so to > delete uapi/linux/ipx.h and net/ipx.h header files for good. > additionally, there is no module that depends on ipx.h except > a broken staging driver(r8188eu) > > Signed-off-by: Cai Huoqing This removal breaks audit[1] and potentially breaks strace[2][3], at least. [1] https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e140c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/net.c#L34 [3] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/sockaddr.c#L30