Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Sep 2021 15:51:21 -0400
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Scott Wood <oss@buserror.net>, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] retire legacy WR sbc8548 and sbc8641 platforms
Message-ID: <20210901195121.GB165712@windriver.com>
References: <20210824174209.GB160508@windriver.com>
 <87pmu09rg1.fsf@mpe.ellerman.id.au>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pmu09rg1.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q70gkpS/lekVTSgyVGHpluFqee+e3LtC8v/xnomh/ciCIMP81QOPTmDbtVFs?=
 =?us-ascii?Q?jQSVeHwhNNtWtbkrZa2p6UggeRyCvZIwHUV4Ky+A8FCA1oJjK1MCezFnhl3e?=
 =?us-ascii?Q?wo9KxYB3Xdt3esCjmdL+InSjl49Gyc1iJk05FOEB5CjGLeMs79pUypjjXzAO?=
 =?us-ascii?Q?t43AYCTiypxsrEQwVjSGOReJO7KT3p2XTo0jxOdGXuCw/GI5aUXuB9EVhGTW?=
 =?us-ascii?Q?7eqp2HZRvijUG1zMzomgHeeUQIRzE/qFkUfGZfDCTmO2p+89b1wWgPbKnIJF?=
 =?us-ascii?Q?fIN/hspuiDjXjlpMttpzcAIp82FbIJvwh+MQlQQm2rxO5jkVERL3tKGbRSM1?=
 =?us-ascii?Q?ob6us6B/xeTLci/KjcMu+DhcsB82+sXvXpJwZ+fMTVsaF4Vu+7+r0/glX7FS?=
 =?us-ascii?Q?MStFstfawjotgflZca7jGGQc/Zao/ofxnH5Twwr+aCqfFFAf5gvfnL/R6i/s?=
 =?us-ascii?Q?A4TN3w3eCV1IDYc5bISI7enZ5+OjDLUBgRvTEX7o/1gxukRC1AabCKm2LbfX?=
 =?us-ascii?Q?HPOcpkuZcMQ+MnUfGqZ+pZli5N9ZvFpLXcMfE6KyCKN7E7yN3Y6cQZQJK9a8?=
 =?us-ascii?Q?l/+IZyGsX18bmNDsfcnuyAzxSbG1vh4JbP5jimmfSqbSkk8JTRQaQF8TScgU?=
 =?us-ascii?Q?K44CvCTIMcCRqLWVmcGyNCnz3s3JZFU4m/PxeCzKfpnQWoaiQ0tLRi3j4yGj?=
 =?us-ascii?Q?fJ0P24BCzkphNT4gmoxKxKr4iLX23ckEDsVhWsdgp63Ft1jxj4oYowODJjS8?=
 =?us-ascii?Q?uXOA5oPREcFRw34irZfJGZrTu99UWrUNQ/0v5augWpqml+HR1FVoXTc1dsG1?=
 =?us-ascii?Q?HK1lOfoM7EW3/8ayXwGU74W+8NtxOIdoObnCE5k8FHAYuNQNcTBXA34UULza?=
 =?us-ascii?Q?TwinWXqF5mJOsGvxBqIErRLyJnJGckSPi63kaqb4dIZjLhfIbBG1f8Xqc8JN?=
 =?us-ascii?Q?tg5k4/N8s8umgOk7Wky24X0YMvbYGF+GSTNEe5VnduAEw8+6OmJaWqnz+HBO?=
 =?us-ascii?Q?MWox++quZ+D0DWE2ihtBsr+LTCR56v2Y5B+CqXaCoi/w5HxmyT8OZ+Lpw2bj?=
 =?us-ascii?Q?YSM0BlIdCO2EvtHenocMnYrn7NlUN59Y+WlA33CwoekoaHsTC6S0Oiro8TyG?=
 =?us-ascii?Q?wLVSRQCJkKQd4AehkFqtC6BETqgT1yUkJzPrWCtKA2OPdP79YmO15jh2W1yt?=
 =?us-ascii?Q?2cSF1hfL31UvarZqWYYWNiJG5VSmdqSUotpkfEMs0ysHORU0eFAY+/fG3fgG?=
 =?us-ascii?Q?g0DpTSJiGpA1EbOPbDI/WpXgceGd8h1vOypCD+Z3qgQ561TfXYiMsj9ijUTP?=
 =?us-ascii?Q?GUKWBEDLqHAz73A4M613Jcfj?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b69a79ab-7655-44a7-d1ef-08d96d81e1e3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 19:51:26.3124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kdnw6Yki0G4UOO6T5r3TTDcerLQj4JbUxXKWdm5xWo2pN1B6Bmdlz+JqziE3hZ2K71KppeWEnhYQAvJtnN3tlPn4KstVnpZGSI4EifjRT2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3465
X-Proofpoint-ORIG-GUID: uPreOWnf_UKxETE7GwFsAieegsBqwr4N
X-Proofpoint-GUID: uPreOWnf_UKxETE7GwFsAieegsBqwr4N
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-01_05,2021-09-01_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0
 mlxscore=0 spamscore=0 priorityscore=1501 mlxlogscore=930 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109010115
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[Re: [GIT PULL] retire legacy WR sbc8548 and sbc8641 platforms] On 27/08/2021 (Fri 01:05) Michael Ellerman wrote:

> Paul Gortmaker <paul.gortmaker@windriver.com> writes:
> > This is unchanged from the original wr_sbc-delete branch sent in January,
> > other than to add the Acks from Scott in July, and update the baseline.
> >
> > Built with ppc64 defconfig and mpc85xx_cds_defconfig and mpc86xx_defconfig
> > just to make sure I didn't fat finger anything in the baseline update.
> 
> Thanks for following up on this.
> 
> I ended up cherry-picking the patches into my branch. I like to keep my
> next based on rc2, and merging this would have pulled in everything up
> to rc7 into my branch.
> 
> I don't think you were planning to merge this branch anywhere else, so
> it shouldn't make any difference, but let me know if it's a problem.

That is 100% fine - as you guessed, it is a dead end branch, and there is
no real underlying value in preserving the baseline for removals like this.

Thanks!
Paul.
--

> 
> It should appear here soon:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/log/?h=next
> 
> 
> cheers
>  
> 
> > Original v1 text follows below, from:
> >
> > https://lore.kernel.org/lkml/20210111082823.99562-1-paul.gortmaker@windriver.com
> >
> > It would be nice to get this in and off our collective to-do list.
> >
> > Thanks,
> > Paul.
> >
> >   ---
> >
> > In v2.6.27 (2008, 917f0af9e5a9) the sbc8260 support was implicitly
> > retired by not being carried forward through the ppc --> powerpc
> > device tree transition.
> >
> > Then, in v3.6 (2012, b048b4e17cbb) we retired the support for the
> > sbc8560 boards.
> >
> > Next, in v4.18 (2017, 3bc6cf5a86e5) we retired the support for the
> > 2006 vintage sbc834x boards.
> >
> > The sbc8548 and sbc8641d boards were maybe 1-2 years newer than the
> > sbc834x boards, but it is also 3+ years later, so it makes sense to
> > now retire them as well - which is what is done here.
> >
> > These two remaining WR boards were based on the Freescale MPC8548-CDS
> > and the MPC8641D-HPCN reference board implementations.  Having had the
> > chance to use these and many other Fsl ref boards, I know this:  The
> > Freescale reference boards were typically produced in limited quantity
> > and primarily available to BSP developers and hardware designers, and
> > not likely to have found a 2nd life with hobbyists and/or collectors.
> >
> > It was good to have that BSP code subjected to mainline review and
> > hence also widely available back in the day. But given the above, we
> > should probably also be giving serious consideration to retiring
> > additional similar age/type reference board platforms as well.
> >
> > I've always felt it is important for us to be proactive in retiring
> > old code, since it has a genuine non-zero carrying cost, as described
> > in the 930d52c012b8 merge log.  But for the here and now, we just
> > clean up the remaining BSP code that I had added for SBC platforms.
> >
> > --- 
> >
> > The following changes since commit e22ce8eb631bdc47a4a4ea7ecf4e4ba499db4f93:
> >
> >   Linux 5.14-rc7 (2021-08-22 14:24:56 -0700)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git wr_sbc-delete-v2
> >
> > for you to fetch changes up to d44e2dc12ea2112e74cdd25090eeda2727ed09cc:
> >
> >   MAINTAINERS: update for Paul Gortmaker (2021-08-24 08:19:01 -0400)
> >
> > ----------------------------------------------------------------
> > Paul Gortmaker (3):
> >       powerpc: retire sbc8548 board support
> >       powerpc: retire sbc8641d board support
> >       MAINTAINERS: update for Paul Gortmaker
> >
> >  MAINTAINERS                                 |   1 -
> >  arch/powerpc/boot/Makefile                  |   1 -
> >  arch/powerpc/boot/dts/fsl/sbc8641d.dts      | 176 -----------------
> >  arch/powerpc/boot/dts/sbc8548-altflash.dts  | 111 -----------
> >  arch/powerpc/boot/dts/sbc8548-post.dtsi     | 289 ----------------------------
> >  arch/powerpc/boot/dts/sbc8548-pre.dtsi      |  48 -----
> >  arch/powerpc/boot/dts/sbc8548.dts           | 106 ----------
> >  arch/powerpc/boot/wrapper                   |   2 +-
> >  arch/powerpc/configs/85xx/sbc8548_defconfig |  50 -----
> >  arch/powerpc/configs/mpc85xx_base.config    |   1 -
> >  arch/powerpc/configs/mpc86xx_base.config    |   1 -
> >  arch/powerpc/configs/ppc6xx_defconfig       |   1 -
> >  arch/powerpc/platforms/85xx/Kconfig         |   6 -
> >  arch/powerpc/platforms/85xx/Makefile        |   1 -
> >  arch/powerpc/platforms/85xx/sbc8548.c       | 134 -------------
> >  arch/powerpc/platforms/86xx/Kconfig         |   8 +-
> >  arch/powerpc/platforms/86xx/Makefile        |   1 -
> >  arch/powerpc/platforms/86xx/sbc8641d.c      |  87 ---------
> >  18 files changed, 2 insertions(+), 1022 deletions(-)
> >  delete mode 100644 arch/powerpc/boot/dts/fsl/sbc8641d.dts
> >  delete mode 100644 arch/powerpc/boot/dts/sbc8548-altflash.dts
> >  delete mode 100644 arch/powerpc/boot/dts/sbc8548-post.dtsi
> >  delete mode 100644 arch/powerpc/boot/dts/sbc8548-pre.dtsi
> >  delete mode 100644 arch/powerpc/boot/dts/sbc8548.dts
> >  delete mode 100644 arch/powerpc/configs/85xx/sbc8548_defconfig
> >  delete mode 100644 arch/powerpc/platforms/85xx/sbc8548.c
> >  delete mode 100644 arch/powerpc/platforms/86xx/sbc8641d.c