Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: vsp1: Make use of the helper function
 devm_platform_ioremap_resource()
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210901055709.8079-1-caihuoqing@baidu.com>
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Message-ID: <8b184d7c-1e55-3227-c01a-41f45b3402b5@ideasonboard.com>
Date:   Wed, 1 Sep 2021 09:15:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210901055709.8079-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/09/2021 06:57, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/media/platform/vsp1/vsp1_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
> index de442d6c9926..8acd6d45d8d0 100644
> --- a/drivers/media/platform/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/vsp1/vsp1_drv.c
> @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev)
>  	struct vsp1_device *vsp1;
>  	struct device_node *fcp_node;
>  	struct resource *irq;
> -	struct resource *io;
>  	unsigned int i;
>  	int ret;
>  
> @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, vsp1);
>  
>  	/* I/O and IRQ resources (clock managed by the clock PM domain). */
> -	io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	vsp1->mmio = devm_ioremap_resource(&pdev->dev, io);
> +	vsp1->mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(vsp1->mmio))
>  		return PTR_ERR(vsp1->mmio);
>  
>