Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1006647pxb; Wed, 1 Sep 2021 15:07:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfZuxlbby9YDY+CkuqfrAkpT94ox1Yg0r5EtN8xHC9DO+u+Ds7ufikcYOKU4bJ23HLy+VK X-Received: by 2002:a05:6e02:f08:: with SMTP id x8mr1150547ilj.92.1630534022003; Wed, 01 Sep 2021 15:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630534021; cv=none; d=google.com; s=arc-20160816; b=t0u9K7lspDd+GktmugsVLs14Rb5CZuD+8w2xUwDv8aAwU5mhVhUX4jHu8271smWMlV Q4Mpyl+kL0lYnQva8nng8TGa6TIXmlLTxtUJLa02ITwWbhLX1IdS9T0EgeYPcSwx4yJR qr1eVQaIveGj3eCkyhgJkeMyS1nr1UPZJ7qxT9azEmzf9Yi4QTu5w7jFhUC1kjtT0mEf X30EZeCMaCplaRBRLm7YEy3/7yDM+CqwsyhWYhHY5k9v5HL/e5kDvn27949kOjnfnlUD jXP1xVFOsNcfguD6DUEifhkrVx0YvzPvmzBX2X6rul1FcqZiIn1G6jdgxB4AYSPRNcIG OQBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rdWUEKr9aPPFP6twvSr37LxY2YTVgcIfWNdeW5K8LRk=; b=tAUqilq7kp1/8D5vM/hORh7wh5zJ3ZwWrIWkrLVZMh3bzpXRek1q63pMo9JG6vy2oY kSZ17Sc3IZ7JHa4nQy98IhfQgwb0Islm1rCZkqTCzghub5tR1bxQpu0fWZT4uTApx+HV oz8Cqdzzsneuf9bkQrXbiKU94bVPW3CP5+pwzcDgEiekJeN305dVrbRWqUpZnuYeFSDl n+VEILtfnCWJGIOpMvFAjH1P8u8fl1H2ahDG3AfwBEWzEl1A2RKPMjCjJuYtVFoNDx4r /q18ICp8Yxa5TPSWza5QbIVSd11Soy8T7cVICqUkJrSuUhDzskR9Qxlwi7FYuDwDgqtc DuoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IWjAP9il; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si25664ila.73.2021.09.01.15.06.47; Wed, 01 Sep 2021 15:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IWjAP9il; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345666AbhIAMse (ORCPT + 99 others); Wed, 1 Sep 2021 08:48:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:48326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345637AbhIAMow (ORCPT ); Wed, 1 Sep 2021 08:44:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 75BA16113E; Wed, 1 Sep 2021 12:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630499929; bh=gE9y4BMgno56b6Di4lUpJzX78/XLtt4GCu8UQGSu1NQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IWjAP9ilQqu8JIQpdfE5Ma4RxxftP77OW/x59o5mVa+poCrPr1HpNIb6g4WSiS0fS IMiJV35R71cGTR1s70rU+Ub3FrdyKJ05AAgroV/ZXMBp+IKSklZHN3X071T1Nh4iC8 qJiV21HckKRoyRUnc/Z95ArJj6+c5xlZS9ohMKzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dinghao Liu , Selvin Xavier , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.13 039/113] RDMA/bnxt_re: Remove unpaired rtnl unlock in bnxt_re_dev_init() Date: Wed, 1 Sep 2021 14:27:54 +0200 Message-Id: <20210901122303.288818109@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210901122301.984263453@linuxfoundation.org> References: <20210901122301.984263453@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu [ Upstream commit a036ad088306a88de87e973981f2b9224e466c3f ] The fixed commit removes all rtnl_lock() and rtnl_unlock() calls in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock() in the error handling path of bnxt_re_register_netdev(), which may cause a deadlock. This bug is suggested by a static analysis tool. Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities") Link: https://lore.kernel.org/r/20210816085531.12167-1-dinghao.liu@zju.edu.cn Signed-off-by: Dinghao Liu Acked-by: Selvin Xavier Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index 25550d982238..8097a8d8a49f 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1406,7 +1406,6 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode) memset(&rattr, 0, sizeof(rattr)); rc = bnxt_re_register_netdev(rdev); if (rc) { - rtnl_unlock(); ibdev_err(&rdev->ibdev, "Failed to register with netedev: %#x\n", rc); return -EINVAL; -- 2.30.2