Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1010957pxb; Wed, 1 Sep 2021 15:13:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1vXx7KlPs4Rurwlbjk3yiGQiepvsVMrF6oCGNpacdh6qmQCroP2ysFU9NrPRiqvbn44pO X-Received: by 2002:a17:906:7f01:: with SMTP id d1mr85151ejr.318.1630534415894; Wed, 01 Sep 2021 15:13:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630534415; cv=none; d=google.com; s=arc-20160816; b=pHaOlFMMz5Pc9+CZHeEJKPj3d1dkspBEppUsYDkDH9wOTZ0C5wo8avKOew925eZSAo CmMwknsGpm9bNgY2I9KEvHdW+ZB5X4GKdSxVp6ruI7gyW9YzmisYqQMoMHaP4dycSBWn xOsy51GO7wTydVxZIKaTn172hHlE0afe/Hkc5urYjjYHrVN0LbI+LokeftFuhzK4E/Ji a4gd2e/PeZLHXTF33I4r56ptc6w/NJ22sMOhq0O9ja7qqpkspXOarqL5FWoDOUXW/tEw j7fztlgz6SZbu4+TfIYa4epVww6sfrYNCjPIPdYJj2BnG92r0HFfvonDgViEbxUxm7iV JjpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rWn7ftNaH8rbL859GMPoBcotFaPKpKStnLjvnz2RQIM=; b=cDsyCmNatI6z3b/teO+Pma5fnE0oB3A7DCAgiaCQO2VCv5rKUqDVTZiZ0OXXhwUVvk SDz+ahAxPR0xJx4oQUTZV/gebUFBvmVKcQVjagqbs4Eygm+wXwnUADGvpWFLbGI3h4OY frGrCgfhCl1N/4bT0kAVyp4LAZF8dI46ESfX8KYp2YP22pBquWdzU3P1gScDz4RK1qHm zHvAamD4Pne51SDptV6mD9Rgwa1PFrDptKBbPboCmmKSMmQw0cb8RFKlsT4czh2YHG+G Hr9Kn3ni9Ptp2ZdnnidAa5IocWDIvjmkjpGDDoH3y4RunzMFeLFJBy371WJrRTG+FwSe Lj8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BdiHgCUq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr12si1053569ejb.335.2021.09.01.15.13.11; Wed, 01 Sep 2021 15:13:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BdiHgCUq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244308AbhIANhk (ORCPT + 99 others); Wed, 1 Sep 2021 09:37:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:39058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242520AbhIANhk (ORCPT ); Wed, 1 Sep 2021 09:37:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E926260698; Wed, 1 Sep 2021 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630503403; bh=iWV/crwUlweYuuVzke2dYQ+pYgqthMaN8n3LIPnihbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BdiHgCUqNRrhyv6XKd5+/JLMD6es+hkGOHRglz2ISAKzz1WJ6fFLM9bxgWtayYBly 8eOIJ5JYl0e5OjH7S2HC0ZOJ3TmBWtfEFAK9bzsoItXdJ/6eD3LWEY4VMDXpwWdz+T NWAeOKA7uONcCYe6pL86dtFeIFoEkWdWCOxTiJv+sACk//43I1//GsMsACtncQCX7O rGbts6KA2/cP8GI4ZXjV15kftYxQ3si7jY3Ztu6csnhhLM0wr6tKemaGos9XJKNXvP ZHso8+2YvhzWn3s6qiiKKhw16kmb6nap7OiLhncal5CTFr9AGCMDv7tNYkrw7PXTbr 8LRonnY0A3VdQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 881B04007E; Wed, 1 Sep 2021 10:36:40 -0300 (-03) Date: Wed, 1 Sep 2021 10:36:40 -0300 From: Arnaldo Carvalho de Melo To: Nakamura Shun Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Rob Herring , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: libperf: lack of interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 01, 2021 at 09:45:10AM +0000, nakamura.shun@fujitsu.com escreveu: > Hello. > > I'm trying to change rdpmc test in perf_event_tests[1] to use libperf, but libperf doesn't have enough interfaces. > Does anyone plan to implement any of these libperf features? > > - Interfaces that can run ioctl (PERF_EVENT_IOC_RESET) from userland > - Interfaces that can run fcntl (SIGIO) from userland > > [1] https://github.com/deater/perf_event_tests/tree/master/tests/rdpmc So, while in this specific case you should probably follow PeterZ's advice, feel free to submit patches moving stuff that is in tools/perf/util/ to tools/lib/perf/ (libperf) when you have a reasonable use case, such as Vince's test suite. We can then discuss if any adjustment is needed, but doing it this piecemeal way, with justification, should be a good way to enrich libperf with things that are in quiescent state in tools/perf/util/ and that have external users. Thanks, - Arnaldo