Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1018112pxb; Wed, 1 Sep 2021 15:25:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEIM1Il74SlNWpc4S8nvg841OBVl2cpmxX7zldXRvIrPDRtlgHb0Tz56IxcWYEAJlp0UpI X-Received: by 2002:a05:6638:59:: with SMTP id a25mr123703jap.111.1630535147957; Wed, 01 Sep 2021 15:25:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630535147; cv=none; d=google.com; s=arc-20160816; b=J5iaJE953V/JwT9HDJKkEfTJe9cP3eMcFScbkcAa+79+kzuHlJ82v9zLD5paIRnylt LLnUZXj1DjXro4UeMVpVBl5PQom3piZ/lUEkhGSBa629xC7mWUaQDifcFZ5cFU9TaPg5 7SozyEOuZJBBw8dHzJ/YdhdMAZbc4aEoXuboltNopWabVTbxtJlEP42ha+hCdSoVNBKb n2kFZ9LUqoAeh7tftpwhcoDnVCR3TI5xX/2nektPsXerp0DBJlCPv1Wt60omlrXUF280 FcHVmhVaFlY2uzMkGfHq5HzUqRvDBs9Giu5g2ZKtfm6D/6TilTc30FmntJvFhn34ZHrv czbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=TFvsn1Vu39hsNbhEPHNzOXZ3d4CPqiedKNbByx0eETA=; b=OcpvGQnjxF5t68AFkS6ylT0RGKkAe+XzpbqAIjZ4IJV2MstiDt3YKHtaedtFwuzNl3 qdHJSYFCAW0ySTe2WR25pq5mXsrEPih1jw+onkZ2PyKgcMNQ5gOQARUj+4ycs3v5UPZz CBIu7q4iLebHo8AOpzZ5/Vy8tvoKG+i3giYErxT1g3T+wIhL1jXCPe67WH/EQ/x9hBqR b7Y0/P1OePpgWclp3Ezr1PbnqHs2GPgs188qQZwTlDkgh2kgSAbhfBLrxAwo11+/eFKI qaUYFki713gdgXVpKPkxIuKZ0UKJ6w9pfEI6eIQMSY1EwYxkYtH+nEECO4VEXfNbuNlW nj6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RU55tzVX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si60043ilq.133.2021.09.01.15.25.36; Wed, 01 Sep 2021 15:25:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RU55tzVX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344300AbhIAQxT (ORCPT + 99 others); Wed, 1 Sep 2021 12:53:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48398 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344325AbhIAQxP (ORCPT ); Wed, 1 Sep 2021 12:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630515137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TFvsn1Vu39hsNbhEPHNzOXZ3d4CPqiedKNbByx0eETA=; b=RU55tzVXdm+wTLnfb05d6aEPexdA9WMqTDkXoM/ydHoDPw6l5uAYWsgxHNiHzOOJa3T4Ga RKWQGCsBLEwQQmun/wziUUJDr+iegZ6X5XWCwkNlgcXNSCavz3d/YtC9phn/I7+w6TugdR 6UrkGW3ogPaAyCgXmRxf+yOUGbYGIHI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-5lVYr0grPgqxlMWjHEDMAA-1; Wed, 01 Sep 2021 12:52:14 -0400 X-MC-Unique: 5lVYr0grPgqxlMWjHEDMAA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79BC76D581; Wed, 1 Sep 2021 16:52:12 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B6DC5C1BB; Wed, 1 Sep 2021 16:52:05 +0000 (UTC) Date: Wed, 1 Sep 2021 18:52:02 +0200 From: Eugene Syromiatnikov To: Cai Huoqing Cc: linux-audit@redhat.com, strace development discussions , linux-api@vger.kernel.org, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Message-ID: <20210901165202.GA4518@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210813120803.101-2-caihuoqing@baidu.com> <20210901160244.GA5957@asgard.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901160244.GA5957@asgard.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding linux-audit, strace-devel, and linux-api to CC:. On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote: > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > > commit <47595e32869f> ("") > > indicated the ipx network layer as obsolete in Jan 2018, > > updated in the MAINTAINERS file > > > > now, after being exposed for 3 years to refactoring, so to > > delete uapi/linux/ipx.h and net/ipx.h header files for good. > > additionally, there is no module that depends on ipx.h except > > a broken staging driver(r8188eu) > > > > Signed-off-by: Cai Huoqing > > This removal breaks audit[1] and potentially breaks strace[2][3], at least. > > [1] https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e140c23f68e0c94d95ab6e/auparse/interpret.c#L48 > [2] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/net.c#L34 > [3] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/sockaddr.c#L30