Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Sep 2021 14:10:39 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     Qi Zheng <zhengqi.arch@bytedance.com>, akpm@linux-foundation.org,
        tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org,
        vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com,
        mika.penttila@nextfour.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        songmuchun@bytedance.com
Subject: Re: [PATCH v2 6/9] mm: free user PTE page table pages
Message-ID: <20210901171039.GO1721383@nvidia.com>
References: <20210819031858.98043-1-zhengqi.arch@bytedance.com>
 <20210819031858.98043-7-zhengqi.arch@bytedance.com>
 <20210901135314.GA1859446@nvidia.com>
 <0c9766c9-6e8b-5445-83dc-9f2b71a76b4f@redhat.com>
 <20210901153247.GJ1721383@nvidia.com>
 <7789261d-6a64-c47b-be6c-c9be680e5d33@redhat.com>
 <20210901161613.GN1721383@nvidia.com>
 <e8ebb0bb-b268-c43b-6fc1-e5240dc085c9@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e8ebb0bb-b268-c43b-6fc1-e5240dc085c9@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BEanolIKe1FvI4ca+Sqsq7x3WkJUYzKyVPzxNNZa+1hq7GBr3TCku2wWsBhX?=
 =?us-ascii?Q?cW0Hm9ZanDU8vPtvAQYFBkhEfnzQP62NvSPmRZm+UL7qOOLnwYeV2Sdp6aZr?=
 =?us-ascii?Q?elr0AJ7FPULW41uxyshMUKTWvN5LwmjSAjUfH5bHkXqacwNffGQi9LdaDr/A?=
 =?us-ascii?Q?G7fthSbQtFrkY9ijDeYOg1Ozx0yafrPhvC4B2jwCiXw64riNQ/zeq5zo6KWD?=
 =?us-ascii?Q?XAIHyLeHC2tsXAHd4s7mbg0pOQa8vvHG4hYMiTusFhmXVnoxkqt3xyT7NfZs?=
 =?us-ascii?Q?VeMyVel37jbZrjqEFhcZf1D4+8e7CWWNo8fyAwZiESk2hbnEquMnYlfFycJf?=
 =?us-ascii?Q?qzw6Ggp7zil+SGm66k4RH8145NbNCqPsr2//Eqn6LbxWFba+MzmfUCv0k5qJ?=
 =?us-ascii?Q?54mVj8e/MhIo0IypOcnFGSvrvKuNXLk4uypbjeZkgk1hgNVqHoyGLEM8xPJl?=
 =?us-ascii?Q?AgmnQp8ExICcgZnMmlolIB8DcYIhLKvAPY1U7BC+wqM7yW7vNo4wHsGOkCT8?=
 =?us-ascii?Q?cRGnhi/OfbKI/Ed3dQ0kY9Davlqu/1ofpB+LcqVy7hfphPm1ehX7XjieX4fA?=
 =?us-ascii?Q?IwueW14YCsYbXe3Hdb7YIbnGlciPP1/0HonTjahTQ0c51t/CtfVggzt04Bz3?=
 =?us-ascii?Q?z6YVosVyKOSwQzWdwL+bu3EaIWP440XEC8CZTekVMmuCDX6AUnZJhGu2IyFb?=
 =?us-ascii?Q?EGj0VMJftnSC0nnetuxFzJhLXuRd/DipzM+XE9/uT3ju/UwwZWD3vZdKyTDz?=
 =?us-ascii?Q?pQlvd+uZzTJvGdChlZB1CLurqMzpI28XlRCtzgxHH+wQEtJfyQs9dmb91LJG?=
 =?us-ascii?Q?sySVy//ue+ZtHxrOZljLxFvPS0F8lFQ23XbWQ3V6+auu6uLP6mXWCMCs8VN1?=
 =?us-ascii?Q?5VGIomYCbu5HwuUZ+blukOtfbtiPbgObi47kM10NCgsTP4J5EH5gurh9xBhR?=
 =?us-ascii?Q?qnlYb1f60sj8WJmrVeYzUdIx5hdw+O8tW+c6QFf+4YprI4jiwwG20o+IrUoM?=
 =?us-ascii?Q?RyqwgFbEqM54YYGzOrWf7wx6+YUurTfOufruzQEnD50FqzqBnu4+DBStW2j3?=
 =?us-ascii?Q?FbNYWX8WiDVPXxLKpgqQhpZITGhz7jAJ/odYzgIqTJqwEHtB+wZctRWKqGKj?=
 =?us-ascii?Q?qU6Xpe8ISgLeBGC5ZAr2xbNbwvwRSazLjDbQxdGioSRdi2djHgoAxxuHruyl?=
 =?us-ascii?Q?nWIY9RlM5pkIDsMhK2rWpTDIKBqlEHYhKKksfAxRmIIOMy0JSe0sd6/AHvVE?=
 =?us-ascii?Q?qvLp8Xq/0ygsw4NJoixpWISOdidF6aER953foYzHtDicEGqt+5duubx+NAAD?=
 =?us-ascii?Q?A4H79b5PK9uTGrdOZpTYc7ds?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff0e80f3-367d-4100-1977-08d96d6f3fc5
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 17:38:03.2257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tKoN6tqjDdsQqSZ+JoTYEkPs0YtXzFdEPRuG0O2ZDouEIJ1P9pGdFOnY3dvoPK9R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5538
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 01, 2021 at 06:19:03PM +0200, David Hildenbrand wrote:

> > I wouldn't think it works everywhere, bit it works in a lot of places,
> > and it is a heck of a lot better than what is proposed here. I'd
> > rather see the places that can use it be moved, and the few places
> > that can't be opencoded.
> 
> Well, I used ptep_get_map_lock() and friends. But hacking directly into
> ptep_map_lock() and friends wasn't possible due to all the corner cases.

Sure, I'm not surprised you can't get every single case, but that just
suggest we need two API families, today's to support the special cases
and a different one for the other regular simple cases. 

A new function family pte_try_map/_locked() and paired unmap that can
internally do the recounting and THP trickery and convert the easy
callsites.

Very rough counting suggest at least half of the pte_offset_map_lock()
call sites can trivially use the simpler API.

The other cases can stay as is and get open coded refcounts, or maybe
someone will have a better idea once they are more clearly identified.

But I don't think we should take a performance hit of additional
atomics in cases like GUP where this is trivially delt with by using a
better API.

I'd start with a series to pull pmd_trans_unstable() into some
pte_try_map() and it looks like about 25 call sites can be trivially
converted.

Several more can be converted but need a bit of work.

Jason