Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1071321pxb; Wed, 1 Sep 2021 16:50:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW/Yr7tAr/9ftRDD+n9fo0xAvZkbsUn7A0SNOoI59m3bjij4jVKGFOX2sJFP1EDET6dCXa X-Received: by 2002:a17:906:3598:: with SMTP id o24mr458891ejb.191.1630540246186; Wed, 01 Sep 2021 16:50:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630540246; cv=none; d=google.com; s=arc-20160816; b=faCkLLnqJOZOR/RkpQ5vzERtq7Ep83woHdQn7PHSQfmKrumfkpjTiSgH3UOKBhCpWj erBiyqy7FFSuU+4xipaWDxHgJNFouQOpM51w1DezzaA5NI+4vMLGTIbR6/prrrybi58T GpptVvIPP9erHvREJNb8qbdNr/r08FVke1ybtvdt1dDylRfi/keL9ZdefPTiV1MuTpDM wqOEgZPHaPOI3AG/AtUJ/bjU9IYr8HH0AS8qT5P1c5glams2hOi8VpF1TuIOZkxr31nD x/IeZXFPlChX/g/GpbaDqgFQPMfNfgE5T0wCAD8arSMP11ghEPXZj5l/3aBGPI0DWVL+ P06g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HxwuV0BeQWwpRI/6sMdLU80DQpiU/qy8K3f3w8+UPd8=; b=M2k/U9DNd/R8dT/FYBGxO7oyhrEzJMxHQUIy8CcqpFRFSc/z+6JdzxHnbKHIYG+PG7 Hhkvey9rbptrP+bLMn52oRp6wAn2TsZs+RrzpZRnozEHCkAL2f43aWIDRjWaPtcj/ba7 Qi02D/WAlhpEYfDPZ3CJIOwVwvI1Rtnc1a/ws0xN/E42ChUYfkkX7RQoa6iKOPI9pr9o 0PLGLo0ajR/ckhayYC9C+yUNaEtZaMIQNdipNSp1pUR3ZJbipUXWG4JfFaGKaQ/ArgPL 4GN2Q6hX76+lBuVwnr0g+0M1Jo4JWGN4FdJjfwFPUBYPPpczlD84oP4tsDwtLKg+rd8L IRTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YgccQiWf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du10si14068ejc.547.2021.09.01.16.50.23; Wed, 01 Sep 2021 16:50:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YgccQiWf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbhIAXFI (ORCPT + 99 others); Wed, 1 Sep 2021 19:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbhIAXFH (ORCPT ); Wed, 1 Sep 2021 19:05:07 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6533C061757 for ; Wed, 1 Sep 2021 16:04:09 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 17so1056723pgp.4 for ; Wed, 01 Sep 2021 16:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HxwuV0BeQWwpRI/6sMdLU80DQpiU/qy8K3f3w8+UPd8=; b=YgccQiWfa0BA9wl5D4A783k/FalQF0lNHO4CTlk62dckfSkCv2umLqsVmA4WOY9Uhu /uKCmHiSmee+sZmM7URFxlal/t+4wUNjAYv9qo1H3XYjnlR4yEiIsWl2w5iqQJdc4HcA 8LurG6+D/DZZxa3coCp1vKSk7DAHrep7HsfjBVSlptdQAgqt4VrACpu7jw1K4w/VU/SM 9XfO89VmNU2VK6QP/VgS8LrZflFFNdpOB9lSYv+eHZ1FiKpJa5c4ED4e0gRhi4wQXUNw eQGdcdK1prxWmFmOXVJmiTw0hJ2bxrH2M3YXfgzbEjZZ4o6t5MWZtMmPNY+hKTTaagoM e3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HxwuV0BeQWwpRI/6sMdLU80DQpiU/qy8K3f3w8+UPd8=; b=cwM0NMQZduwDQmPxVWkIPdlLeUj4ebkdjxKi7fUKXyBuUgIjJrD4dddV5wIOsh7GcI UYXH4Wf02yHxLruIEHa1G3Hrc5HuRR/UQG9UG5Hl83nYZYPLZLHRDxQRo0p/i4ECwlmj 1IAMCZqXAhVoVV0UAwVgl50YPZg54WFuW+G6Fc0INQG8rS+9FARf+ITG17H+I7DheY4Z Ryh1g2iHKX6dFkkUe/9j8oKyh+TkSEs1LryMe8XGIuIBZtB0rsXgWVManMKSjX9eZafr V/ArJWfL5P3XNDVlmMl1XEgBsq5itjwL7e8XlRXHsvxjplzgAaBBcEa8Zz5buJaQL3FZ N4ZQ== X-Gm-Message-State: AOAM533JaKyblLR4pLoXukxtCkcA1D+QE1A9q5SPNZeFjimBvCcdezPK Bo1y2TPtkLMEkgN0AqfaD0yGcg== X-Received: by 2002:aa7:864a:0:b0:3ee:a4f6:af02 with SMTP id a10-20020aa7864a000000b003eea4f6af02mr223134pfo.23.1630537449197; Wed, 01 Sep 2021 16:04:09 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 17sm52662pfp.28.2021.09.01.16.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 16:04:08 -0700 (PDT) Date: Wed, 1 Sep 2021 23:04:05 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@intel.com, David Matlack , peterx@redhat.com Subject: Re: [PATCH 06/16] KVM: MMU: change page_fault_handle_page_track() arguments to kvm_page_fault Message-ID: References: <20210807134936.3083984-1-pbonzini@redhat.com> <20210807134936.3083984-7-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210807134936.3083984-7-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 07, 2021, Paolo Bonzini wrote: > - if (handle_abnormal_pfn(vcpu, fault->is_tdp ? 0 : gpa, gfn, pfn, ACC_ALL, &r)) > + if (handle_abnormal_pfn(vcpu, fault->is_tdp ? 0 : gpa, > + fault->gfn, pfn, ACC_ALL, &r)) Spaces! ERROR: code indent should use tabs where possible #90: FILE: arch/x86/kvm/mmu/mmu.c:3991: +^I fault->gfn, pfn, ACC_ALL, &r))$ total: 1 errors, 0 warnings, 84 lines checked > return r; > > r = RET_PF_RETRY;