Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     vbabka@suse.cz, geert@linux-m68k.org, akpm@linux-foundation.org,
        ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
        dvyukov@google.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v2 1/2] lib, stackdepot: check stackdepot handle before accessing slabs.
Date:   Thu,  2 Sep 2021 10:01:53 +1000
Message-Id: <20210902000154.1096484-2-imran.f.khan@oracle.com>
In-Reply-To: <20210902000154.1096484-1-imran.f.khan@oracle.com>
References: <20210902000154.1096484-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gjgmWO8k1vK6KLqURL/XlalxTwc1w/FE0DTOpGLE6apyR+rqxDjooo9QA4pa?=
 =?us-ascii?Q?xLvX0LbNHzBoRX2AVWYvmkNgQQTbdYlBy2Ym4LQfLR/bYYM2XatLnImO/BY6?=
 =?us-ascii?Q?7rOA7ZU459+OVqpXdmUIsRVzFVLZn6vV7XOR4hmQ+jSwDdlFfB9KeZrh7Ai0?=
 =?us-ascii?Q?ShhJcYO1kKn2yJw80JvUdF2NMkFOcjtaC2zmDMxyaW5bUP6RITJXSp1+95dp?=
 =?us-ascii?Q?dO/eQw8Q01ZyMiX511iXi4E40t2+J2cGjNATv/JktETm+3+jAzvoCS6AUQb5?=
 =?us-ascii?Q?mgQR53Sjorbt0oyXSGx5H2CUpFRvWlQuhSUqGi0Dxi/QLbiM0iwgtVduobpx?=
 =?us-ascii?Q?JL81lKxI1iqdMCEH7HlZbXqc5O3fpEAsDY0RH0cM2+do0+vsVd+Pr90+GFSd?=
 =?us-ascii?Q?RO0ZKw1tsKQbd1aJLa0/szJYIefxjpiezxe9QtZ89jnZKLWs+nFnDWj3CB9x?=
 =?us-ascii?Q?0CwQrwTGyU8eSiBVJgFCUBnELy8zZA3xNDC0nYr/VbEmElC8HhnVL2zBjXJS?=
 =?us-ascii?Q?EfV4sd6hLm8J6NKwma0Fa9aqy1oRQGlujhzenRwis99yLEWXtftFt5ELL2cj?=
 =?us-ascii?Q?984mADEzyDXYpBKrYR/euZm9SksoViyuDMwbuIfcw9Xxn/wuQpoXMpVtgBTX?=
 =?us-ascii?Q?/cWyzPgG4RFOtEugIGLCXZO/iG8GZ4enT0W2ZjwVYYDRklbn09FPu6cvcBHH?=
 =?us-ascii?Q?MRr83tHUyrCl+iBlmCcvUvazQEBSh+RyloTGSVpkXmzrvM0sZ7rXBeEIF/tw?=
 =?us-ascii?Q?ac5K4h1C3m6Bs5ACAcYZfZ8ssCsWRe+pYNS4S1QHdcq5H7mqIladWS2SX25J?=
 =?us-ascii?Q?KvWO9RQfVu2h8wRzSDmvrMOG09r8jea4LQeCRW9FZXg8fq6yxq93tCv7ut3x?=
 =?us-ascii?Q?wxZvtgRlE1xv42Dyh2mF7GdWyCgnRpxAgYlzkE7vv+S5m9Ts1cnHvorGhalN?=
 =?us-ascii?Q?YDmm+VTpVmYZUtFDoi2EZo3pLcud9ebN5e+5fVsikZezoX+WQ5wGGitApCYA?=
 =?us-ascii?Q?QH818pYJpvQTAG8wucFNQqldDXc1HkQT3mxBCmcD+3I6ahKpNdSoBIKUyLTB?=
 =?us-ascii?Q?wCW9bJXQC03i9PdS5VV0ZoBrEiYi+6wvaS/MKyius4B3QNS3+8db1Fuxsi5v?=
 =?us-ascii?Q?JIBwmsC+hUoEDk4E57+SmkGVLteWrDB0KGMd8wqaFOofsglhpBgtCKXTrKhe?=
 =?us-ascii?Q?ac7ighhpeHrAupWIZPbmXljw60AE31iT8M/RO7Fsl8g9EYYnvgppxWkq8V3U?=
 =?us-ascii?Q?GZIgrL8gLvTdHI8JuhYxxKY0rlU/tUVZvYEDvS4jmhuGXpN3II6AKeMinO1b?=
 =?us-ascii?Q?a0AGhS/IZGDBlib9cAP4RCpJ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f8d4cb-7161-4682-2be9-08d96da4e9f8
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 00:02:12.2153
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 22FzBX8wqsqSFx0+E4kzObcjg8o951D/g28NDkdq91uo0y4Yt/IqyBbYXGlREnTPaJc5sLtzi0w+YPgHdJfcVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1999
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10094 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=961 spamscore=0 phishscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109010142
X-Proofpoint-GUID: KIQAn8PNIMQbP2KwYLHXjWEaPucXewF8
X-Proofpoint-ORIG-GUID: KIQAn8PNIMQbP2KwYLHXjWEaPucXewF8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

stack_depot_save allocates slabs that will be used for storing
objects in future.If this slab allocation fails we may get to
a situation where space allocation for a new stack_record fails,
causing stack_depot_save to return 0 as handle.
If user of this handle ends up invoking stack_depot_fetch with
this handle value, current implementation of stack_depot_fetch
will end up using slab from wrong index.
To avoid this check handle value at the beginning.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
---
 lib/stackdepot.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 0a2e417f83cb..67439c082490 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -232,6 +232,9 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 	struct stack_record *stack;
 
 	*entries = NULL;
+	if (!handle)
+		return 0;
+
 	if (parts.slabindex > depot_index) {
 		WARN(1, "slab index %d out of bounds (%d) for stack id %08x\n",
 			parts.slabindex, depot_index, handle);
-- 
2.30.2