Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1095212pxb; Wed, 1 Sep 2021 17:30:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBZxQC9K20u67fQvuu23HWOB+87PrDvaMbFnH9vrGU/nKlABplZn98OT9sBbUaKUWHSXR8 X-Received: by 2002:a17:906:28db:: with SMTP id p27mr662229ejd.94.1630542609071; Wed, 01 Sep 2021 17:30:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630542609; cv=none; d=google.com; s=arc-20160816; b=lp1+o4HwCZMHHYE6BvwDdV6UdWL4aU+9lXlNEbn4qhzM5PL3aiEgeuZRTScO2monmb m4KS0PjpVZhaBXwxz/WognLl0o89ntHDIdzzAVTUsnlZP2a1nqNwv7XQi1DM++o0MicR 7ClCfvrPnbGji3Ws1GLfLHoPO9xuHEfbb6enpdnCYqTrDfQKtthwPY7xfbOkAyZwVddo ujrehtSdZWJOy3gdTVMbQfKtHkOJi3rTMHWLFpZVyckJmnPIV1gj7Nk9GOfgtGkBtJOi 9EJ30kezE2/jnVIhPHZWrcgEaNqQRyUuK7T69AQaH5+glm6pKXm9/66nIn9LLnu0rjky +ipQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dmarc-filter:sender:dkim-signature; bh=BpMsY1jdJn9vV9BVN++XtWtWBzsDBD0Qi5rln/LVvzA=; b=scyy6pcEemlwxkIouqxVCUo2/CXilV7qAeghz4UV8wS3VxRaHbJbGhfjAhsJLi5OHC dICSeabh/5uSk6yt0eUA6zVnBwVOB1ny8XlSNOCJcFIAskTwK/P6VzwYcb5Pq/VkLmWI MntAtDjIetkn6lQbAoZTsoHtA0Ehc6Tz/gHn5calbo4sPKHNbuZb4etD3mIZv53+PUmS 9ITVLFrTAOEEa1cbpBFNqFHeD2UpUs82f0Ht+KCzFzA4LFNkTiO4b+3j103Do2t3tJ2C 9elpv7hqqgNaeWyADDRbTz/dB1HXU3rxdPhDY0eVkcViDKKxeX6KHWQ7X4tHv3ps53SU 1giw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QmBaMsvt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si336946edz.580.2021.09.01.17.29.42; Wed, 01 Sep 2021 17:30:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QmBaMsvt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244195AbhIBA3M (ORCPT + 99 others); Wed, 1 Sep 2021 20:29:12 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:30757 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239492AbhIBA3M (ORCPT ); Wed, 1 Sep 2021 20:29:12 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630542495; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=BpMsY1jdJn9vV9BVN++XtWtWBzsDBD0Qi5rln/LVvzA=; b=QmBaMsvtklFod84APo8YQJqvsqYT/Z98ayHIjzxMMYmiipglexQR3bWlg6fRz+dRHRtAQnNI QI92VMO3sM7u8rCJ55atM79tltcOrmJsKw4IN1OThjjVczF5OnJYX2+mnBlCe+TffLbr/gCx 56Udt7vIP+EpE+kL0XYN7OS7RaU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 61301a9e6fc2cf7ad93bf464 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 02 Sep 2021 00:28:14 GMT Sender: jackp=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 203B4C4361B; Thu, 2 Sep 2021 00:28:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from jackp-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jackp) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7FF4AC43460; Thu, 2 Sep 2021 00:28:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 7FF4AC43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Date: Wed, 1 Sep 2021 17:28:04 -0700 From: Jack Pham To: Thinh Nguyen Cc: Pavel Hofman , Ferry Toth , Felipe Balbi , Wesley Cheng , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "agross@kernel.org" , "bjorn.andersson@linaro.org" , "frowand.list@gmail.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "heikki.krogerus@linux.intel.com" , "andy.shevchenko@gmail.com" , Ruslan Bilovol Subject: Re: [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Message-ID: <20210902002804.GA3500@jackp-linux.qualcomm.com> References: <874kchvcq0.fsf@kernel.org> <8735raj766.fsf@kernel.org> <60e57455-3768-ab1c-efad-b6a64e592b36@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60e57455-3768-ab1c-efad-b6a64e592b36@synopsys.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thinh, On Sat, Aug 21, 2021 at 02:57:07AM +0000, Thinh Nguyen wrote: > I took a look at 24f779dac8f3 ("usb: gadget: f_uac2/u_audio: add > feedback endpoint support") that Ferry reported the issue from > bisection. I see at least a couple problems in the new UAC2 changes. > > 1) usb_ep_dequeue() is asynchronous. Don't free requests before the > controller driver give them back. > > 2) Did you test with SuperSpeed? I don't see companion descriptor. We caught this too when testing f_uac2 in SuperSpeed mode. I can prepare a patch. Thanks, Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project