Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 2/2] lib, stackdepot: Add helper to print stack
 entries.
To:     Vlastimil Babka <vbabka@suse.cz>, geert@linux-m68k.org,
        akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Alexander Potapenko <glider@google.com>
References: <20210901051914.971603-1-imran.f.khan@oracle.com>
 <20210901051914.971603-3-imran.f.khan@oracle.com>
 <f425e27a-8f4a-7687-589e-b726085c5c7a@suse.cz>
From:   imran.f.khan@oracle.com
Message-ID: <9527f084-4d60-2a85-f4e3-8e16cf7aad08@oracle.com>
Date:   Thu, 2 Sep 2021 10:11:11 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
In-Reply-To: <f425e27a-8f4a-7687-589e-b726085c5c7a@suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmR5dWEyenRpQzdHL1I1MzJVaGh4OFo0cUFJdzR4eHBvTENWNnBkRGUyNDR3?=
 =?utf-8?B?UTBQTmlpSjNBRW5sMTRMTWoyVGJ0L1RobER0WlE2Lys1RkFTV1V5S3NiMmpN?=
 =?utf-8?B?a2ZQWGQzQnBUUHI5WWZPWTNsb3oxQ3VLamI4VjQvMks1MWZhcmE5dFpjSzJG?=
 =?utf-8?B?ZWVkdDR4ZlA0RURKcDc5NmdwUFBva1lPa2ZZNklKa095YzVRb0NBaHNWZk1a?=
 =?utf-8?B?SWNNbjV5UzZDSjhRMUVjbCszcklLc092blBLa2t6Rlg5Z1NGN3lwNnRPcnh3?=
 =?utf-8?B?RTJHSURyTXRoMzZBeGt0eDBmKzZmc0VsMGdxUFVZcElGbTRwZWNTNGlCaHR3?=
 =?utf-8?B?QnY5b0puK01RdHI5YWlPVHhIMEZobzhpSEVTNnRPZUExcXB5MVpxMjhpOHpN?=
 =?utf-8?B?b0N0ODhuQ0UwdzJPRHcxSVUyaEg0R0ltcThSUWRjcE9RbHMyNHdVQUxKY3lN?=
 =?utf-8?B?SEx4eWZzRGRlbHIxa0o2M2RLemNxT3FtTlk5dkx4bGRadVcvaE9Kcm5tZk41?=
 =?utf-8?B?dDBqT0FVR3dUak4vYXpvVHdpVTlsYUVPRE9VdlBUNC9MdW1qbU5zd2NQYTU3?=
 =?utf-8?B?VDF4ZzVaUzcxM3NtbnZnVjIwTWtzVmZHYXlrSUFXRnZGTFY0b0FON05teVlO?=
 =?utf-8?B?ZkpCSWpBbWMwWmsxUnhhRkNDQWUyRC9PL01qRm5yZjdPSThpbGwyWGtDNHBm?=
 =?utf-8?B?TVhGY2o3UTZORm5WOFR0VnVFNFBXRXp3UEI2WG1ROWNoQUUwZHJBUUg5TnBL?=
 =?utf-8?B?bldRYzRpVjFDVkQrTEdRQVdHZnJRVVFJdm5raG55WGVDTGdtaHBvd3F6MHRi?=
 =?utf-8?B?N1UyZHZFQjBUYTVCdmlVQXk1bXBsZ1BlRjFCVWtyMDZQQTJrM3k1c3hwMnFl?=
 =?utf-8?B?aTd2NHQwVnc1S3FVUThQT0NKZS9rdTJsZjJhYjNQbk00SDlWdjFPSDlSWUcw?=
 =?utf-8?B?VjE5a0tzdFBLcnh2dnhSRzFVT3BnZ2tGcTVjd2g2ODVYWnJsSUlKWFIzaDZC?=
 =?utf-8?B?VDFFWlkxTTFRS1BVRG1uU1VET0RuREsyUzFkWXlFWDZ2MFlaQ1FQQU5aMGZB?=
 =?utf-8?B?engrSVZDOFRhOHY5OVNsL3dhUldSZ0ZEaURIaXlwSXU4Vjl4ZHRjamhkbFk1?=
 =?utf-8?B?eXI4Vk5vNDA4Q1pMLzhHQVpRYkFpR3RVNzdXR2Y3d21ObHBwMVh5ZVJSY3B1?=
 =?utf-8?B?bGZ1SkplSmdCV2IwQXNoTC9hYUU4Wmx4aSt2UjRSU2FnU0g3cXhka2NsazJI?=
 =?utf-8?B?TjFlODVkdEVCYzY4cUNoS2dIM1ZGdDVxdHJzZENQWXYyRm43Wm5ZL1A5cXdU?=
 =?utf-8?B?QW1tWEpUc3N0aVhmb3dLeW1uUVpYZlAyQW5UT0RnZVNVWW1OUCt3dWk4Wnhk?=
 =?utf-8?B?dUJUTWFJanlyL1lRSFRSejZJRTU0NnFSdUQvV2FoVVd4TGtkWHVJcHZQYXpR?=
 =?utf-8?B?R2JmTnpaNlJ3NzhyaUNTRUVhaXNPT0tBRzFRWlZFT2Y4dDZNeXVTTTdOWkNo?=
 =?utf-8?B?QnZQdTlGWnNIMWtNT0hEYWMzbkRhOE9DSDF2Y2ZTaUhOYmNjSjYwOG14UHZY?=
 =?utf-8?B?MmRyNWpRYjl6akVvd2FCV1R1bTRDRnJyd2IzL3RoWjh4Wk1IeHM5bWh0c2R6?=
 =?utf-8?B?VXRKZGNDMTNzTnZZU0RpTFJBVDF1SWFXb2FzVzMyZ011VXBTMG9tWDRXdUY3?=
 =?utf-8?B?Ymx4YjVYZktjUFlJUTdrbEdIYVNXTHZaUFlLTnRpSUw2VzZOYzRVMlZ2cjVU?=
 =?utf-8?Q?EaSwl7SdV7ODnXkLreSlCIWAuBQa9zABaDNeP5h?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10f9000e-f6d0-4420-fca9-08d96da62f0a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 00:11:17.1909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eekha0YGNZhsxXJPz36xngqBpb/SsYUdSGM/aDopwGACMPjuinPBO2BReWqZ/DGVMYbNOhhVFlrZb8nPz8vVkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2128
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10094 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0
 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109010143
X-Proofpoint-GUID: U3uNTfKioEHoY-yUuoqua2X8-UaWHiLn
X-Proofpoint-ORIG-GUID: U3uNTfKioEHoY-yUuoqua2X8-UaWHiLn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vlastimil,

On 1/9/21 7:07 pm, Vlastimil Babka wrote:
> On 9/1/21 07:19, Imran Khan wrote:
>> To print a stack entries, users of stackdepot, first
>> use stack_depot_fetch to get a list of stack entries
>> and then use stack_trace_print to print this list.
>> Provide a helper in stackdepot to print stack entries
>> based on stackdepot handle.
>>
>> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
>> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> 
> You should convert existing users together with the patch that introduces
> the helper. I think print_stack() in mm/kasan/report.c, and
> __dump_page_owner() could use this.
> 

Okay. I have done this in v2 of the patch set. BTW I also see some users 
(one place in page owner, rest all in some gpu drivers) of 
stack_depot_fetch + stack_trace_snprintf. Could you please let me know 
if it would be okay to add a helper corresponding to 
stack_trace_snprintf as well.

>> ---
>>   lib/stackdepot.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
> 
> It's missing a declaration in include/linux/stackdepot.h
> Perhaps it could be all be a static inline there anyway.
> 

Agree. I have added missing declaration now. I have not made it inline
though.
>> diff --git a/lib/stackdepot.c b/lib/stackdepot.c
>> index 1d42ef9ef766..eab4476b060b 100644
>> --- a/lib/stackdepot.c
>> +++ b/lib/stackdepot.c
>> @@ -214,6 +214,23 @@ static inline struct stack_record *find_stack(struct stack_record *bucket,
>>   	return NULL;
>>   }
>>   
>> +/**
>> + * stack_depot_print - print stack entries from a depot
>> + *
>> + * @handle:		Stack depot handle which was returned from
>> + *			stack_depot_save().
>> + *
>> + */
>> +void stack_depot_print(depot_stack_handle_t stack)
>> +{
>> +	unsigned long *entries;
>> +	unsigned int nr_entries;
>> +
>> +	nr_entries = stack_depot_fetch(stack, &entries);
>> +	stack_trace_print(entries, nr_entries, 0);
>> +}
>> +EXPORT_SYMBOL_GPL(stack_depot_print);
>> +
>>   /**
>>    * stack_depot_fetch - Fetch stack entries from a depot
>>    *
>>
> 

Thanks again for the review.

--Imran