Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1d303f4553e67abee4f0c4cdc32231813a4bcb3f.camel@perches.com>
Subject: Re: [PATCH 2/5] fs/ntfs3: Use consistent spacing around '+'
From:   Joe Perches <joe@perches.com>
To:     Kari Argillander <kari.argillander@gmail.com>,
        Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        ntfs3@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org
Date:   Wed, 01 Sep 2021 21:22:19 -0700
In-Reply-To: <20210831181505.1074767-3-kari.argillander@gmail.com>
References: <20210831181505.1074767-1-kari.argillander@gmail.com>
         <20210831181505.1074767-3-kari.argillander@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2021-08-31 at 21:15 +0300, Kari Argillander wrote:
> Use consistent spacing around '+' for better code reading. Checkpatch
> will also be happy.

I think you should remove the + instead

> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
[]
> @@ -1451,7 +1451,7 @@ int ni_insert_resident(struct ntfs_inode *ni, u32 data_size,
> ?		attr->res.flags = RESIDENT_FLAG_INDEXED;
> ?
> 
> ?		/* is_attr_indexed(attr)) == true */
> -		le16_add_cpu(&ni->mi.mrec->hard_links, +1);
> +		le16_add_cpu(&ni->mi.mrec->hard_links, + 1);

		le16_add_cpu(&ni->mi.mrec->hard_links, 1);