Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp232712pxb; Thu, 2 Sep 2021 02:59:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxi1kmZfe32g9PXzTo79AfihebNAXr1MNWDAOqCssi1wOnfWRs9GQM2b/ryUzSgS7AOu3wp X-Received: by 2002:a92:c8c3:: with SMTP id c3mr719085ilq.188.1630576768467; Thu, 02 Sep 2021 02:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630576768; cv=none; d=google.com; s=arc-20160816; b=MpQGeMVJzp2TGrghP2UQHSF651qOyngkRl5cH4P+Kf7XztPj3XJS0Zzu/9sq5fxP4i H9SCQ7MtuIDreNDCADYnHtWcZJxHScgHGiJExHgXY4C1cMp68GP4Hzo8TKVmVCLhxIVJ mzBENYBk4DQBj9KumEwjo/7ICVz+1/N2eaLpnyIYIIwco6lbPOWUjFVI1Ig8cvXOctHe eDQz376fe1ne0COAnlovSO7p59siRrn96qxEEM0sDt5rG/UzDZswBRX/KwDa3krJlC9U ff1mg+bSVC8yPFpK4Z6106Ez6U4aU1bUih8lxadWIOvxYFl9IfSFmICUlQKnA7QnuKC5 UIVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=bNGxjpK9PzuX2of46KycTprMp/7HQDonLvpDPvUTlKQ=; b=LEvIyJ3p/k60O03gEicXuP5g2iTwHOPvXaSRJpmyqgzI2pMQXpQoAIHu35nUfwiTOW u8MmWsZapXLq/jmFY/VXSAAhBpqTb8c9c5uCL8a3ccqhPDViU9th1UZkzGMcCDAdlvSd jdQgn6eNX9ktkPHphkONS3VqG5+IlMv49z81S+B63V69S7Lb8QjhVLEExvILVL1O4XCr DTEvwBwnggbfqsuwQcM56nHGuf1vd9x1i3Wp1Y1N9Kuw54kdhznJd0D/jFC2xbTX6BVC OCa+U1/hBAGtIszS5f9bkdX8+zqsePI194fYzUT+QZx/UNVDyAf4UzSTsVbOfw9xjlOr TGXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si1587807ils.161.2021.09.02.02.59.17; Thu, 02 Sep 2021 02:59:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243426AbhIBH3D (ORCPT + 99 others); Thu, 2 Sep 2021 03:29:03 -0400 Received: from m-r2.th.seeweb.it ([5.144.164.171]:46595 "EHLO m-r2.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243381AbhIBH3D (ORCPT ); Thu, 2 Sep 2021 03:29:03 -0400 Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 2D5323F35F; Thu, 2 Sep 2021 09:28:03 +0200 (CEST) Subject: Re: [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock To: Marijn Suijten , phone-devel@vger.kernel.org, Bjorn Andersson , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Andy Gross , Michael Turquette , Stephen Boyd , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Abhinav Kumar , Jonathan Marek , Matthias Kaehlcke , Douglas Anderson , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20210830182445.167527-1-marijn.suijten@somainline.org> <20210830182445.167527-3-marijn.suijten@somainline.org> From: AngeloGioacchino Del Regno Message-ID: <8d2719c9-16e6-5915-5c40-98a76d87f042@somainline.org> Date: Thu, 2 Sep 2021 09:28:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210830182445.167527-3-marijn.suijten@somainline.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 30/08/21 20:24, Marijn Suijten ha scritto: > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > real clock is named "xo_board" in the DT. The standard nowadays is to > never use global clock names anymore but require the firmware (DT) to > provide every clock binding explicitly with .fw_name. The DSI PLLs have > since been converted to this mechanism (specifically 14nm for SDM660) > and this transient clock can now be removed. > > This issue was originally discovered in: > https://lore.kernel.org/linux-arm-msm/386db1a6-a1cd-3c7d-a88e-dc83f8a1be96@somainline.org/ > and prevented the removal of "xo" at that time. > > Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/clk/qcom/gcc-sdm660.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c > index 9b97425008ce..16fd16351f95 100644 > --- a/drivers/clk/qcom/gcc-sdm660.c > +++ b/drivers/clk/qcom/gcc-sdm660.c > @@ -37,19 +37,6 @@ enum { > P_GPLL1_EARLY_DIV, > }; > > -static struct clk_fixed_factor xo = { > - .mult = 1, > - .div = 1, > - .hw.init = &(struct clk_init_data){ > - .name = "xo", > - .parent_data = &(const struct clk_parent_data) { > - .fw_name = "xo" > - }, > - .num_parents = 1, > - .ops = &clk_fixed_factor_ops, > - }, > -}; > - > static struct clk_alpha_pll gpll0_early = { > .offset = 0x0, > .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT], > @@ -2281,7 +2268,6 @@ static struct gdsc pcie_0_gdsc = { > }; > > static struct clk_hw *gcc_sdm660_hws[] = { > - &xo.hw, > &gpll0_early_div.hw, > &gpll1_early_div.hw, > }; >