Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [GIT PULL] Networking for v5.15
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        John Stultz <john.stultz@linaro.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
References: <20210902092500.GA11020@kili>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <38288aff-71d4-bde2-7547-dff5ca20091c@linaro.org>
Date:   Thu, 2 Sep 2021 10:28:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210902092500.GA11020@kili>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02/09/2021 10:25, Dan Carpenter wrote:
> I'm sorry John,
> 
> Can you try this partial revert?  I'll resend with a commit message if
> it works.
I was about to send similar patch.

This should work, I think your original patch introduced a qrtr packet 
payload alignment constraint which was not there originally.


Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

--srini
> 
> ---
>   net/qrtr/qrtr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index 525e3ea063b1..ec2322529727 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
>   		goto err;
>   	}
>   
> -	if (!size || size & 3 || len != size + hdrlen)
> +	if (!size || len != ALIGN(size, 4) + hdrlen)
>   		goto err;
>   
>   	if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
>