Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
To:     Nirmoy Das <nirmoy.das@amd.com>, rafael@kernel.org
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
References: <20210902102917.2233-1-nirmoy.das@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <3f34d9a7-d5cb-5b41-7813-11d75eb25f0d@amd.com>
Date:   Thu, 2 Sep 2021 12:31:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20210902102917.2233-1-nirmoy.das@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk5NZE5VS1pOSjVqRUdHUkgyTFptTHVMb21JN3lDMzlyclNRWlpSMGJua3lr?=
 =?utf-8?B?Z21CNVhXWVd3RTVOS0hwWWdIYnVNVEdyV1NDaFRiMEZic0tCeEJhTytjNTNV?=
 =?utf-8?B?aEdKbVdxT0N3b2RYcGo3QzdsNGVOc1dMQ3FLRk5Dc1RuVHU0UTdFalJGV3NS?=
 =?utf-8?B?QmtOREF4U2I3bWdsQWduTzRJSFlLdkpUd0tMdnlFc0cra1EvdlIyTmQzeTJ4?=
 =?utf-8?B?Y3krNEttSHZlM2MvZjRJYldWM2RNZUhYUGh3ZldXVnJWc3puZjcxWHg5QVV1?=
 =?utf-8?B?SndjcVRIWjc2SWJrQ3BtcEE3VmIvVU9meTArZUJvRWtvWERUeHV6UWVNWUl0?=
 =?utf-8?B?WVA1RmZtNm5QYjl3bFNiMlhMT3JHM0FYLy94R3hOVjNXTENhc2REV2FzZ3Ni?=
 =?utf-8?B?ZW02UThqb2Q3cFloMEh0Zm53WVIyS0ZuYWNIZkNQWFJiZ2tyVEhVL0x3NzhI?=
 =?utf-8?B?OUZQTE5LZnFuUEJleGdkWCsvdlFBK0JabWo3TTJrQXFPajNObzlnNmZFWHVz?=
 =?utf-8?B?WFlVNWoyd3dEN3VmVmdXWlVtRFBXb2hyMnFUNlhtTEpHM3lTV050YkxPd2VR?=
 =?utf-8?B?MnNicXgxVGxrZUpLQXNSVTVJQVNEak50MkZpYU42b3JnaDNySk1uYzFOK3hJ?=
 =?utf-8?B?TVdFakR4UElhdzdJNUhlRTNydjZHdEhwL0luMzZqUFVNbnpIQ1Y3NGZFNDVX?=
 =?utf-8?B?bTFTckhON2MwZVFURG41UlBnc0xZL2dsRU05YXIxbmVybkQ1VVBiRXBpV0VR?=
 =?utf-8?B?VXBCV3N6KytiMGtiN3VTNUdGWFdsME56MWs0aUZSRnJzYm82ZnFGQzlpWnhF?=
 =?utf-8?B?VzlsZk5idElLbEdXbEszVi9ueElqSGVRT3dqRHQ2MU1ZRnVFSmxwdjBpNk1T?=
 =?utf-8?B?cHhrWGNPK09HVWxaUS8yOFQwUHpZVjZUeW5nVUswTENwUk9sUWk0TGZFNFF0?=
 =?utf-8?B?UnA3MXBUV1Q4ckpBeGN0WjBwQ3N5bWhDc3NTZCtNWVM5cllpdmtNVHFPRm9K?=
 =?utf-8?B?R0ExaStqVklNV29OMk9yZ1AxSmdxOEtkSW83ejFsajNJWC9WdlVwT1AzWFVy?=
 =?utf-8?B?eTM0SVZjdGFUOGRucFBwRXZvUVhaYWozdEc4cTArMmNKWjJrNVV3Y2hlRUhP?=
 =?utf-8?B?QzcvcmJIS25tWUlucHkxREVmcVdzV0JtemVLNC8vTkV5U2puUTRQVGdUUEVz?=
 =?utf-8?B?WVBLdHhMQnRsSXcyd2R1ZzZMY2ZGZ0ZiK1QyL0IvaS9jZktnZmFOV1RZL29t?=
 =?utf-8?B?Z210Zng5NkZXdlhGVDltakduSUZmNi9FMUdHaVJYUFNWdkRCWFE5SjZmNG83?=
 =?utf-8?B?TnFadmU1eCtwN0l4R01rZFdUWVJaOEFnZVl3UEx5S3lWaWJlbFc3YmpyWjNi?=
 =?utf-8?B?MXZwbGU4M2lpRFI0K1NTcHEzY1Rkcjd0S2N2UTcrUWlaa2lwOVBOaSt2cXE5?=
 =?utf-8?B?ZEFBanZLd0x3REJDOUg4ZXI3N3JnV0QrNms1YmJZaGpObzN4a1gxMzJ6N0Ux?=
 =?utf-8?B?T0N2Mnd4ckQwT1Z3WTRWb3MwZG1VQjdXSUZzYlBMWTFIWGMyMGpmYVJSVDRS?=
 =?utf-8?B?LzltTkRvVm9lWEhyVmNGSXRoQWMrNmpYeTZRNjAyWlpPNU9IL1RxWWQrVldx?=
 =?utf-8?B?cFBvSkRaU3JieFBqOFgrZUo5UG1aSnVXbk96U2hFM2xxQmFpUGZKUjh2bHZq?=
 =?utf-8?B?bW8vOGs2Qi9MdjQzSzNLNmNYTHZEUTViZXFGdXJsWUxyZWxDV2ZTS1F6RXlJ?=
 =?utf-8?B?bVg3Yll6T0hkYnlxMCtFSEFIOHlnZ1cwczZaRTZDSFZWbmVTNDhVRWJoOWpS?=
 =?utf-8?B?Z3pIWDNhejFIbnFibi9Yc0tjN203TWJUbWdtRC9kdGk3RFIrNjd0Q20xMEFk?=
 =?utf-8?Q?cRIsjsC7PVFEL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77597c99-d4c4-4cc3-63dc-08d96dfceb05
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:32:09.3310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 47RQwYdF7HPU5i4rbL7nahde4B2f4sV4/OK8hl06QGIZZYMnrhYfSYs07k/Pu0/h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3693
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 02.09.21 um 12:29 schrieb Nirmoy Das:
> debugfs_create_file() returns encoded error so
> use IS_ERR for checking return value.
>
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   fs/debugfs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 8129a430d789..2f117c57160d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
>   {
>   	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>   
> -	if (de)
> +	if (!IS_ERR(de))
>   		d_inode(de)->i_size = file_size;
>   }
>   EXPORT_SYMBOL_GPL(debugfs_create_file_size);