Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Sep 2021 12:38:50 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Nirmoy Das <nirmoy.das@amd.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org,
        Christian.Koenig@amd.com
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
Message-ID: <YTCpuo00wM7jGSIc@kroah.com>
References: <20210902102917.2233-1-nirmoy.das@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210902102917.2233-1-nirmoy.das@amd.com>
Precedence: bulk

On Thu, Sep 02, 2021 at 12:29:17PM +0200, Nirmoy Das wrote:
> debugfs_create_file() returns encoded error so
> use IS_ERR for checking return value.
> 
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
>  fs/debugfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 8129a430d789..2f117c57160d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
>  {
>  	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>  
> -	if (de)
> +	if (!IS_ERR(de))
>  		d_inode(de)->i_size = file_size;
>  }
>  EXPORT_SYMBOL_GPL(debugfs_create_file_size);
> -- 
> 2.32.0
> 

Ah, good catch, I'll queue this up after 5.15-rc1 is out, thanks!

greg k-h