Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c5505b203829fbcafefc9ec34cc1d7d7158c7359.camel@sipsolutions.net>
Subject: Re: [PATCH] drm/ttm: provide default page protection for UML
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org
Cc:     Thomas =?ISO-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Christian =?ISO-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        Huang Rui <ray.huang@amd.com>, dri-devel@lists.freedesktop.org,
        Jeff Dike <jdike@addtoit.com>,
        Richard Weinberger <richard@nod.at>,
        linux-um@lists.infradead.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Date:   Thu, 02 Sep 2021 10:11:59 +0200
In-Reply-To: <347e4cb8-a7c5-9e1b-16bc-96805442d35b@cambridgegreys.com>
References: <20210902020129.25952-1-rdunlap@infradead.org>
         <9faacbc8-3346-8033-5b4d-60543eae959e@cambridgegreys.com>
         <f978cae5-7275-6780-8a17-c6e61247bce7@infradead.org>
         <0887903c-483d-49c7-0d35-f59be2f85bac@cambridgegreys.com>
         <288a2d4dbcb1e6b0fbeff6da86569aa92df09202.camel@sipsolutions.net>
         <347e4cb8-a7c5-9e1b-16bc-96805442d35b@cambridgegreys.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-09-02 at 09:10 +0100, Anton Ivanov wrote:
> On 02/09/2021 08:43, Johannes Berg wrote:
> > On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote:
> > > > > 
> > > > > I have a question though - why all of DRM is not !UML in config. Not
> > > > > like we can use them.
> > > > 
> > > > I have no idea about that.
> > > > Hopefully one of the (other) UML maintainers can answer you.
> > > 
> > > Touche.
> > > 
> > > We will discuss that and possibly push a patch to !UML that part of the
> > > tree. IMHO it is not applicable.
> > 
> > As I just said on the other patch, all of this is fallout from my commit
> > 68f5d3f3b654 ("um: add PCI over virtio emulation driver") which is the
> > first time that you could have PCI on UML.
> > 
> > Without having checked, in this particular case it's probably something
> > like
> > 
> > 	depends on PCI && X86_64
> > 
> > as we've seen in other drivers (idxd, ioat).
> > 
> > The biggest problem is probably that UML internally uses X86_64
> > (arch/x86/um/Kconfig), which is ... unexpected ... since CONFIG_X86_64
> > is typically considered the ARCH, and now the ARCH is actually um.
> > 
> > I think we can just fix that and get rid of this entire class of
> > problems? Something like
> > 
> > https://p.sipsolutions.net/fbac19d86637e286.txt
> 
> Good idea. I suspect that DRM will not be the only thing to pop up out 
> of this so we might as well fix it "at the top".

Yeah I sent like a handful of similar patches ...

I'll send that patch out in a minute, just writing a reasonable commit
log. Seems to build & work fine for me.

johannes