Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Sep 2021 13:08:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     John Stultz <john.stultz@linaro.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Srini Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH net] net: qrtr: revert check in qrtr_endpoint_post()
Message-ID: <20210902100851.GD2151@kadam>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <38288aff-71d4-bde2-7547-dff5ca20091c@linaro.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JbZRJbZ6EmQ+1bHkHZXPj7KqQANq1nghXJrOu+h6G4i099mU+nzZH/iHnpa6?=
 =?us-ascii?Q?7NoLDWKyKzKgTLxSwOfXkzog1PU278It9v3mpsExlyyiOUdqfxiqhOpeeBuT?=
 =?us-ascii?Q?++ihtGO/OG6g1HLbDw1fkp11f2feuUZzxgGjbDEsti6E/grQ66Lyz2pTbC12?=
 =?us-ascii?Q?jfQzPu4UlzVZKqPYueUIlNk1iulya+PLg9EqdSSyN3TZ74wbbQKRWHEOpEyr?=
 =?us-ascii?Q?+WIIZjx15gBfAlJK6+lHBydQPpsZTiftha5NLTNLQo2psO9Oae96Y6FiH2Dg?=
 =?us-ascii?Q?xeAjGnMT9Yy3vU5SZMbjcWddgOzG9sVokfDCgSqEefXGC64wfHO79leWCjaM?=
 =?us-ascii?Q?fJSStVbnO9Xn6allHhP75C+RBleHaKSh6XqtbdN/5GOUtFNkdb+Kr0MgLqzZ?=
 =?us-ascii?Q?eyyFDGocuxKz27V02P4KjhhPZnAi61QJw8zj2/n0ZBhh74dA8t2JyPROWsCi?=
 =?us-ascii?Q?Lng073vnAAXmMPxPCEnsJ2M+pXqLTwOMkL11v/URrYd5coO34UBH12CgycWB?=
 =?us-ascii?Q?dgdiQb82IK2Hjswmrxo5OrRC7JbLheAyfMuofrfPGo2Cn8dgfNruPepiepRL?=
 =?us-ascii?Q?5s2w5tgFRm0c0+g7DMHh0MjMm8O0DlPHBj6IZa+SNrNDXK74e+cqJ3Ui+VNz?=
 =?us-ascii?Q?0EgMAh15hSj5AZPbUUPl37l48j/Zmu6CCGO/PbvdJpBC6erdeEPdgxHQS96A?=
 =?us-ascii?Q?F+9oxBNQ17uNtL29UQ5ni/RZ5tAlxdWTE82PiMNnbfWs3r/FtF/qYdvNu5ni?=
 =?us-ascii?Q?QGpBlI2xhkg1znLC/Gs7Qlp+eOJyvmqKkMRUuDLGUaQmoReVPGyUOqvpxJsJ?=
 =?us-ascii?Q?XN1Kd6pswNMqvGnW6jWbmGuJVjC51hUhLabBuJglPCjtFfKEAyLe4flun5pz?=
 =?us-ascii?Q?qrlRSvxIy+3RcztQZLIeop/CA/K1Z44LEEli0sSnM24VcqGj8kS/QMw+a09b?=
 =?us-ascii?Q?Wym4VjoUTZxIgvVWuJecT9reY3Ong09H+7gADgeaKfc1zJ+f95XaiNIeFzUr?=
 =?us-ascii?Q?RgD272J97r6pYX0nxpPR10G5uuVizoNv1RfOLiCybt4i/DJYq2CQ/ZfqRuMJ?=
 =?us-ascii?Q?usV/KpNAscNuLTL/Mlm/lwbl3O3er6SMTneHM41a4/1jHvyu8f2V/M6HDcwM?=
 =?us-ascii?Q?q3wHQOMPvOq9JRy/C761CfLLOPTetaUr/hTywhax3f/ZD5usgnxyE6VtIbFR?=
 =?us-ascii?Q?sYUAb58R/lDyflC1ZBR4Fdb4odLxuhgbi0YwSw/5C2uWkVxd0xsMHvarnsHa?=
 =?us-ascii?Q?amzQf2K2yHLCim8ai21YkPvl6sZrCTyE587KI5FyxPq/TObFGl+9Zqw/P9St?=
 =?us-ascii?Q?OwlFp+U3B1kut9+zhqyq2Qr0?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93df9a12-aa1f-4205-4a49-08d96df9b651
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:09:12.4160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Al0JV+lhx5gIZzkVmy26xS4S2dTtPJlfNRvUfj9fXb0slwVsIIX9xzoIxiKysb2FXbBzNeO/9zktbfsky1Z9mztHLMKJXAPhUzvYVMrpLdE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2368
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10094 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109020063
X-Proofpoint-GUID: 8FWFZTESGLkwMqIHeuk7eM_WVIjaEmsw
X-Proofpoint-ORIG-GUID: 8FWFZTESGLkwMqIHeuk7eM_WVIjaEmsw
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I tried to make this check stricter as a hardenning measure but it broke
audo and wifi on these devices so revert it.

Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter")
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 net/qrtr/qrtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index 525e3ea063b1..ec2322529727 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
 		goto err;
 	}
 
-	if (!size || size & 3 || len != size + hdrlen)
+	if (!size || len != ALIGN(size, 4) + hdrlen)
 		goto err;
 
 	if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
-- 
2.20.1