Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp271463pxb; Thu, 2 Sep 2021 03:57:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyp7qnVnPgVqU4bpTPzFsWjTo09hDoE3OdY3ZqRI+nxRq/y7p5MSH+FGu/kEo8+MGvsXg/+ X-Received: by 2002:a5d:9253:: with SMTP id e19mr2296115iol.35.1630580228709; Thu, 02 Sep 2021 03:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630580228; cv=none; d=google.com; s=arc-20160816; b=vyFDA9LN4MKWK8rfBlfbT98FjqR4sRXwUsWgPmBk6V1Oml2WPmPqdI0kI4LKnryL/5 Po9XypR/6eKFdRAXmfEh9wg0l6wi46m5aRlp77unAG6GymV0Dawx1aOb6e9p9lxaRgyM qg0hZ7xGop133iReEXc2E+mW8CMiITmYAFI+uwR1ofNry53KPdOf+m/xWrHX58KtaU9z 9AG04k7D3e+GgAN1YgvzUVTL214yw8AL+JJLnRvGRLtbXM6hqhNkrrm2z+3sEUj+UbbN M2tTzxH1L7wkuNsmAufabUxvYUyeZWhhLiDiakPDtBXUPy8N1fzQ1kwpDqNaS8Q2lie2 AtxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NNOCvedtJlg+4P6Mx1uo74yz4QifcqZ0IryvQ50fEBA=; b=dJukzgc9hsk6Wv+rbxD7EE5T5woj7F/JZeUpIRu52VbIm5cdgzH3MLm7qdCVbwZk2q V867GEL3Slafp22iIb9KlPehWLMAA+1VhvQ6JH9No5Kxmezcm2CCVFbcrg5ZEOcBe4v9 mYzbTjfCWkDB9K2nWzgMlDGpBjS9TW35WashE0Qr+/nsIAI+RW11g4XZWCdTEpAa2dRY 4feQvdtDOV3Do41AJFyKas+Hugr4+GbQTaIQzmlcrH8X/Zfv2+EwfO/Q5fUXMupmjHXo 4kNOEMhJJu/Q/26nMMY0ttdd+HfXR4uTghu7qWIdFxArgyL7GVidoAd9UzP13FuVsV+v 1IDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tU5zJblb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si1613994iow.40.2021.09.02.03.56.56; Thu, 02 Sep 2021 03:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tU5zJblb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233451AbhIBKzT (ORCPT + 99 others); Thu, 2 Sep 2021 06:55:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbhIBKzT (ORCPT ); Thu, 2 Sep 2021 06:55:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C968C60F91; Thu, 2 Sep 2021 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630580060; bh=q0GNvNblP6lxsGan6KTY29HU10SRkr+7SoHSRmhQuD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tU5zJblbO0vmpIY7OfTkrTXk4AzIk6NN/0g6+WOd6GtrHSpfu7XUvVy6IPpdoOOXG 8ahHHMv/HlC78ooogIA/xsH9yPZHV+Uy/Upzp1NFGHqeOVU43yJypQWlnX/GkZB6d5 7kgroJp8X9yktEckGusw3lQ5AsTGacD0YsFEqE1NQ6YHnSc5wi7YQT8XIutobc5emL e3znvaZsXOce/ZEbYNJbLreX1u8Vze9AEYWvA/JOW+Xnc/oUh4tc6rkMiia6ZP5I89 WNCdqi9eyJWRgaBnVXeMAsLnbhjMmQhoLWmCBV0ZYGx4ZtBvgSBybXlbI93l9Zqyr0 4faQ3kVMnHaBw== Date: Thu, 2 Sep 2021 12:54:16 +0200 From: Mauro Carvalho Chehab To: Greg KH Cc: Dongliang Mu , linux-media@vger.kernel.org, linux-kernel , Dan Carpenter Subject: Re: [PATCH] media: usb: fix memory leak in stk_camera_probe Message-ID: <20210902125416.1ad73fad@coco.lan> In-Reply-To: References: <20210714032340.504836-1-mudongliangabcd@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 2 Sep 2021 12:39:37 +0200 Greg KH escreveu: > On Thu, Sep 02, 2021 at 06:23:36PM +0800, Dongliang Mu wrote: > > On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu wrote: > > > > > > On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu wrote: > > > > > > > > stk_camera_probe mistakenly execute usb_get_intf and increase the > > > > refcount of interface->dev. > > > > > > > > Fix this by removing the execution of usb_get_intf. > > > > > > Any idea about this patch? > > > > +cc Dan Carpenter, gregkh > > > > There is no reply in this thread in one month. Can someone give some > > feedback on this patch? > > This is the media developers domain, not much I can do here. There is a high volume of patches for the media subsystem. Anyway, as your patch is at our patchwork instance: https://patchwork.linuxtv.org/project/linux-media/patch/20210714032340.504836-1-mudongliangabcd@gmail.com/ It should be properly tracked, and likely handled after the end of the merge window. > > > > Reported-by: Dongliang Mu > > > > Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb") > > > > Signed-off-by: Dongliang Mu If you're the author of the patch, it doesn't make much sense to add a "Reported-by:" tag there. We only use it in order to give someone's else credit to report an issue. Thanks, Mauro