Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: meson: sm1-khadas-vim3l use one sound node
 configuration with VIM3
To:     jbrunet@baylibre.com
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        christianshewitt@gmail.com, art@khadas.com, nick@khadas.com,
        gouwa@khadas.com, Artem Lapkin <email2tema@gmail.com>
References: <20210812051059.1103641-1-art@khadas.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <247c746b-621c-5db0-25c0-1ef0d0a0d77e@baylibre.com>
Date:   Thu, 2 Sep 2021 15:31:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210812051059.1103641-1-art@khadas.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 12/08/2021 07:10, Artem Lapkin wrote:
> Khadas VIM3L board sound configuration same as Khadas VIM3, its already
> defined in meson-khadas-vim3.dtsi and no need overwrite it with different
> card names and routing configurations.
> 
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  .../boot/dts/amlogic/meson-sm1-khadas-vim3l.dts     | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> index f2c098143..06de0b1ce 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
> @@ -32,19 +32,6 @@ vddcpu: regulator-vddcpu {
>  		regulator-boot-on;
>  		regulator-always-on;
>  	};
> -
> -	sound {
> -		model = "G12B-KHADAS-VIM3L";
> -		audio-routing = "TDMOUT_A IN 0", "FRDDR_A OUT 0",
> -				"TDMOUT_A IN 1", "FRDDR_B OUT 0",
> -				"TDMOUT_A IN 2", "FRDDR_C OUT 0",
> -				"TDM_A Playback", "TDMOUT_A OUT",
> -				"TDMIN_A IN 0", "TDM_A Capture",
> -				"TDMIN_A IN 13", "TDM_A Loopback",
> -				"TODDR_A IN 0", "TDMIN_A OUT",
> -				"TODDR_B IN 0", "TDMIN_A OUT",
> -				"TODDR_C IN 0", "TDMIN_A OUT";
> -	};
>  };
>  
>  &cpu0 {
> 

Jerome could you quickly review this ?

Thanks,
Neil