Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp415931pxb; Thu, 2 Sep 2021 07:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBX4n4p22TQ+bsEmlLDeo+8+8Jc3OrWmbP2Mz+TWz71lzv/WM2Pa6ZG/LHAUcIm2hDS8hl X-Received: by 2002:aa7:d887:: with SMTP id u7mr3783785edq.366.1630591673713; Thu, 02 Sep 2021 07:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630591673; cv=none; d=google.com; s=arc-20160816; b=KA01iMsyn0wFHjoxvwfKm8k69Ag9gh0LwKHHTU2kS6GZEgxcHqMrQ7AJnMEt4QFiZI yyAIklTmEwOpKRiCshzZPd6EGYd/IBtXUrjK5/X4FZei++AtdgKA1Ibw7llHAD98EKfH 8k29S8zpDn3FLuTl2myrmPojLnmhRifSF4c2ICOx2qk8gLpHDDgBI+bWz50H7r4Pbp3h KU3sClilctY+IKsSbjFuk31VebDrlLtsBkVu8eQwOs/yh9nGdWYkx/BIi6l4E5EDKIGs AOOLc/cgEZtZ6J96JbaLfn07dv01Kdypa/Tt7KubMTrUN5oY56YA6ceqjmlc6DCxQKxR KXuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=3i3PEHtjjuRmEIFbhvoPT84lqjnT9WVdvng8ssha5PM=; b=ehxzDpp14U6ukDdQLRVaHwWvViIA7QRnhH4cy4koa8QueZ2u+t09JaD1l2pjE3X7jR KmKYlU2p5DzrBwvhwR75QbHjm/zx5MYfNnEOd8Vhx2fjD/+/jirHNGdQjqCyPTbSi39M nqRnjHdf5QMiU1fI7KsnWJQauHDDYp4crPFGyDLxit1PslBXz8bdi/a/8qT9gL5NIs10 kk3wFdsaxnLq1C1amZ/bX/MCy3ADT8Nr5DMd2EDm0eVNsoRoUBjEhal0gk7AqmuzORxl Xy78bqLikrmJECh/PiRMAyhPEltNIX5QKHIw+eE35aq7UGviHuA/APtMMuFcB/pghbax pyMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si2085566ejf.597.2021.09.02.07.07.03; Thu, 02 Sep 2021 07:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234430AbhIBOEi (ORCPT + 99 others); Thu, 2 Sep 2021 10:04:38 -0400 Received: from outbound-smtp56.blacknight.com ([46.22.136.240]:45031 "EHLO outbound-smtp56.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234398AbhIBOEh (ORCPT ); Thu, 2 Sep 2021 10:04:37 -0400 Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp56.blacknight.com (Postfix) with ESMTPS id 721B9FB454 for ; Thu, 2 Sep 2021 15:03:37 +0100 (IST) Received: (qmail 4898 invoked from network); 2 Sep 2021 14:03:37 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 2 Sep 2021 14:03:37 -0000 Date: Thu, 2 Sep 2021 15:03:36 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mm/page_alloc.c: fix obsolete comment in free_pcppages_bulk() Message-ID: <20210902140336.GL4128@techsingularity.net> References: <20210902121242.41607-1-linmiaohe@huawei.com> <20210902121242.41607-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210902121242.41607-4-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 08:12:40PM +0800, Miaohe Lin wrote: > The second two paragraphs about "all pages pinned" and pages_scanned is > obsolete. And There are PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP orders > in pcp. So the same order assumption is not held now. > > Signed-off-by: Miaohe Lin Acked-by: Mel Gorman -- Mel Gorman SUSE Labs