Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Sep 2021 17:17:45 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] media: usb: fix memory leak in stk_camera_probe
Message-ID: <20210902141745.GD2129@kadam>
References: <20210714032340.504836-1-mudongliangabcd@gmail.com>
 <CAD-N9QXWHeNvR06wyg3Pym8xUb27TsuFKKKG=tZ0-x5ZGCr-Hw@mail.gmail.com>
 <CAD-N9QWj8w-xVAni2cGHyEei78iKEX_V0a00r0x3We7tfFGZjw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD-N9QWj8w-xVAni2cGHyEei78iKEX_V0a00r0x3We7tfFGZjw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G7VF7nOj/TNEIyw8J9mltoyPhOrhJoxH2uIU6D9pQL59s7bcjwgW7WpmJ1d2?=
 =?us-ascii?Q?xLoxrboZI9qhuN56+L219H1QjEK3pLZk/xk3hwoenD7MDkWeMkMSXYjsCaSZ?=
 =?us-ascii?Q?59yd8oS551l9IdlS9Sdh8DT3eXxKrbRGwACP7zHdKqzj7KEkhE3mhyy5Whhi?=
 =?us-ascii?Q?P6hJ2+eyZp+yIEali3OYS5ddraCOeOe8TjARhu20tc8HkTYPY6NqHVsw1hNc?=
 =?us-ascii?Q?WYqOrtMkSv6IMDwnbwgAUHtvqVSNxEYrQ61AuXs6bYCAUb07UuQY+6IEo/yF?=
 =?us-ascii?Q?LfRmXaZosvEXkQj64sEtUzAm7QM9+IXz+hcgkKCvHph3ZHzW7WBdh/Nw9Yv1?=
 =?us-ascii?Q?hh33LUiP3RjLBa1NiM6aYt4I1ys7uguKpXce/xb5T026eIYSOPeR1o0EkovD?=
 =?us-ascii?Q?T5KpYxaK9ir6BJJX0OO5/+1vBl1XgwFWxviqTh+GiPJRKGdjPz9kf6Ij4Y2e?=
 =?us-ascii?Q?RfxAQG4RBJmTMcSt8gpfBurCiwdb8S1sFeADDQDhHXd7CQDIC5jXyusm/6UT?=
 =?us-ascii?Q?RXwkDo+xtSJgooN21OMvgM1NCj1P5SMrHI6Sctu1xHh29jhA6Z0PD4G87nTs?=
 =?us-ascii?Q?gvzKYypkdJCa/ZYC1dwPHofu50MCHGdac6s3dddj25SZqf6qkbRhozVNyNus?=
 =?us-ascii?Q?+Nk4fHxBv8ipzwG3QbZY8slAX+3lSLLlCokdUwc+a62Ly/9IJ+w5CV49kYDD?=
 =?us-ascii?Q?aFyKK2C7UAxiEBF1wsNyDeGhj4QfMirTA0wpAsXtjqvuRzJBaPpvkjYMQJG6?=
 =?us-ascii?Q?eO0o/gZCihzHO1DTPUhg05TGLfkthbu6qyKdO4ObErE3UjsxfyJL1esKVOBo?=
 =?us-ascii?Q?o7Xj1+MMZYw+qys3OOQMmak5r8MDZTYMFUJTjVzSg0O870zU0S5AEAfBzIjw?=
 =?us-ascii?Q?vFQb+Jhkg4S/qUBoKfBJYOaU6V50cp4yXHwTRwdQ0WCV/F/iCcrtrdvmJT+H?=
 =?us-ascii?Q?EnzlL+qXsjT8igALmDv/kZiB7f9JBPmqjeI6RYXozubbVe3VuAy9uhhccWH+?=
 =?us-ascii?Q?qdJwoF+DGuNJAPRYfaNtFrYz+LHe/wyZL0k5YiIsMwx0G84KTOrPWlRLQ5AI?=
 =?us-ascii?Q?5KlGzFEJDH1AA65DQfSuY9gmQm28W867ZChpMKvtYGJreXJZ9hTshcgZqpiV?=
 =?us-ascii?Q?QS93Xn4t6PfW/l9nKxVl2y3StE/P3C0p5oLxGHrQcAg/0nhUCbWTu+wvWOht?=
 =?us-ascii?Q?WsU3/lvVGHMrI3RdUcBvW/p8tMeh/7n/2qeSW5/mowsvDa4irlWvM+KLefdt?=
 =?us-ascii?Q?p8cDlQdFvcQrCaFAEyrlCTk/vcuvDLM7Pi0Kskp/aB877OojGDUdyRgQ9ReF?=
 =?us-ascii?Q?mpuH7RgbzhpwEvgPervbtN0M?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d951a077-72d4-45e9-75aa-08d96e1c78bf
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 14:18:01.6317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PWSU01QLl2XMWTIZDVLdV3xfi5pQikN++YTZitPeKY5c+lfWppnmlG+EQwYnJnMW9GhTz+mOoIhI/2Xz5NlF9e3NE8m054JZGRYEdtxEpOI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4692
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10094 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2108310000 definitions=main-2109020088
X-Proofpoint-GUID: D6gEbqHxdE49KEaIOQheikDRh8gO8gjI
X-Proofpoint-ORIG-GUID: D6gEbqHxdE49KEaIOQheikDRh8gO8gjI
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 02, 2021 at 06:23:36PM +0800, Dongliang Mu wrote:
> On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu <mudongliangabcd@gmail.com> wrote:
> >
> > On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu <mudongliangabcd@gmail.com> wrote:
> > >
> > > stk_camera_probe mistakenly execute usb_get_intf and increase the
> > > refcount of interface->dev.
> > >
> > > Fix this by removing the execution of usb_get_intf.
> >
> > Any idea about this patch?
> 
> +cc Dan Carpenter, gregkh
> 
> There is no reply in this thread in one month. Can someone give some
> feedback on this patch?
> 
> >
> > >
> > > Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > > Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb")
> > > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > > ---
> > >  drivers/media/usb/stkwebcam/stk-webcam.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
> > > index a45d464427c4..5bd8e85b9452 100644
> > > --- a/drivers/media/usb/stkwebcam/stk-webcam.c
> > > +++ b/drivers/media/usb/stkwebcam/stk-webcam.c
> > > @@ -1311,7 +1311,6 @@ static int stk_camera_probe(struct usb_interface *interface,
> > >
> > >         dev->udev = udev;
> > >         dev->interface = interface;
> > > -       usb_get_intf(interface);


The patch is wrong.  We're storing a reference to "interface".

	dev->interface = interface;

So we need to boost the refcount of interface.  Pavel Skripkin was on
the right patch but you need to add a:

	usb_put_intf(interface);

to the stk_camera_disconnect() function as you sort of mentioned.
That's the correct fix.

regards,
dan carpenter