Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp457012pxb; Thu, 2 Sep 2021 07:53:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFb9nDtZ0rVL2l9gNZ0N2O6J5Sc+819yO71CL1aSgAyd7Ds2SF4Bms0ymfWsCF0kqLFLvs X-Received: by 2002:a05:6602:2597:: with SMTP id p23mr3108641ioo.195.1630594393522; Thu, 02 Sep 2021 07:53:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630594393; cv=none; d=google.com; s=arc-20160816; b=cKOtBxoJdTnBnZeaYgdVqEZWS8AU/FK8ZGIr0cjs3yRl2aL+94m1Nl0G0oUUqJe0C8 TuUOxfrHFJfKmX6IpgvZ7gkKITrWMqno+vD/3/g4+fSAkPJqgyjkR9B6Wrt9HpqtEkX9 j6epD+sqogQhjGVPPgSTmFM9+LtaSlbf0Pdn0TSU4/ILHw5oZ9D0kz9BP3IfDjrmkOJm hsq9q1+ufAdl9seuAj1PEL6PQzXKbHrYBLmTLYlXE5jF6tXN4B4+f9d/belKRL5fpJ58 xE15IswABCbUHgj7nFIsQDQhiJFE/bAdTIcLfrdWWGrQ+ICUHI0PP93+EIewzLMjWqRV KprA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EjnWOQTAgeusOSKEt4XAB4oOVGHLEpHHZhMhbTCkZMY=; b=dnOOjfXTHCmmjboKMLB1bd20r1H6IRWd7zpSwOcYZosgLrGlBPFf5Mln7XyZwVnF0f MDsTxg+q4SvN5eX2yUmlwbfATYM9+ADh2mgKlHSsFGFw3rf4cwpRpgf4oe3RF+PPBuUc 1CcUZ/ZKyuORX0RO7ulbInzCy9OJhNMsRPjPASSSIvLSI6kSWQA8CQfJcJpczqotjZXv 58eFAmVhH5ph+svjRKPujXBAWCC7HGGeYO2TZh6YjgWm+MHAQCu9+MuozMMRYHJPWsJI pnCWdA1X88eiLsp0M/waptiTR9LZO3J7GQQnNygIDVI3H0Esq895P8qXDF4rLM5AIEBK DRdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Dk+1RcI9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si2137718ilk.127.2021.09.02.07.52.58; Thu, 02 Sep 2021 07:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Dk+1RcI9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345591AbhIBOup (ORCPT + 99 others); Thu, 2 Sep 2021 10:50:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:45178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhIBOuo (ORCPT ); Thu, 2 Sep 2021 10:50:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 66B4560FDA; Thu, 2 Sep 2021 14:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630594185; bh=74B1g330j3XFo5x7ASCrKG7fXjCkSQ81tfsxRgQUxzw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dk+1RcI9IZWuLycsGUAXMvaiX1zWc3TIBzrflsE1irzo5FSEjc40XYEvMmtUXD6ZD 7KTVJg9+PDs3ITsCcVV77WYVQs79i+HN90MNIIG+KrN3s4uTWUXPG4UhWFyu7dcYBb b75dIHkCF7xuI5uoPp97CuegYyHmELwL4ewWOjrBch3v3b8A+00KXeIcG0vdBRuk+u gJmWwumQkBbvcdnFn6LJPGc9kswNQsxabbJAovvewCpl0PHe7/uPljqUSapqamWENv bgGedZ/GjkdjDRpBgoO806YJsMKGqVp5eZrWptPZE4ndL5aEbx0guOrEJ/s4YIy3oF 9KMFJxlYTqonA== Date: Thu, 2 Sep 2021 15:49:13 +0100 From: Mark Brown To: Daniel Baluta Cc: pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, shawnguo@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peter.ujfalusi@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, s-anna@ti.com, Daniel Baluta Subject: Re: [PATCH 1/2] ASoC: SOF: imx: Add code to manage DSP related clocks Message-ID: <20210902144913.GE11164@sirena.org.uk> References: <20210902123216.787025-1-daniel.baluta@oss.nxp.com> <20210902123216.787025-2-daniel.baluta@oss.nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="84ND8YJRMFlzkrP4" Content-Disposition: inline In-Reply-To: <20210902123216.787025-2-daniel.baluta@oss.nxp.com> X-Cookie: Famous last words: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --84ND8YJRMFlzkrP4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 02, 2021 at 03:32:15PM +0300, Daniel Baluta wrote: > + for (i = 0; i < clks->num_dsp_clks; i++) { > + clks->dsp_clks[i] = devm_clk_get(sdev->dev, clks->dsp_clks_names[i]); Looks like this could benefit from the use of the clk_bulk_ APIs? --84ND8YJRMFlzkrP4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEw5GkACgkQJNaLcl1U h9D6dQf8CQ+j2eYy3OLz8n4W9uYfdEiX+7mQIfuhP8KESkfKUchq2YshYjNxgXdh 89mN6XH8LiikrIMYk+ID0VZ84f5fEKsKSLWlRTNfCU0VV9Gk9lBzGqX0wcfKHn1r pNAXj7LZD2uJmqMQmXgLcRjBLVHtLgjnrc6XZPxZElzlEzewhMta37io4I/a/Yyz wp1+BPUxv3wIWFZE4IblYZaX4lA3WnYf2gJDNx3EJCOnuR/xHIrnGrpValgiHUVG PN6hkNaXcpvru8KVEb7jQR4OFDKQ/IKFdpnXPZeXN8QLw2K6Gi35RqPYwddtQog3 rMbgSPa9NNBVUO0PeY5xBq6AjAFdeA== =PxVd -----END PGP SIGNATURE----- --84ND8YJRMFlzkrP4--