Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Nirmoy Das <nirmoy.das@amd.com>, rafael@kernel.org,
        linux-kernel@vger.kernel.org
References: <20210902102917.2233-1-nirmoy.das@amd.com>
 <YTCpuo00wM7jGSIc@kroah.com> <5ab7739d-15a4-2e84-0320-fee8d5df1e83@amd.com>
 <YTDBfO/byKzGWV8G@kroah.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <c918f1a5-7c88-bf47-14b6-b6e892695951@amd.com>
Date:   Thu, 2 Sep 2021 17:10:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YTDBfO/byKzGWV8G@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3lPc1Z1T0NuZ1JoQUMwbUxRZTNQcmxFdW1zQkUya0o1ZDM0NEFMQWlVampk?=
 =?utf-8?B?UWxzL2s2UUl4QmFHTXhwNG0veXVBVGVnajVOQSt1Q0VNdzhmL2plOGJUT0dn?=
 =?utf-8?B?VHZkdHUra1oyR2lCcC9FY0xKSy9VWElVM2JyaVAvQzl0YXdlK28rRkJVdVV2?=
 =?utf-8?B?UzkreFdwZk92WDNjQUdxR0YyeW5Ya3h2MjFxb0wyc0NBekpkR2NFd0Vvb0RO?=
 =?utf-8?B?S2RiSVBzcXpRaGlIa0dvODdTVGEyKzdxaXBjakdSYUxGN0FmNFE1amNCd083?=
 =?utf-8?B?dWpkTHFrbWNlOVpsaVFna0pUaC9VakJSYU05TVFFQWtVR2p2Vi9QNVEvZFov?=
 =?utf-8?B?Sk5Gb1JJU0ZMcDhCL0w3MzIzNzNTampWK1VoQ2dWY1lsOEtHQ0J3R0pIbklx?=
 =?utf-8?B?V0VGTG9oN3pVNVVpU212aGtUVTN3bGNPZWJDUGNENld2OFJCM2MvZ1g4ZEtl?=
 =?utf-8?B?L29VK3g3QU1SRGpFZHZRbitQd0dPRGFLbU1PZTJBMEx1N3NUYlkxVU1VenlU?=
 =?utf-8?B?czAxdVBLZEkvc2ZNQzBmZ1NMNGZMNWdwejgvOElocHI3MFUwVU8vWTFmQVp3?=
 =?utf-8?B?WHQ4RjhTdHFsUFBjWG4xNmVueXN0c0dmWFhIRnVvTUZsVlhOSHJyYnllcWc3?=
 =?utf-8?B?OU1YeTRMYVppclFYNzAxcFpnaFlOUVVralFVa3pMdmkvcW5Zc3ppKytsNWE5?=
 =?utf-8?B?SGM3NUpxaDg1UE1JSll2TUZpUTd5MmdKNEhOZDYyOE1lWTRJeVFtOXhyeDBO?=
 =?utf-8?B?UVNCcnNrc1M1cCtMVXFRV29OMnNvdkFzNVFNMUR0WGRGeXBlWjg4NHMwWU5z?=
 =?utf-8?B?dXlJU1A5M3RNZ3lZNC9Nc1RyR2FjTFdYRDdSbVMwVkJuUFNVV1hLSTBMSVlX?=
 =?utf-8?B?NEs2bVFLa0ZQNVJrdlZYVnIwUHBKQmtmTy9BUm93dkliMW1sUDM1NkR1V1d3?=
 =?utf-8?B?a2I4ek5PU2xBbzA0U3ROTnpBZm5odFFXQ1kzbFoxa2FybXdMV3JBTVZTUS9l?=
 =?utf-8?B?N2ZuNnRhVGFxRng0UHdxVDVtcXlab1o1d1QzVTdLWEE5aUFSS3dFUG8wc0RW?=
 =?utf-8?B?SG90amkwMXdUNFJYRUQ5aWFCK2xFc2h3VXhONDcyd1AvRWttUCt5aWxUN3cw?=
 =?utf-8?B?WnVXVXR5REhnRjljR3dtK0NVWFFiUGdCR1JlMHdJd3dheU80ditvdlNjWFZR?=
 =?utf-8?B?TytTVlQ3cEdrTFJIaHpaNVp3cEJmbVRCY3ZIdzFoQ2lJV0p0MnRyeGkvdWtG?=
 =?utf-8?B?OVZHcldtU3NramY4elkrakxvbjBORmcxNWRHTWNhekZXMXlUYXBLRmxBNExU?=
 =?utf-8?B?ZHBuWTFDcmN5d3RiT0F3SldNak9KY0RYNmhCeXNNRGRSMUk5enVZTFJlMTd1?=
 =?utf-8?B?MmR6SkI3dlJYUUZIT1ZmajRrSEttUDhzQVFHcXlsWGhqRDN1bFVBVUU3eDdD?=
 =?utf-8?B?NTlXN0xsdTJ3N1VoU3lxYXZjVm0zZUxCbXdBNkM5SFUrT3NRSUVUbUpWRHVn?=
 =?utf-8?B?R1NXcjJTamlnL21Ra3N2Rkt6Tk9TTVFZOWtzNXdMUVhod2NzSkJOL2FIRVVF?=
 =?utf-8?B?cVVkTFhlaUs1RitybUZ4eWkzZndyZks4Y3ZPR3NBTmpUWXZqTWFaVG1GMFpj?=
 =?utf-8?B?NzhZa1FqMHlxZEtwUUVYWEY0RkdsM3R4VlpwNDNxNTN0Q2dvMkFIVFZaa1Vn?=
 =?utf-8?B?dG1jZlNyZVltbVp6eWpocDd6NlJZQW40YXRRYWpXMTFSSWhSS21NeFBtOWM2?=
 =?utf-8?B?M0lFUDBmWTFiYU9EZE50LzA0a2dvNzQ5TE1IdjRmb2hvcmNqamdkWTlJZTYv?=
 =?utf-8?B?eGdzNVdQRHllbFhpK29FNkZ6MnFjeHFOejRsbU9LZ0VvUmltQnBOZW1tYi9h?=
 =?utf-8?Q?JbO3V/UrBc7sm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a4617b7-b063-4cdb-b6d3-08d96e23ccf9
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 15:10:29.3762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CAxyIYj5HDV7wOjAAKgXUaaO0PB9H9WlCW10dhVYxGhWJXayfv1k3/FKOL+gsPT9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4689
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 02.09.21 um 14:20 schrieb Greg KH:
> On Thu, Sep 02, 2021 at 02:03:12PM +0200, Christian König wrote:
>>
>> Am 02.09.21 um 12:38 schrieb Greg KH:
>>> On Thu, Sep 02, 2021 at 12:29:17PM +0200, Nirmoy Das wrote:
>>>> debugfs_create_file() returns encoded error so
>>>> use IS_ERR for checking return value.
>>>>
>>>> References: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1686&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Cffc1109aeb744082181b08d96e0c06db%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637661820207117289%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=6NDHX9sEhGF2jakVfUJ7Qurql6UAdNpFQZ6XvCjwz0E%3D&amp;reserved=0
>>>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>>>> ---
>>>>    fs/debugfs/inode.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
>>>> index 8129a430d789..2f117c57160d 100644
>>>> --- a/fs/debugfs/inode.c
>>>> +++ b/fs/debugfs/inode.c
>>>> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
>>>>    {
>>>>    	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>>>> -	if (de)
>>>> +	if (!IS_ERR(de))
>>>>    		d_inode(de)->i_size = file_size;
>>>>    }
>>>>    EXPORT_SYMBOL_GPL(debugfs_create_file_size);
>>>> -- 
>>>> 2.32.0
>>>>
>>> Ah, good catch, I'll queue this up after 5.15-rc1 is out, thanks!
>> Thinking more about this if I'm not completely mistaken
>> debugfs_create_file() returns -ENODEV when debugfs is disabled and NULL on
>> any other error.
> How can this function be called if debugfs is not enabled in the system
> configuration?  This _is_ the debugfs core code.

Well, that's what I meant. The original code is correct and Nirmoy's 
patch here is breaking it.

Nirmoys other patch is for a driver and there the function can indeed 
return both error code and NULL.

Thanks,
Christian.

>
> thanks,
>
> greg k-h