Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp520891pxb; Thu, 2 Sep 2021 09:10:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw4ELm3Je8JvY0eFShS1tudlXNYc7XC/XVpjnIbf6KW9PPQrdKCfZAva9NZZFYxRSCI4gC X-Received: by 2002:a05:6e02:2183:: with SMTP id j3mr2911517ila.149.1630599028421; Thu, 02 Sep 2021 09:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630599028; cv=none; d=google.com; s=arc-20160816; b=Z2Ur8VivqEQ/jwvCR8X5ClG1XyUXWm8f5f0ymdyxnKYMwquJrzxFEpqYxQ3qvo7MVR 3+EfOyuCJec2uNdSjPZ1cDagdnpytVj8J2xo2L8gDTebOEv0HUIHxOLsshEUnS19nxas QY24NOQi9H/RuhbIw7Wy9WXUTlu2vHiRnrQuNUh6G8WwQ33F+s2sh9uqAGOTMmF6sj8C 3XZuVtF9CFHG1wSKxMlikLn6U1AQdl2VIlf4rZGrwmMoR4zT1cDrvdbK/LOVnDXOkYIv r5/a8mg86uxbDm9mio/PxxeBwQtpe1ChSTmKbLogfrK7cMfrNME5khDHazm0VVytDRrM F64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=Wx+XXV0BWf1y9Lqi5g0IQIcU20sUejeRzkLBntJRGMqOku0Xba4oyT4/voKBVcGgo8 JPfU1CRpp5bcZkg5CNGQfpiAiBTfOl+apSNXhjDQbLYkBY+/KHGRD7QsR3e+YOJfd3wT K+QIW/nkExK2nUJBkyOKaCBqWKeUSm9H5T0AAp7eqADtZ1gW6DC8qIX86+zUtZPJlKvN fWsBsje/ReiF8siWyY33euxsTVQRRAk7j8Rm65mY09mqkNQC590cNIqbtywHy2eiWIVL u/oJTtzgEaPm5v0OmJoKHAcFWiSQROmes0AWyPQatuLBXPKjq/4+52kOQzA27ZEj8wq2 4Iww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lQfm8PKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si2454416ilj.94.2021.09.02.09.10.13; Thu, 02 Sep 2021 09:10:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lQfm8PKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235316AbhIBQIn (ORCPT + 99 others); Thu, 2 Sep 2021 12:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234786AbhIBQIn (ORCPT ); Thu, 2 Sep 2021 12:08:43 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5550C061757 for ; Thu, 2 Sep 2021 09:07:44 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 8so2461704pga.7 for ; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=lQfm8PKUgLZqfpgTk9CZI28oAthBMMxm9xTl2XYEBMCVut/D/XscAuELHGMabtiU7d r2FH9zrmKqXbJy4ol/w2QaFc1j7XV/o8NW4ubivUp4ALkp19LfVsupvUMlQANopLM2kw Y6zyDQRM8GOGvJO8BVMb/ni4OYK77TtzG+omQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=Vkh6I+4WiUxcogw+IZfw3mhR40iFOUNXXTR8DGU7YXcDCD9JyuSPeoGKjZBjvUbirf dtZZ1R7XFFap4QZJ+56Ekf5uyPEDDwr7sr7lVcGc+/jma6i6j3XOy4HDaCmjP7y99mHr ZvR04zrVVEXCMnz46/rNgPqr1rEYNVxlOAK0c9OF576wPyJztc4PCofgFf3yBmOnRxnu TfrsFvzM6/K8gvPZpp4DxPIS7dgkG1ytB7Ed79hILXTrylO5b+ljJNB8z8eek8Qc7IbG +ZJxPie9N7yoeqSVJnoRAeAPds1D5XbNsT2SVFdOPj2QQfbcLK2WhLI+VzAO/f69j79b 3x/w== X-Gm-Message-State: AOAM530E59jeIq4kQwYyTf82DEp5xSV3Bo1PuH5mqy7sxA4YFzGHc2gT HzinURUeX1FRqjz21jpXYVWvFg== X-Received: by 2002:a63:5413:: with SMTP id i19mr3942630pgb.297.1630598864267; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q22sm3111413pgn.67.2021.09.02.09.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:07:43 -0700 (PDT) Date: Thu, 2 Sep 2021 09:07:42 -0700 From: Kees Cook To: Keith Packard Cc: linux-kernel@vger.kernel.org, Abbott Liu , Alexander Sverdlin , Al Viro , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Arnd Bergmann , Bjorn Andersson , Florian Fainelli , Geert Uytterhoeven , Hartley Sweeten , Jens Axboe , Jian Cai , Joe Perches , Linus Walleij , linux-arm-kernel@lists.infradead.org, Maninder Singh , Manivannan Sadhasivam , Marc Zyngier , Masahiro Yamada , Mike Rapoport , Nick Desaulniers , Nick Desaulniers , Nicolas Pitre , Peter Zijlstra , Russell King , Thomas Gleixner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Valentin Schneider , Vaneet Narang , "Wolfram Sang (Renesas)" , YiFei Zhu , Keith Packard , linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Message-ID: <202109020904.976207C@keescook> References: <20210902155429.3987201-1-keithp@keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902155429.3987201-1-keithp@keithp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > Placing thread_info in the kernel stack leaves it vulnerable to stack > overflow attacks. This short series addresses that by using the > existing THREAD_INFO_IN_TASK infrastructure. Very cool! Thanks for working on this. If you want, you can refer to the KSPP bug for this too: https://github.com/KSPP/linux/issues/1 (Anyone want to do MIPS?) -Kees -- Kees Cook