Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Sep 2021 19:07:39 +0200
From:   Jean Delvare <jdelvare@suse.de>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>,
        Erwan Velu <e.velu@criteo.com>
Subject: Re: [PATCH regression fix] firmware/dmi: Move product_sku info to
 the end of the modalias
Message-ID: <20210902190739.686eb8b1@endymion>
In-Reply-To: <20210831130508.14511-1-hdegoede@redhat.com>
References: <20210831130508.14511-1-hdegoede@redhat.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Hans,

On Tue, 31 Aug 2021 15:05:08 +0200, Hans de Goede wrote:
> Commit e26f023e01ef ("firmware/dmi: Include product_sku info to modalias")
> added a new field to the modalias in the middle of the modalias, breaking
> some existing udev/hwdb matches on the whole modalias without a wildcard
> ('*') in between the pvr and rvn fields.
> 
> All modalias matches in e.g. :
> https://github.com/systemd/systemd/blob/main/hwdb.d/60-sensor.hwdb
> deliberately end in ':*' so that new fields can be added at *the end* of
> the modalias, but adding a new field in the middle like this breaks things.
> 
> Move the new sku field to the end of the modalias to fix some hwdb
> entries no longer matching.

Argh. Sorry for missing that, and thanks a lot for spotting it,
reporting it and providing a fix. I never liked the modalias format as
it makes matches clearly fragile. I really need to keep this in mind
when touching it.

Patch applied and pushed to linux-next. I'll send it to Linus for
5.14.1 quickly too.

-- 
Jean Delvare
SUSE L3 Support