Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp609095pxb; Thu, 2 Sep 2021 11:02:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3YvMwfEPCkJQe04+rmo8Coo4mWohO3g5XjgiAgrFOXg1jJ9ttOVzWQpoumsmnCqHJjTLu X-Received: by 2002:a05:6e02:194c:: with SMTP id x12mr3365154ilu.155.1630605750193; Thu, 02 Sep 2021 11:02:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630605750; cv=none; d=google.com; s=arc-20160816; b=yTG1p0hB2xR98B8K+IUwx842umcARA4eVbkHrIu1LISd/0VMwIq+pwnxOiNj5DxxM8 2aFQa2awe4mgMsTZKanshFZ1CoEdh6M9uhXWILZuh6I0GnI8uVRhCHLLHyl7cFzSfdXf nXRaIoM7EZFQ+PaWq8z4U/yomusq+47+U3xJEw4d395TVzx2Vb9EysYEm1XAVHpTIwnS PvgS/gOAfYHvJ+aX2JFS2HX78C2g4ePxHPTlN+SX+smg40IrQMvBg3VonDM31zygBArJ fRMQenx9HVXFf5SLss6XIo5tetHIFWNHRgwWMyZRod4zmur5ogc8tizao3Vi0V9TJ7Mw jKYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=I6lNmz1ZHPNmtMHcGebqNi31a0bwccl3naNODv57iB0=; b=xyVDCBxO5fyKdYN5MELbbZh2wTNmyG1ts9dYFfN4OtFw/nZJQ/Sr+5egENXhbNPUOZ YaD9Bsu0a3QD4JGvuGFDmlLphl606eUKFRavbfezYxc3UOLWOw98Q++PW4LS6lET2uM3 4ifr0BJT0HGjX886siO/miiT83wlwSeWYVa0fyrdKtJq2uJezVTqyNo3+3KV2xkOuDTR n36JcYmUS8taJpEYdZA0XjQZaK7zjcK373YpyXw01D/qZkCmV1EG+Wmjji8WW9KrOtxR Sw/EVnEltcceB7kWFDGUVfaqwvW2+79x26wox1z9yZY/b7w2RW/oSJQttMQ/i2JNcufE 4wbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hBowUWs5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si2916313ilf.63.2021.09.02.11.02.15; Thu, 02 Sep 2021 11:02:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=hBowUWs5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346867AbhIBSAV (ORCPT + 99 others); Thu, 2 Sep 2021 14:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbhIBSAU (ORCPT ); Thu, 2 Sep 2021 14:00:20 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 453C8C061575 for ; Thu, 2 Sep 2021 10:59:22 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id c11so223998ybn.5 for ; Thu, 02 Sep 2021 10:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I6lNmz1ZHPNmtMHcGebqNi31a0bwccl3naNODv57iB0=; b=hBowUWs5ABee1O6qSaIcb6Azek8v4ILJhEmiOTmf2XcZFin/3vVoktd+dfRrLP9HfS hM4m55PRK0rVzr030c/PL04yUtTQ2jPcHp1rubY12nnMKEkLVCCQtVChTYRS8k329YuF vCOt3jQI0Jb/qyYgEUCL5wPG2X1fblZWZ8LLoO+Esc5rIVSxYpUpkNiv1g8f+9+bc6HF 9BR9ErUyBkxwNWd3yIROJd2r0lPpcEsJzQKoEdsAHj4ixE4i41o/gn6LLnOuoc8I+6df xxk9yXBkTMNySknd7yExpoyAn/6oRHph3/oYLLL2+oY/ryvO+Rm9Sn6ab0AWZH7HSKa1 UhYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I6lNmz1ZHPNmtMHcGebqNi31a0bwccl3naNODv57iB0=; b=M0G2Bdy8fpMVXi5ksiU5An+M3plG7kbUUHiN1VWnsZ9IWk8sqRvGbhvuBh1XRze/R+ BElituv98FEbb6muZC15N/oz80HKxyZmsAtmLIrN3zHhjTocpCHu5hAx45lz39sPLUGB mqqx/u4/3yKZihyiFm+YOdcCSRj/CCMK7E/6epSHHZFo7ZELvokUH5ZDTxmfNv4RFHgX hOF2kwZSHzvO0qra0jbnLfwDMwADPcjT3+zbo1FhtJrjpk1Dt3ToFMMn6tnhsTll+QSK lB9u44dEObjfhCcTyczj6rdxy8RC92zwVSLHvPUHIzgMzfqU3mi8mEWr2tBC/QhO9bCN +CHg== X-Gm-Message-State: AOAM532lIWLkYJv+A4AZAu38/TXxRPPRBpdlr7JI64UyW3ERLyfgeP7P JWG9k9k9zVj+QUj4MTPzTvb707j3JnmtNseAPXv6Ow== X-Received: by 2002:a25:38ce:: with SMTP id f197mr5816802yba.254.1630605561360; Thu, 02 Sep 2021 10:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210901211412.4171835-1-rananta@google.com> <20210901211412.4171835-11-rananta@google.com> In-Reply-To: From: Raghavendra Rao Ananta Date: Thu, 2 Sep 2021 10:59:10 -0700 Message-ID: Subject: Re: [PATCH v3 10/12] KVM: arm64: selftests: Add host support for vGIC To: Ricardo Koller Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 2, 2021 at 10:28 AM Ricardo Koller wrote: > > On Wed, Sep 01, 2021 at 09:14:10PM +0000, Raghavendra Rao Ananta wrote: > > Implement a simple library to do perform vGIC-v3 > > setup from a host of view. This includes creating > > a vGIC device, setting up distributor and redistributor > > attributes, and mapping the guest physical addresses. > > > > Signed-off-by: Raghavendra Rao Ananta > > > > --- > > tools/testing/selftests/kvm/Makefile | 2 +- > > .../selftests/kvm/include/aarch64/vgic.h | 14 ++++ > > .../testing/selftests/kvm/lib/aarch64/vgic.c | 67 +++++++++++++++++++ > > 3 files changed, 82 insertions(+), 1 deletion(-) > > create mode 100644 tools/testing/selftests/kvm/include/aarch64/vgic.h > > create mode 100644 tools/testing/selftests/kvm/lib/aarch64/vgic.c > > > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > > index 5476a8ddef60..8342f65c1d96 100644 > > --- a/tools/testing/selftests/kvm/Makefile > > +++ b/tools/testing/selftests/kvm/Makefile > > @@ -35,7 +35,7 @@ endif > > > > LIBKVM = lib/assert.c lib/elf.c lib/io.c lib/kvm_util.c lib/rbtree.c lib/sparsebit.c lib/test_util.c lib/guest_modes.c lib/perf_test_util.c > > LIBKVM_x86_64 = lib/x86_64/apic.c lib/x86_64/processor.c lib/x86_64/vmx.c lib/x86_64/svm.c lib/x86_64/ucall.c lib/x86_64/handlers.S > > -LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c lib/aarch64/handlers.S lib/aarch64/spinlock.c lib/aarch64/gic.c lib/aarch64/gic_v3.c > > +LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c lib/aarch64/handlers.S lib/aarch64/spinlock.c lib/aarch64/gic.c lib/aarch64/gic_v3.c lib/aarch64/vgic.c > > LIBKVM_s390x = lib/s390x/processor.c lib/s390x/ucall.c lib/s390x/diag318_test_handler.c > > > > TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test > > diff --git a/tools/testing/selftests/kvm/include/aarch64/vgic.h b/tools/testing/selftests/kvm/include/aarch64/vgic.h > > new file mode 100644 > > index 000000000000..45bbf238147a > > --- /dev/null > > +++ b/tools/testing/selftests/kvm/include/aarch64/vgic.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * ARM Generic Interrupt Controller (GIC) host specific defines > > + */ > > + > > +#ifndef SELFTEST_KVM_VGIC_H > > +#define SELFTEST_KVM_VGIC_H > > + > > +#include > > + > > +int vgic_v3_setup(struct kvm_vm *vm, unsigned int nr_vcpus, > > + uint64_t gicd_base_gpa, uint64_t gicr_base_gpa, uint32_t slot); > > + > > +#endif /* SELFTEST_KVM_VGIC_H */ > > diff --git a/tools/testing/selftests/kvm/lib/aarch64/vgic.c b/tools/testing/selftests/kvm/lib/aarch64/vgic.c > > new file mode 100644 > > index 000000000000..a0e4b986d335 > > --- /dev/null > > +++ b/tools/testing/selftests/kvm/lib/aarch64/vgic.c > > @@ -0,0 +1,67 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * ARM Generic Interrupt Controller (GIC) v3 host support > > + */ > > + > > +#include > > +#include > > + > > +#include "kvm_util.h" > > + > > +#define VGIC_V3_GICD_SZ (SZ_64K) > > +#define VGIC_V3_GICR_SZ (2 * SZ_64K) > > + > > +#define REDIST_REGION_ATTR_ADDR(count, base, flags, index) \ > > + (((uint64_t)(count) << 52) | \ > > + ((uint64_t)((base) >> 16) << 16) | \ > > + ((uint64_t)(flags) << 12) | \ > > + index) > > + > > +static void vgic_v3_map(struct kvm_vm *vm, uint64_t addr, unsigned int size) > > +{ > > + unsigned int n_pages = DIV_ROUND_UP(size, vm_get_page_size(vm)); > > + > > + virt_map(vm, addr, addr, n_pages); > > +} > > + > > +/* > > + * vGIC-v3 default host setup > > + * > > + * Input args: > > + * vm - KVM VM > > + * nr_vcpus - Number of vCPUs for this VM > > + * gicd_base_gpa - Guest Physical Address of the Distributor region > > + * gicr_base_gpa - Guest Physical Address of the Redistributor region > > + * > > + * Output args: None > > + * > > + * Return: GIC file-descriptor or negative error code upon failure > > + * > > + * The function creates a vGIC-v3 device and maps the distributor and > > + * redistributor regions of the guest. > > + */ > > +int vgic_v3_setup(struct kvm_vm *vm, unsigned int nr_vcpus, > > + uint64_t gicd_base_gpa, uint64_t gicr_base_gpa) > > +{ > > + uint64_t redist_attr; > > + int gic_fd; > > + > > + TEST_ASSERT(nr_vcpus <= KVM_MAX_VCPUS, > > + "Invalid number of CPUs: %u\n", nr_vcpus); > > + > > + gic_fd = kvm_create_device(vm, KVM_DEV_TYPE_ARM_VGIC_V3, false); > > Nit: you can return early if gic_fd is bad. > kvm_create_device() already takes care of this and the test would simply fail if gic_fd was bad. So, I think we can positively move on :) > > + > > + kvm_device_access(gic_fd, KVM_DEV_ARM_VGIC_GRP_ADDR, > > + KVM_VGIC_V3_ADDR_TYPE_DIST, &gicd_base_gpa, true); > > + vgic_v3_map(vm, gicd_base_gpa, VGIC_V3_GICD_SZ); > > vgic_v3_map() implies that it's doing something vgic specific, when it's > just converting bytes to pages. What about something like the following? > > virt_map(vm, addr, addr, VM_BYTES_TO_PAGES(vm, VGIC_V3_GICD_SZ)); > > and you add a VM_BYTES_TO_PAGES macro to include/kvm_util.h? I think > this macro can be useful to others. > Yeah, good idea. Will do. Regards, Raghavendra > > + > > + redist_attr = REDIST_REGION_ATTR_ADDR(nr_vcpus, gicr_base_gpa, 0, 0); > > + kvm_device_access(gic_fd, KVM_DEV_ARM_VGIC_GRP_ADDR, > > + KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION, &redist_attr, true); > > + vgic_v3_map(vm, gicr_base_gpa, VGIC_V3_GICR_SZ * nr_vcpus); > > + > > + kvm_device_access(gic_fd, KVM_DEV_ARM_VGIC_GRP_CTRL, > > + KVM_DEV_ARM_VGIC_CTRL_INIT, NULL, true); > > + > > + return gic_fd; > > +} > > -- > > 2.33.0.153.gba50c8fa24-goog > >