Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp635811pxb; Thu, 2 Sep 2021 11:32:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYciKOlX5wCzJc8vTQdxHQZJ++tNybZy1VOEhB8G81M+tA9n12B2+qBeKamXQCGUwYyQyl X-Received: by 2002:a17:906:38db:: with SMTP id r27mr5376166ejd.338.1630607567079; Thu, 02 Sep 2021 11:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630607567; cv=none; d=google.com; s=arc-20160816; b=r2mTQ7AQ31ZlSf+Up3DwAhShXQMY7GFDBBClviRMPfaM3JBkx25TqvlWyWym47PgIw PiSixaqitjI+P6s9UqdvcbgLBWRxTanxws+pQawQeT3kjgxSKQc2/vsU3KNoFEEHXjOG AESw5E1Mke3Gol/V/Cw+SbKV+HADiakwEkOCkooBnxspIY47aJYSbsZPowlTpI32q6ao JfaSOL/1f7uAano/MB5Eqt9JqvPLRHnQXthZEgi/WOhsc8cqx75/wCzz/dfRJMIa9rVU 1r4189qjr76P6PvGa/+FqdcpOKlA+E0YeSAxi9eCgFiF+aZZ1b/MfyBPQgbphG/mblow Dyug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=+hjP4EHRzFGg9+KpsXC+kkJGHJ5U5pg/4hQusv3ZDl4=; b=xsh1hyLgS7G4D5n/i4iOe3S4GPF6P/8VSDuJPft8g5GkY8HgZMe/yZMiYJ4uppD5Xr mshMREqOgtFLvn3iKJVNZcxqUmFLT295CcC862eS7RYghSZvoma7GI37Tl0mCpbjfZTw Sd2GMXDLMCBPJXdRJkNWsRbUJ6yOqVV2EEVbYiDklwRkFchauQJuGhDhfyHl7lk63bbg abNq3WPGlV7SF5lI5xLhGZPqlG5iLjz8TumqDoIK1R9tZDYc63MJEPGk6E31P2Uw2ppT kOnjRw98gUjGnEuXXOYxQqTGAeQ+dfULMOzuwO2bhlvP1BJUNIXeX5cIQiTVAhgE0/b4 XSUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz41si2662617ejc.175.2021.09.02.11.32.12; Thu, 02 Sep 2021 11:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347000AbhIBS3g (ORCPT + 99 others); Thu, 2 Sep 2021 14:29:36 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:54724 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346971AbhIBS3e (ORCPT ); Thu, 2 Sep 2021 14:29:34 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 363AC72C8F8; Thu, 2 Sep 2021 21:28:33 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 274F87CF76A; Thu, 2 Sep 2021 21:28:33 +0300 (MSK) Date: Thu, 2 Sep 2021 21:28:33 +0300 From: "Dmitry V. Levin" To: Eugene Syromiatnikov , Steffen Klassert Cc: Herbert Xu , "David S. Miller" , Antony Antony , Christian Langrock , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] include/uapi/linux/xfrm.h: Fix XFRM_MSG_MAPPING ABI breakage Message-ID: <20210902182832.GB21258@altlinux.org> References: <20210901153407.GA20446@asgard.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901153407.GA20446@asgard.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2021 at 05:34:07PM +0200, Eugene Syromiatnikov wrote: > Commit 2d151d39073a ("xfrm: Add possibility to set the default to block > if we have no policy") broke ABI by changing the value of the XFRM_MSG_MAPPING > enum item. Fix it by placing XFRM_MSG_SETDEFAULT/XFRM_MSG_GETDEFAULT > to the end of the enum, right before __XFRM_MSG_MAX. > > Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy") > Signed-off-by: Eugene Syromiatnikov References: https://lore.kernel.org/netdev/20210901151402.GA2557@altlinux.org/ Reviewed-by: Dmitry V. Levin -- ldv