Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Kate Hsuan <hpa@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        Damien Le Moal <damien.lemoal@wdc.com>,
        Tor Vic <torvic9@mailbox.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] libata: Add ATA_HORKAGE_NO_NCQ_ON_AMD for Samsung
 860 and 870 SSD.
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1h7f24y6f.fsf@ca-mkp.ca.oracle.com>
References: <20210901151643.13562-1-hpa@redhat.com>
        <3e26e7a5-0d99-b993-d5ce-aa517e1bf1bb@redhat.com>
Date:   Thu, 02 Sep 2021 15:01:55 -0400
In-Reply-To: <3e26e7a5-0d99-b993-d5ce-aa517e1bf1bb@redhat.com> (Hans de
        Goede's message of "Thu, 2 Sep 2021 18:07:10 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PMNTYdB+bMMQMza2cB8DtG8Npy6/1lavy3mSH2qzm50amSlhJ6S/8yGwxRyP?=
 =?us-ascii?Q?3FZytvqJgc5ZSqYnU7TnVGNO7VQLuYVZCCHL+TL+sttIUAw3SzvN2Ga2m2jF?=
 =?us-ascii?Q?K7MCOK9NZhPZMLHlsmVCGicIVnpn1DX7Ss14HQvMQrN8a7CfhoIwViLzhDsx?=
 =?us-ascii?Q?CY/h4/NbemMDJAFD9MkZqRiEhEJw5bXch//Gf+Hl7NOFcipQ6WM/bPuPJ3pt?=
 =?us-ascii?Q?yhLh0miEYVPsa5i9vjOcCs2Cn+Xt3vQpkYhu2UtT7nM2fpCmUnX35XE8pPlJ?=
 =?us-ascii?Q?LnRzJ9oDrK7phlXFHzkNKs9TrWU70+7B/ZssGrFGixHckIpjfKIOtyTUNn49?=
 =?us-ascii?Q?Gb9dmMk600Rn9PjySHzfGkTDCZahHwORXhS1n3qk3SprMYXurQ/YeREumutf?=
 =?us-ascii?Q?rR2lARDbOcrJ9il35lFK75AQHTQf2PYvrgziCFM+QOWdVmwVuboM5jKv5CXh?=
 =?us-ascii?Q?obJYk+YjS+kTvNOURlMRsu4qJMw26Lh4p5akxccw9kbXsL38Wji+xnuy8FUV?=
 =?us-ascii?Q?UOVdkA3qwwsBz3tvljh0dnAzL8B6eyr7sd6p+y4rOTDm2nk57Qn9HJGLELsh?=
 =?us-ascii?Q?G9HapD9UAzKFDUqHVVX3wWzAT8/QbjwxyFuX6FdKpRHSzDILTUcartuix5Sk?=
 =?us-ascii?Q?G2KvDbnY2BezRCOyHrfFT2LFDsnxX1ki+b+OrI7z1SBiPQm7riBOY24otMnY?=
 =?us-ascii?Q?7a4jHRkmZl3BZRZEI9LBlBsLrXVltkKE/uak6n44et+YuN7CglrWLAL4oEVZ?=
 =?us-ascii?Q?wDEtzwxv4fcg1SRPneGHw6lPQiRLTPOz55D++dhxX05O2nmUeNq6Mdr5B8uG?=
 =?us-ascii?Q?V7F7BrrTOwGVwAoBorNmWEgM03d5AsPwOA/cD+mShn5rd2FMobH6bQ04ujQM?=
 =?us-ascii?Q?Fkq4HfchKU2T32L6RzPQ/E37KMipXBg8NTFJzEgB+RfHQqN+Pt1t1rfJc3Gv?=
 =?us-ascii?Q?VNUQhn/t4sWbHzr+VFB7YrbVmoBJPPtidho6Lse+fgCLjEraLwmd0VRM/zVc?=
 =?us-ascii?Q?UrXFY/LRQpd2PvKKvHVcqXlvv96CQcq4qmUoEOrP4A/fWBcFWvB6foc7cMXQ?=
 =?us-ascii?Q?1BcRs2Lsl28IxbVpy1CmTXRD54mHNHovosHvNj994PPn2LvdqIN/wUw8tk7X?=
 =?us-ascii?Q?ZfOA+BjMuhD7t7y95lWM1SkkckrhIe6yJebshpsj56vQY3aYvKWMEaIBgH4v?=
 =?us-ascii?Q?lfgXqfTZtEbXHmH1xXpY8bPAusU14Q6SyW/4Ecn3toX+mSGbqF4ziEWu2v/n?=
 =?us-ascii?Q?5zNi0VnE6JmjMnzYY3gt0PX3msh8A4XICyHP3m2Spl+zXr7AFP7Yt951b4Wb?=
 =?us-ascii?Q?DeB6YQLCKAlUehBjfm1LvOza?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3a16c01-ded0-4d1c-68a0-08d96e442424
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 19:01:59.3828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZNE1TOx4YizobCqkv25/pNndTFdphaPlitQp2fSYEU9TvWSRYUR0jRyG5xMemh7K5OZ2RliK3mv3tT67fp6ScTkgwQX42ecfJ80Fg8AYDdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4662
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10095 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0
 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000
 definitions=main-2109020107
X-Proofpoint-GUID: rGhBavdvrvL1H-sojpSuiPaAK8EmNV71
X-Proofpoint-ORIG-GUID: rGhBavdvrvL1H-sojpSuiPaAK8EmNV71
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hans,

> So it looks like we actually need to disable NCQ for Samsung 860/870
> devices when the SATA controller has a vendor-id of PCI_VENDOR_ID_ATI
> rather then AMD.

That's another great data point!

I wonder if there actually is a Samsung problem (given that these drives
work fine on other controllers). Or if it is just the queued trim
handling that's broken on 1002:4391 controllers from ATI.

When I originally experimented with queued trim I had systems I could
not get to work. But queued trim worked fine when the same drives were
connected to more modern chipsets (note that this was "did not work at
all" as opposed to "randomly corrupting data").

Do we have any evidence at all of queued trim working with non-Samsung
drives on these controllers? Not sure how many modern SATA drives
actually implement this feature. Maybe the reason we see Samsung drives
in the bug reports is due to a combination of popularity and the fact
that these drives actually implement queued trim support.

> So lets wait a bit for some more info to become available and then
> I think we need a v6 with s/AMD/ATI/ (everywhere, also in the name
> of the horkage-flag, the cmdline options, etc.).

Sounds good!

-- 
Martin K. Petersen	Oracle Linux Engineering