Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp698409pxb; Thu, 2 Sep 2021 12:56:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0t9zBAQVjp3SRnyxdPd6EdKHz0mkR6yVseXjTRgX854yoWI358D6WDQjHT2Hgtjz9wwKj X-Received: by 2002:a05:6402:c90:: with SMTP id cm16mr61838edb.170.1630612581712; Thu, 02 Sep 2021 12:56:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630612581; cv=none; d=google.com; s=arc-20160816; b=UZFe1rZ4Py98lAVvFV2uSXXXKfv1nOeChadvymHsuVSLx1txhVlo0zPQOrC1Z0ouhU APFBTIcCUxqFM4tKr3/I0jw4meMnZH9YUqfuPcAwFklRQ735xZ/xsqhTm3svlchaqg3k /543y5LKrx+68ZvQvijYEwqKLzOegBwf1c5EW47T1859i1/a4ij/4ttL9GSju+rHMt8V g5GvkHqUhio3Fez+TdA6AuLqjpLizBkmCljLjldXwYRYRU4v2lQ3xZnrLj9lZl3KpHI5 VTYkrX7e5spaJOgqQGAd/t+uuQ3bLXFiOnQ2xJLX0KN3XRYlo9NQG4j3Gvoc/0OmujTt Jydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:reply-to:references:cc:to:subject:dkim-signature; bh=NWtmAeibGTgb62NMTC5SlrYX2XTfRcr5iYl1k6gZU4I=; b=ngocKf+1rqZc+uL48JQMbBsozXzpj7zVAanC906KhIohOzetUYJ3Fgz5hrX+EWnKan 645WP+ZtdQaF5P4C42Z7jEKS9HofGj5boG7f5tiu6dYTEzZD+lcQFEVahMUidS/izAFR 5rphYmdJEkabDC2JiaPYeCaVYaGH7N8KH745vMmRH3g/TJtEsjojVxOyMPSy7id5bU+f 7w5nQoqw6S6rGKqkGYtx/E7ztm7RsE5zNeoHsGMl69BylgleFAVk6KkHIwoei64QfRfx b61FgZ3GmhCzarXTd8MrqTuG8tzQAIXoFrmh8G5EWN8vsySMzra6icywbXMm2phAfYFg 2rIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=S7x23e5Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si2789923edc.485.2021.09.02.12.55.54; Thu, 02 Sep 2021 12:56:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=S7x23e5Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233756AbhIBKze (ORCPT + 99 others); Thu, 2 Sep 2021 06:55:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242730AbhIBKzc (ORCPT ); Thu, 2 Sep 2021 06:55:32 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E480C061757; Thu, 2 Sep 2021 03:54:28 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B4A0645E; Thu, 2 Sep 2021 12:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630580066; bh=lCdeDpUD1dQO0LCEAhNuQFiGzSwF87Eu3scwphNrJcw=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=S7x23e5QYy9HOPrHStEBkEhXNtTCf5jYOV49yggoqZawguZVuYF7pQWreOlFXYBu8 dS0iqnVY6d4YqG2V753PYnPtUvwcW4iW+YCrc5mRNuOOxctozl9rhd7uphkclSMIl/ hioOcw5y29lUqU1MyowewXqC5sGvJ14T7bapzQIM= Subject: Re: [PATCH] media: rcar_jpu: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Mikhail Ulyanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Renesas References: <20210901055532.7429-1-caihuoqing@baidu.com> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Thu, 2 Sep 2021 11:54:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901055532.7429-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc linux-renesas-soc On 01/09/2021 06:55, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar_jpu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c > index f57158bf2b11..56bb464629ed 100644 > --- a/drivers/media/platform/rcar_jpu.c > +++ b/drivers/media/platform/rcar_jpu.c > @@ -1590,7 +1590,6 @@ MODULE_DEVICE_TABLE(of, jpu_dt_ids); > static int jpu_probe(struct platform_device *pdev) > { > struct jpu *jpu; > - struct resource *res; > int ret; > unsigned int i; > > @@ -1603,8 +1602,7 @@ static int jpu_probe(struct platform_device *pdev) > jpu->dev = &pdev->dev; > > /* memory-mapped registers */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - jpu->regs = devm_ioremap_resource(&pdev->dev, res); > + jpu->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(jpu->regs)) > return PTR_ERR(jpu->regs); > >