Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 02 Sep 2021 10:00:03 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Leo Yan <leo.yan@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     James Clark <james.clark@arm.com>, mathieu.poirier@linaro.org,
        coresight@lists.linaro.org, linux-perf-users@vger.kernel.org,
        mike.leach@linaro.org, suzuki.poulose@arm.com,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2=5D_perf_build=3A_Report_fa?= =?US-ASCII?Q?ilure_for_testing_feature_libopencsd?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20210902124529.GH303522@leoy-ThinkPad-X240s>
References: <20210902081800.550016-1-leo.yan@linaro.org> <YTDB/VuANx5c+5sk@kernel.org> <20210902124529.GH303522@leoy-ThinkPad-X240s>
Message-ID: <BBAFF70C-3E2B-4AFC-8229-857ED5BA15CC@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On September 2, 2021 9:45:29 AM GMT-03:00, Leo Yan <leo=2Eyan@linaro=2Eorg=
> wrote:
>On Thu, Sep 02, 2021 at 09:22:21AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Sep 02, 2021 at 04:18:00PM +0800, Leo Yan escreveu:
>> > When build perf tool with passing option 'CORESIGHT=3D1' explicitly, =
if
>> > the feature test fails for library libopencsd, the build doesn't
>> > complain the feature failure and continue to build the tool with
>> > disabling the CoreSight feature insteadly=2E
>> >=20
>> > This patch changes the building behaviour, when build perf tool with =
the
>> > option 'CORESIGHT=3D1' and detect the failure for testing feature
>> > libopencsd, the build process will be aborted and it shows the compla=
int
>> > info=2E
>>=20
>> Thanks, added some committer notes to show that it now works:
>>=20
>> commit 8fb36b1f54873870262810d3db10526559e1d6c2
>> Author: Leo Yan <leo=2Eyan@linaro=2Eorg>
>> Date:   Thu Sep 2 16:18:00 2021 +0800
>>=20
>>     perf build: Report failure for testing feature libopencsd
>>    =20
>>     When build perf tool with passing option 'CORESIGHT=3D1' explicitly=
, if
>>     the feature test fails for library libopencsd, the build doesn't
>>     complain the feature failure and continue to build the tool with
>>     disabling the CoreSight feature insteadly=2E
>>    =20
>>     This patch changes the building behaviour, when build perf tool wit=
h the
>>     option 'CORESIGHT=3D1' and detect the failure for testing feature
>>     libopencsd, the build process will be aborted and it shows the comp=
laint
>>     info=2E
>>    =20
>>     Committer testing:
>>    =20
>>     First make sure there is no opencsd library installed:
>>    =20
>>       $ rpm -qa | grep -i csd
>>       $ sudo rm -rf `find /usr/local -name "*csd*"`
>>       $ find /usr/local -name "*csd*"
>>       $
>>    =20
>>     Then cleanup the perf build output directory:
>>    =20
>>       $ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ;
>>       $
>>    =20
>>     And try to build explicitely asking for coresight:
>>    =20
>>       $ make O=3D/tmp/build/perf CORESIGHT=3D1 O=3D/tmp/build/perf -C t=
ools/perf install-bin
>
>The build command contains duplicate 'O=3D/tmp/build/perf'=2E

Oops, I'll fix it, thanks=2E

- Arnaldo