Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <df073c9f719a7da37a68148ea51aa28d06a14e40.camel@kernel.org>
Subject: Re: [PATCH] tracing: synth events: increase max fields count
From:   Tom Zanussi <zanussi@kernel.org>
To:     Artem Bityutskiy <dedekind1@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org
Date:   Thu, 02 Sep 2021 15:54:34 -0500
In-Reply-To: <20210901135513.3087062-1-dedekind1@gmail.com>
References: <20210901135513.3087062-1-dedekind1@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Artem,

On Wed, 2021-09-01 at 16:55 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Sometimes it is useful to construct larger synthetic trace events.
> Increase
> 'SYNTH_FIELDS_MAX' (maximum number of fields in a synthetic event)
> from 32 to
> 64.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
>  kernel/trace/trace_synth.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_synth.h b/kernel/trace/trace_synth.h
> index 4007fe95cf42..b29595fe3ac5 100644
> --- a/kernel/trace/trace_synth.h
> +++ b/kernel/trace/trace_synth.h
> @@ -5,7 +5,7 @@
>  #include "trace_dynevent.h"
>  
>  #define SYNTH_SYSTEM		"synthetic"
> -#define SYNTH_FIELDS_MAX	32
> +#define SYNTH_FIELDS_MAX	64
>  
>  #define STR_VAR_LEN_MAX		MAX_FILTER_STR_VAL /* must be
> multiple of sizeof(u64) */
>  

This looks fine, but it does also bloat the arrays that use it as a
size.  There's only one that I'd be worried about, the per-elt
hist_elt_data[] array, but I'll send a patch shortly that gets rid of
that limitation.

Acked-by: Tom Zanussi <zanussi@kernel.org>

Thanks!

Tom