Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp825389pxb; Thu, 2 Sep 2021 16:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+DK40BHV1qbpKMf3tDZj8eNEfQOJxNzC/X5MmkyMHCFrijAwobU5VDtOqu5C+aqgE2VN6 X-Received: by 2002:a02:cf05:: with SMTP id q5mr210293jar.132.1630625157063; Thu, 02 Sep 2021 16:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630625157; cv=none; d=google.com; s=arc-20160816; b=Y8PlaDD6k61i1DYUF9FjZKjDoOnyqFzSTRbIchhyrHlSHOBEf6OBnKGXd7dbfR5po0 UF/4PG9iTSGWLbSMrEuURen0/x5pPx9Ji1cCs4N1jG+fnaUxogqmT+BVq5EBHna5wVeG X5cqTGFiyAbr1fpLXEk+cGu7P9mSGdjIv27xnp6TM7wWBNQtILAaSJd80rU7wWftvkhD hGDtEEYfCaHxSBtI3ikRSd3s1zKEzIJxkumJwive7MrN0+oeVKyp62x+uPIO0qViXTUu AyOzGXiIyjo8TJ+Tke5tPhLVYPLBSlNOagu6EwWjVK1wVJ9+hxyHehi1dmOy7ZSwG0NY onNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6z4BXTiPqdD14yfJDA6ekuCmyiyWokE7eOzJwM6XTJY=; b=zz7WLaWN/P9xC445QzHL6kosotgs76Hwu7Y2eY2/6OfQ+sqExRc9LoFvLc3KLo7vza 7ZiEDFHRViJwdh20IB++fAN6rZcuxHf1KIFH6AaUWtIWqUN9FOfip8fYYKh+tRPawbbq IRWOG5dzqHnWw1xEVaULpUfOXMKO9/RS+L+SgXwqUQ0hZqcCL+njvxpYPhyx+bG20WHm 3fUxDNrWffTEpwkse8aA3OmCXJv1B+LEJPKkp236rA4d/HDvBzPyzXv3oMuclkeSED6q An30RQcGxzyw23+o3XUV5RlrVikzIpfoDOH1GaAt0CjwlwjI1G0pr873kMBBbvj/uWz0 uVfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oDOYYkTy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si3202088jac.2.2021.09.02.16.25.45; Thu, 02 Sep 2021 16:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oDOYYkTy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238297AbhIBOpc (ORCPT + 99 others); Thu, 2 Sep 2021 10:45:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:44248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345374AbhIBOpZ (ORCPT ); Thu, 2 Sep 2021 10:45:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CB33610CC; Thu, 2 Sep 2021 14:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630593866; bh=QSkZv2N1yXVzhucXRsxaUE7H3wr+r7TSYHXNxXgC910=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oDOYYkTybQvl1z6Luah3ixvfoCcvxrLI1lfGneZBWECIuC7las8tHY4sx9jFAowup mtthFD4gHpW2p17sYrm7Mgh85X7CvTV5On0a1IRI0cvEcJzmLbz7pvkvXoeAWswxyN gLaJLeqUgQ7jJqx3ynHZEPF46lNi27sb31qr1nVxWHR2xRApLthfDAGhYYTlgVaHNB maEoFyoOpTZfV7rpXhEPr77U+Q2vRZfu5GsC10TzD8Tvh6rKqlxzJ9Uacomw+ZmuWN UfQpwJeKIZb4wX6C9HQN7WrqESL+pG6RY7QBb2q4bMSbonZF6O6JJnqgzOosm9DMwq 7PhKumonfatXQ== Date: Thu, 2 Sep 2021 15:43:54 +0100 From: Mark Brown To: Alejandro Tafalla Cc: Andy Shevchenko , Liam Girdwood , "alsa-devel@alsa-project.org" , Rob Herring , Jaroslav Kysela , Takashi Iwai , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c Message-ID: <20210902144354.GD11164@sirena.org.uk> References: <20210829170019.384632-1-atafalla@dnyon.com> <20210829170019.384632-2-atafalla@dnyon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NtwzykIc2mflq5ck" Content-Disposition: inline In-Reply-To: X-Cookie: Famous last words: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NtwzykIc2mflq5ck Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 30, 2021 at 12:13:41AM +0200, Alejandro Tafalla wrote: > On Sun, Aug 29, 2021 at 11:22:35PM +0300, Andy Shevchenko wrote: > > > + struct gpio_desc *reset_gpio; > > Why? Are you using it outside of ->probe()? > No, I'll delete it and use a local variable. It can be good to reassert reset when unloading the driver in order to ensure that the device isn't active. It doesn't really matter though. --NtwzykIc2mflq5ck Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEw4yoACgkQJNaLcl1U h9DWrAgAg56iA1Au+XNyIyNCXB0VXn2oIgAwnxeXEjv3PKrw4YE0fW7dcbvywDnr 8Fs2PMIw09wFpzzoSzAQCNGN8Ts3OeiL8QFHnsOQeeyIzSkuOviiBrOWDtuCfx/j 0XXcxoH4ODxf0faKlbCGHQ6LdBgvsSeQiU3ExLjqJHYusxXbXUdRJ8XxIyhDC5tI +7KZOK7azIuJxSJrfYJ9aIlHvMmkCS9o/OpynCwkrwZwAh47+XyNSR6mn3pgiEoS Q8+WJChvT1kQ/XdYHo4GigjZIVXF0hUeA0GJJUoIdbJKl7O+8YLlOH0MDh8i0isX iTLYJ+8bqv+F8ONYPxTXcdlw4pcYdQ== =IJLZ -----END PGP SIGNATURE----- --NtwzykIc2mflq5ck--