Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <26c12f13870a2276f41aebfea6e467d576f70860.camel@HansenPartnership.com>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge
 window
From:   James Bottomley <James.Bottomley@HansenPartnership.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>
Date:   Thu, 02 Sep 2021 16:23:43 -0700
In-Reply-To: <CAHk-=wi99u+xj93-pLG0Na7SZmjvWg6n60Pq9Wt9PgO6=exdUA@mail.gmail.com>
References: <fc14fbbf0d7c27b7356bc6271ba2a5599d46af58.camel@HansenPartnership.com>
         <CAHk-=wi99u+xj93-pLG0Na7SZmjvWg6n60Pq9Wt9PgO6=exdUA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-09-02 at 15:38 -0700, Linus Torvalds wrote:
> On Thu, Sep 2, 2021 at 9:50 AM James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > We also picked up a non trivial conflict with the already upstream
> > block tree in st.c
> 
> Hmm. Resolving that conflict, I just reacted to how the st.c code
> passes in a NULL gendisk to scsi_ioctl() and then on to
> blk_execute_rq().
> 
> Just checking that was fine, and I notice how *many* places do that.
> 
> Should the blk_execute_rq() function even take that "struct gendisk
> *bd_disk" argument at all?
> 
> Maybe the right thing to do would be for the people who care to just
> set rq->rq_disk before starting the request..
> 
> But I guess it's traditional, and nobody cares.

It's certainly traditional, but Christoph has been caring a lot about
cleaning up our gendisks recently, so he might be interested in seeing
if he can fix it ...

James