Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] scsi: iscsi: Adjuest iface sysfs attr detection
To:     Baokun Li <libaokun1@huawei.com>, cleech@redhat.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
CC:     patchwork@huawei.com, yukuai3@huawei.com
References: <20210901085336.2264295-1-libaokun1@huawei.com>
From:   Lee Duncan <lduncan@suse.com>
Message-ID: <91d4e2a7-0a10-ef7b-37b1-3ef884a3c3c0@suse.com>
Date:   Thu, 2 Sep 2021 16:58:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20210901085336.2264295-1-libaokun1@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.20.3] (73.25.22.216) by PR3P193CA0048.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21 via Frontend Transport; Thu, 2 Sep 2021 23:58:07 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc414b07-334d-4da8-cce7-08d96e6d8412
X-MS-TrafficTypeDiagnostic: AM6PR04MB4375:
X-Microsoft-Antispam-PRVS: <AM6PR04MB437535007873A1129B584E10DACE9@AM6PR04MB4375.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yfud2sEam3forLd6vRTrTyjc+LfodoFCJSWTlHN6LKITdHmOTCZmCLuE88fteGz+UxA8tWxWuB62JrCjqoJlkfdELWA+stvqwvuhr9s2vKM75f8FHJsNJiqnXqiadxNz2SVd7mkyL7uagu0hIGoFv52jowoQlB3udB1Ku85FwqTLTff1YHosvt23t1ai78ylGT4IlMxufvMK7UfZ85u+6Mq422QUIOknVBU0wnQ1akpYhaps2uDs3+4beeiwUkv2aBcAmQLbb+HfslKoS7sZkkx1nTPfu+mMqzF87TJSIoZiJvnImaHTwBTtxF1SQwKJVbF8dwR1XRj333Gin1uK0s+r3VUQXZGQgnzoO/5tbqkDUL1c02dn3m/2syomL7zQACHz1gQ/0px8Hyspl7KY5gMGcRSywL+GMQ8JsF3UeAJNTJkXIBT2xP07byji2ZUTtsjB3A2WKMt9SST0epRK73rdIJ5kVGV65rDFPCrgb5Uzo1qhnJwyUaTLh8LvsH02z5eVRMl+b5Xl5QJWiRbH9fa8hB5VeyL/hYUlp2w/FHBYYgiObn6ZFiw70shszt3fQpZkdHVH470CTRmDqaG2KBQqVa3u40MD1/cGTcxn8LLZ6vixLJaVq9ur8sxFyDu7Z0nFFX4WdR1Ubdnqlp10DLAaBLTvyeyRbcDuTd9pt/1xAPdEWNHhiFFszuIH+8Qvsw/s7tF/lcoea98FElHcg0kNXfjsJgULPaUmbCcxZS8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR04MB3089.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(346002)(136003)(39850400004)(376002)(66476007)(66556008)(8936002)(38100700002)(83380400001)(66946007)(26005)(186003)(316002)(16576012)(36756003)(53546011)(2906002)(4326008)(478600001)(6666004)(956004)(2616005)(86362001)(6486002)(31686004)(31696002)(5660300002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dKqY2sSw+VxnoL+OIAOv0aZVSoGAtZYmH2zgW2k5HL9Z3HJjaYtlUZz16bnZ?=
 =?us-ascii?Q?geAlwI2qwH6sBUcmCklXCH4hsO1VOSlJXkAuZY1C9is6HZvsAAkHVTOXrwVt?=
 =?us-ascii?Q?zoQ4eWlrsw5wHnHLgZZsaGX67m2SKIxPdxy5oIzd81ge8hA8dF7e2TMhFNwj?=
 =?us-ascii?Q?TRc19ariDiKDp4mQoWze8JHBvJqlijnXTC2/gO9JaEUuSPmoDmAp6KvQ5W6i?=
 =?us-ascii?Q?OIlZYP7Fkv0fB2rpN8GdbsjhRWCzHQQSRX+Rq8BCtFH48H6wqgZ2tdoNXQzO?=
 =?us-ascii?Q?nWZCahoAZSNAhqI9OUvnGLY7xNVPxipqaHKbpsylh2Qf+HJQvovbP1wa0bfQ?=
 =?us-ascii?Q?VzaPqRm+7NyqnHrY6hKQf6bAXAImdBrUUrJIsxCBIMSM8s87gpvjbAbqCsGf?=
 =?us-ascii?Q?uf4Npqyjfg7IssS2CCvTgzQ0uYo7FDf3y9LSsgFUyyxg43XG3LUnmdBi9JLL?=
 =?us-ascii?Q?8aBNrQ/p12c8ktlt3BxhEMPAigH9dhLEDS4Ax733n/N0ZW72uU4i29Kv6yFp?=
 =?us-ascii?Q?78vys8OBQXIgQqXJmp7I9OlewOmPUhfoAbJe1DzShapzRyi3HON5ro4Dbj+S?=
 =?us-ascii?Q?46ArMHYZcHKm99KZX+YGc7oHXWq9nO184f0RncBFPqVD93RPxFJbvOJDDECp?=
 =?us-ascii?Q?+YOhkfz2eiiSUFslUMWqCt0MY04j2dV5KlwI7q5aMl5hgUGDYvi7OA1vPwEW?=
 =?us-ascii?Q?RFfhZAyfJDDrtM4vaJ56Ubx8mhw08Z/WRy6X4l5jkCKUz6okqQj2cmwcCvLk?=
 =?us-ascii?Q?Mo3zJdZQS5oyfR+uN+4gn8nPK+XMRCsuRdaHhQ/H/YuNsd+ytmelVx0U46JG?=
 =?us-ascii?Q?Txb7AurppMVbVdELsFEVoRzeucujMaQMRltXTWTChKduEbb+7nBJn6rutvE5?=
 =?us-ascii?Q?2dogPMGX32leXxN9OtT9K/mcLEvkpAltNv9HCWb/m75RJfaJQxEqUm0L3CVa?=
 =?us-ascii?Q?Edg9sNx3S8jiXMAMZCxqulnz480kVppSWD5QChGImDHtTtexnqeu3TGXiE9c?=
 =?us-ascii?Q?lWdxmEs2RQ9f7HuxLdMik2n+9CoDdNp7b0qaLir+bfJYXG3/kdfbGXNnnXXX?=
 =?us-ascii?Q?i1QR6/WAaa7SDqrXIzvL+2rFB6Cst6S2O0wxq6XSRxMaT+eB4xHyTFjM1baq?=
 =?us-ascii?Q?Ux+NM5eyJeJNM1ifvymHA0z3fGLpB/5d1oaa5aQyfXlJIvEWsA2hJEhFBgQD?=
 =?us-ascii?Q?TI4SxuCXRwuvUdVbCMuoosL9vtdudRe9TlPuXJ4V38cW5fhWMG+qTJ1AK9vY?=
 =?us-ascii?Q?vr5RV6BZ7gxO255lPAVLy57nmeO1MqAt1Ey3Da8pmsuS0RpYYZDn5RCcLekW?=
 =?us-ascii?Q?OTNUu8Fz/NKOQ9nCXUsYg6iA?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc414b07-334d-4da8-cce7-08d96e6d8412
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 23:58:09.8019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +cnhihunOPXn/n+P71MXDzwAGHzwbBrg3fL8JfsnjzAMBIUEooX9cbS7VUrqtvMfy2wZiSciyGNT+IxCF3Nwdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4375
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/1/21 1:53 AM, Baokun Li wrote:
> ISCSI_NET_PARAM_IFACE_ENABLE belongs to enum iscsi_net_param instead of
> iscsi_iface_param=EF=BC=8Cso move it to ISCSI_NET_PARAM. Otherwise, when =
we call
> into the driver we might not match and return that we don't want attr
> visible in sysfs. Found in code review.
>=20
> Fixes: e746f3451ec7 ("scsi: iscsi: Fix iface sysfs attr detection")
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_tran=
sport_iscsi.c
> index d8b05d8b5470..58027207f08d 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -441,9 +441,7 @@ static umode_t iscsi_iface_attr_is_visible(struct kob=
ject *kobj,
>  	struct iscsi_transport *t =3D iface->transport;
>  	int param =3D -1;
> =20
> -	if (attr =3D=3D &dev_attr_iface_enabled.attr)
> -		param =3D ISCSI_NET_PARAM_IFACE_ENABLE;
> -	else if (attr =3D=3D &dev_attr_iface_def_taskmgmt_tmo.attr)
> +	if (attr =3D=3D &dev_attr_iface_def_taskmgmt_tmo.attr)
>  		param =3D ISCSI_IFACE_PARAM_DEF_TASKMGMT_TMO;
>  	else if (attr =3D=3D &dev_attr_iface_header_digest.attr)
>  		param =3D ISCSI_IFACE_PARAM_HDRDGST_EN;
> @@ -483,7 +481,9 @@ static umode_t iscsi_iface_attr_is_visible(struct kob=
ject *kobj,
>  	if (param !=3D -1)
>  		return t->attr_is_visible(ISCSI_IFACE_PARAM, param);
> =20
> -	if (attr =3D=3D &dev_attr_iface_vlan_id.attr)
> +	if (attr =3D=3D &dev_attr_iface_enabled.attr)
> +		param =3D ISCSI_NET_PARAM_IFACE_ENABLE;
> +	else if (attr =3D=3D &dev_attr_iface_vlan_id.attr)
>  		param =3D ISCSI_NET_PARAM_VLAN_ID;
>  	else if (attr =3D=3D &dev_attr_iface_vlan_priority.attr)
>  		param =3D ISCSI_NET_PARAM_VLAN_PRIORITY;
>=20

Reviewed-by: Lee Duncan <lduncan@suse.com>