Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
CC:     bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Ziljstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Topic: [PATCH v5 bpf-next 2/3] bpf: introduce helper
 bpf_get_branch_snapshot
Thread-Index: AQHXoBucwnw6xFDotUqgbr6c5GY6BquRWm8AgAAC64A=
Date:   Thu, 2 Sep 2021 23:03:47 +0000
Message-ID: <F7A1D3BF-357A-46FB-92EA-938DB99D8193@fb.com>
References: <20210902165706.2812867-1-songliubraving@fb.com>
 <20210902165706.2812867-3-songliubraving@fb.com>
 <CAEf4BzZLSs3ejyVLPMORd_GPCYNE8Jz4M6=4wxzR576Vag-+-A@mail.gmail.com>
In-Reply-To: <CAEf4BzZLSs3ejyVLPMORd_GPCYNE8Jz4M6=4wxzR576Vag-+-A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7024EeqxdR8Zxh6OSyWSZtPgVrgatYbkgU0ix8b2gjDDa0rc2fTaZQRV1O+S?=
 =?us-ascii?Q?TW9fY696fkz15+c9ENHrJkwY6E2dxnhqxZkQ53IHq5hW5A8OBrbSRspGYe18?=
 =?us-ascii?Q?Ij2V0/H846+KioAHZnakZoM4XkWuMjCS7zmwVAh3tH/YVd75/eC/hIEpgwr3?=
 =?us-ascii?Q?HCicUuWZvzl9fpj08WMyLMg3PSfXADARtpI7k3+I3lO27XH6ArcKbR3X2ZUP?=
 =?us-ascii?Q?lpCx5fxQe+xLY70/QwcboljWF7otZcUmAvDMfhABPVuVHwoia922vKuVcef9?=
 =?us-ascii?Q?e6Mv7lNidTLQjt5QvdslCW5KUxZX9uAPJ5n5hfqINMa3LAIx1KVkOugkdueU?=
 =?us-ascii?Q?jFwFb3VPV/Szn0mQNdQYyoRs+gOBhi2rzIlJt7KksWPze+JHWeSNR7stiGsK?=
 =?us-ascii?Q?o1hgYH68VWmfU/gG9izhRPK31QQJtjSJh0TvM/XZTjrvHMGbXIwlE0M+8ybS?=
 =?us-ascii?Q?kw6TtEY2MKKEFKp6SXamEGyMPBQxB5caw11MaQKDrT/C9PuBm6rf2T1gcPpn?=
 =?us-ascii?Q?BN4RXRscvEGzU4JyHOFvWRZwEzZubwXkVcA9gyRgxgPUXi74TmtjsjQKaDVr?=
 =?us-ascii?Q?BiylW2HWLHSaXPBRTkkmBPDecEQf3qIu0J1hCEHfa39vnSHoT53wqzwNkyen?=
 =?us-ascii?Q?V3H9TpTEft4FZ2jkzVTU+5Lgyk6V4kd5LdMOtg7VgDpSM+ItrT1jVunkYC8S?=
 =?us-ascii?Q?H6XczbaIeYfVirpsec2Fv0Dc9qtvZgvjeSpv4WtJ7OwtauzV6uvNJM0d7oxu?=
 =?us-ascii?Q?y9A3DS86W5dv8YeCJxANp5d7oQXYEas+76bbn90W12Sehxm1J/9mnv0JjIyX?=
 =?us-ascii?Q?G5428UGf4BXauNEMlCyYPpMF3MhCIrY0Dfkqv7VG8tJiVCCzDyFLpv9G4c1S?=
 =?us-ascii?Q?nB+zJsUPXO355AG3FiksDAiOlbqHOfmz2hNZgA0SUXjVfSgbgMLvUzq5kJ8k?=
 =?us-ascii?Q?+gSq2Qtu113QWiFLSR7gmrpstCNdz07k4bvt0Rr79TC7epqNfZAfLNf/4ObF?=
 =?us-ascii?Q?WNaBpVqzvpwQ6FgYSL67H0ps3ZCIJKzscn32Wvj7KzkLUAgwGD6T0/a6JeOZ?=
 =?us-ascii?Q?VwaS/CYKFYhUWUzbc/BaT2rtdD22/o8AwUri+fJ4Mi8c7d4XvUwWWqp3wZQX?=
 =?us-ascii?Q?SveBSt3s7ga6CH5xuFHLigmXA8buGyukRLxYVPMOUCkX1st8OocW8t+N1pqV?=
 =?us-ascii?Q?l1ccDs4weMPMz14iA3TVfpNiA5mEBI28LeeHSX0KoKvYQ7yJVk3y033EJYbc?=
 =?us-ascii?Q?5AeHxVKvwolMEk/CSbTyrvgSXEdQlfpu+ubrvi2LhB600XBxLDHUgIIbuJQj?=
 =?us-ascii?Q?VWPr68zDK6SwrxWYoAUqXoIPbPSfACdHjZU9n4euO7v8bUfMdkdIA2zj6iqY?=
 =?us-ascii?Q?00murHk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EBAAB951B6A5A74DB1A5FDB1D61361FD@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 469cd46f-dc05-4fdb-eb6d-08d96e65ebea
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 23:03:47.6378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o25N0FS2Vb59SoINjv3Jgm1W3Z41sc+NhMZZBtfTtjuY/T2s2fgUyPsZKSJDd2Rlx3ER/N8oiD+WLwjcmUNvRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5109
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: -S1dzygUkH1OrtVaCqEilaFX5ma5d-vX
X-Proofpoint-ORIG-GUID: -S1dzygUkH1OrtVaCqEilaFX5ma5d-vX
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-02_04:2021-09-02,2021-09-02 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 mlxscore=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501
 phishscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2108310000 definitions=main-2109020133
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 2, 2021, at 3:53 PM, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
> 
> On Thu, Sep 2, 2021 at 9:58 AM Song Liu <songliubraving@fb.com> wrote:
>> 
>> Introduce bpf_get_branch_snapshot(), which allows tracing pogram to get
>> branch trace from hardware (e.g. Intel LBR). To use the feature, the
>> user need to create perf_event with proper branch_record filtering
>> on each cpu, and then calls bpf_get_branch_snapshot in the bpf function.
>> On Intel CPUs, VLBR event (raw event 0x1b00) can be use for this.
>> 
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> include/uapi/linux/bpf.h       | 22 ++++++++++++++++++++++
>> kernel/bpf/trampoline.c        |  3 ++-
>> kernel/trace/bpf_trace.c       | 33 +++++++++++++++++++++++++++++++++
>> tools/include/uapi/linux/bpf.h | 22 ++++++++++++++++++++++
>> 4 files changed, 79 insertions(+), 1 deletion(-)
>> 
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 791f31dd0abee..c986e6fad5bc0 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -4877,6 +4877,27 @@ union bpf_attr {
>>  *             Get the struct pt_regs associated with **task**.
>>  *     Return
>>  *             A pointer to struct pt_regs.
>> + *
>> + * long bpf_get_branch_snapshot(void *entries, u32 size, u64 flags)
>> + *     Description
>> + *             Get branch trace from hardware engines like Intel LBR. The
>> + *             branch trace is taken soon after the trigger point of the
>> + *             BPF program, so it may contain some entries after the
> 
> This part is a leftover from previous design, so not relevant anymore?

Hmm.. This is still relevant, but not very accurate. I guess we should 
provide more information, like "For more information about branches before
the trigger point, this should be called early in the BPF program". 

Song


> 
>> + *             trigger point. The user need to filter these entries
>> + *             accordingly.
>> + *
>> + *             The data is stored as struct perf_branch_entry into output
>> + *             buffer *entries*. *size* is the size of *entries* in bytes.
>> + *             *flags* is reserved for now and must be zero.
>> + *
>> + *     Return
>> + *             On success, number of bytes written to *buf*. On error, a
>> + *             negative value.
>> + *
>> + *             **-EINVAL** if arguments invalid or **size** not a multiple
>> + *             of **sizeof**\ (**struct perf_branch_entry**\ ).
>> + *
>> + *             **-ENOENT** if architecture does not support branch records.
> 
> [...]