Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp131511pxb; Thu, 2 Sep 2021 21:32:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7UdAUdFULiw5FnA6MxINOUcDTUuubkFZuwkSnwwPVesT9EeGMVYfXapARItUaiNL82A+0 X-Received: by 2002:a17:906:f11:: with SMTP id z17mr1935199eji.385.1630643535814; Thu, 02 Sep 2021 21:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630643535; cv=none; d=google.com; s=arc-20160816; b=XqD5oD3vsv9JBLvwLV4QtMxFnFNOTdvLvxehX03A/Pvkn/RnpkCrWOrzoU1EZ0ClA6 K4Zfd4wRRGbCG7KxwVEtnnvHvLMoNlasNMLv/nqFwNWsq3wulfnXYs7C7XWLKXx7qiRs qISVgyrESMFi6vn1Ui5J21o4jYfohKKoQhQFmagC4eFEfcqvAk22a60kxFRW+pP3a+RR MBcTCLzSl460loaywR0gUk2uy5a1dRuU8wRxsEatdMcjjLcbca5v/MGPkfGIkJf/hREb Z26Hlb9hUDbQWmbrJXg2iAPQY+78Zu7WekC2B91IeDQ2K8xb0JbzTNYFtDCJd2oENx9V gykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wZ2Hz0OCkOQo04Tv7XC9luk9+pT8IdikbL6e2p/MKw4=; b=iu7UE8AnqMaiL4NHaTXZgdWO/+m7aHyW7CPX+vcvHNCZPTF5XEp6y6xnbw/e3T+m9I 1VC2d1MxdnBb6GFv5Ik/OcYvhVpHK5y5tmAQWeObbrjW/XS1Q8UYuafQHANqJlSBzRkd uxzWZph+GquvV/QklXa2gcaQfTgM6exHAfE7IsZu6fcGeJPvSRubTfjWCIwD4cfYHZJk F6gg3fmGROqY65GnCLWCcahkQR7meieXRNYgNsC57UDv5TaH83M5FzpCUl6acxhG6cCg Lc0DU1CKcgPig0ux5TRm0H+oFKB77RmU2Xh3C8RRu/pfJZ0cTrZZbzXszIacIbQG1c1N 9pdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MTzropaw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lv23si4366787ejb.287.2021.09.02.21.31.41; Thu, 02 Sep 2021 21:32:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MTzropaw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhICE3k (ORCPT + 99 others); Fri, 3 Sep 2021 00:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbhICE3k (ORCPT ); Fri, 3 Sep 2021 00:29:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC71EC061575; Thu, 2 Sep 2021 21:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wZ2Hz0OCkOQo04Tv7XC9luk9+pT8IdikbL6e2p/MKw4=; b=MTzropaw7S1HoKtqiXLHAHD0fj tyjDT7d+7Ht4X3ys/wQnJn56toNXu3zPj+AqiHuy3XBWIaBb3B6phmNHDcf1OMFXOVIgj4TkYL50h lW64/PFmSyYxsEU3VvoXs9kcEyY3COTdJRriN7ZF2EM5ND7nxcaaFQVdUMgHUJI8FfU/vfELNgkj9 E3qPqNF9DnmJH7BrzmMhE1xBjXmtjIDqduREc/hmqGmMhfeDknJf6sGJHrd1jKSytWUSXsOvWHL3Y LenatZhCTZFL6QI3zoDWfF5p4wnlXqciNBXjSNe7i+FElHxnjVxY8nLUwgyDSq4+edqaBjmkOusg2 V5Ur+4Og==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM0nW-0046yx-RU; Fri, 03 Sep 2021 04:27:43 +0000 Date: Fri, 3 Sep 2021 05:27:26 +0100 From: Christoph Hellwig To: James Bottomley Cc: Linus Torvalds , Jens Axboe , Andrew Morton , linux-scsi , linux-kernel , Christoph Hellwig Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window Message-ID: References: <26c12f13870a2276f41aebfea6e467d576f70860.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26c12f13870a2276f41aebfea6e467d576f70860.camel@HansenPartnership.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote: > > > > Just checking that was fine, and I notice how *many* places do that. > > > > Should the blk_execute_rq() function even take that "struct gendisk > > *bd_disk" argument at all? No, it shouldn't. rq->rq_disk should go away and use rq->q->disk instead. This has been on my TODO list, but didn't make the cut for this merge window.