Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [FIX PATCH 1/2] mm/page_alloc: Print node fallback order
To:     Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com,
        lee.schermerhorn@hp.com, mgorman@suse.de,
        Krupa.Ramakrishnan@amd.com, Sadagopan.Srinivasan@amd.com
References: <20210830121603.1081-1-bharata@amd.com>
 <20210830121603.1081-2-bharata@amd.com>
 <b0c3c57b-1649-1466-b503-b42ddc392c23@arm.com>
From:   Bharata B Rao <bharata@amd.com>
Message-ID: <e37f46f6-3d24-03d2-51c6-28967bef0784@amd.com>
Date:   Fri, 3 Sep 2021 09:47:35 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <b0c3c57b-1649-1466-b503-b42ddc392c23@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmF5RnYvaGoyT3JjTVd3UzJhelJ4RFJTcE9BOXdhZmJ1UTYraTFySmFBRVpr?=
 =?utf-8?B?endzMTVQTUhDcnk2a1RnWlJXbGl0R2pUUndyZUh3TjdJUktMM2xlTWZ4SVZr?=
 =?utf-8?B?SndheE1BZDg3aFlUY3poU01kcUY5WjU1K2g4K2VlelNyZm4reGhnREJzbk10?=
 =?utf-8?B?cityWm8xR2FRWEZzc05RdDlSMThVQ3hTOVR3UXpPK1BtMjNMbDl2R01vQ1VR?=
 =?utf-8?B?UzM0L25VS0xCL3lubG1LM0tUTTJ0TEVXWDFwNWlYSzNwODNmZlRKbHhrb1pv?=
 =?utf-8?B?L29YZVVZL1Q5ZVB0T1gvVzVBUUorYmFLMnJCY3RZU2VCbU9kUzBQdmkvVVV6?=
 =?utf-8?B?MkxiUlVlODlWZXpSZm00K25ObGR5NTFtRWlESlhjK3Vnc0NZbDFkTEZ4WFBY?=
 =?utf-8?B?SlRxeGxkLzdaRkZkWnFiVFFJNlVxdnIyckVUb2laZWtOWE5oUkp6ekk1ZWNw?=
 =?utf-8?B?L1BDY2dqc1VPdUpIcHZIeUhpbENCNEczK2VWS2RTODhPQkc5YmpSMmR3d3Q2?=
 =?utf-8?B?MmZnYTVyR0x0VGJRZndjSjY2NE8wSEVLU2xvTS8yYldpMVQyOG1SWkp3VVFG?=
 =?utf-8?B?eVZGdmY2TVpUREJ1QWZYanA2RTViYlZTbWR4V0o0N0dzZ2FQOEJmMmxyVitV?=
 =?utf-8?B?dXRUaFJ6TUdpUmJjZ0VLOXhTMnV6dktJUWJPb2RGNVJmckErR0RsQnEwY2Vs?=
 =?utf-8?B?TUR2MHJic0ZqMno4b1lSbjlhSzF3UXkrYVpGUVNlMG1LdThhQ25JVFV3VlUr?=
 =?utf-8?B?UWNqYkwzc05zdTJFYXJUNGtxM0E5dWZCN3RzZXdtU3kzSTBFMjlKbSt6Uitm?=
 =?utf-8?B?YzFHQmw2QU56QUtyeXpYTFB4bUdCS1ZnaERYVlFtL2o3OEUzR2JyS0NPVzVF?=
 =?utf-8?B?YmJSb0VhTS96amExeWNSSG5QU3BhblNJdExtWmZnNFp0Mm45NjBPUXpmRnBh?=
 =?utf-8?B?bUtoS1ZGTytaa2t1b1JTcUVUSk1ZTGtrdlUzU2xMVFUrZGFoWUdaNG5ka0Vx?=
 =?utf-8?B?TmFEUGVYTmEvRWo0c1dyVlRBS3JDVnRMbEFId3JIV3Q5VkNkUnBkUUpnVnlj?=
 =?utf-8?B?R0xFUlkzNm9jQitNR3R1SHpxY2txaVowbVZDb25ROXd1YWZTSFU2ZHlTMTRQ?=
 =?utf-8?B?aERYeGs0c2h5TVdLYVFnTXoza2tXSkFZV0FhNkNYdjFkbVlidE40UWovTlN5?=
 =?utf-8?B?U1YxMFhyWTJUMlk2VjRxK0FOa2pBak00dVVubXZIamoxa3BJTlAvcDFQQ3Jl?=
 =?utf-8?B?ZEt4cXEvaGNRS2RKNnZmYk9uYTR2TWtSZjZsODR3eC95dmZ6dXFwbzliNjNu?=
 =?utf-8?B?OGk0SXBXT3FCQUN0Z0tYalRkWDZ5YWtadUpzWVZkdXZwRFBRdnE1M0ZsTGJi?=
 =?utf-8?B?M3VTZzFDSGR2aWZZMDBEWFlvOTZjVHMyU1JmcXg2NWJ5bjVKVEpielVHZnZr?=
 =?utf-8?B?TFBya0hWalBPbXU4M1IremtLKzhrSHBzQUwrZkxnd0ZwVDMzdFIvVjM2N1c0?=
 =?utf-8?B?Q1A3aWQzMXg2Z3BIc1pLVWhVRTBXMEFoa2ROQjRhRFZwbWYxQTY1YUFOV1lQ?=
 =?utf-8?B?b0M2ek5xZEtJejhsMTZxS05aOFJKNUx4d0F0VFhEQU1JZFB0QWtqQTdCZ24x?=
 =?utf-8?B?b0t1YStzbDF6bEEwa1V3VzdkVHcxSGtpMVBkZ2xoZUNvQis5MExVQzI2NnJu?=
 =?utf-8?B?UGFQSklrNXhpSXVycDlSaDVwQ1VFcnI2R1RkcnVKaVVEMGxUdmNMVm5DU2VK?=
 =?utf-8?Q?4gnvgiVBHTwNGgbQ1cZhDaZIhwGA4Xhk1MlZFI0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec44d29-2413-41b2-4721-08d96e91caac
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4289.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 04:17:50.1168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6R8aIg1cpWrU7BiDsQGWr3OGYi7ndO+549QLJHwx5Iq0vRi4Cnyi4LLoh6VEvWo5Ab+ANYluJnFeJJVSRiQnwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3716
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/3/2021 9:45 AM, Anshuman Khandual wrote:
> 
> 
> On 8/30/21 5:46 PM, Bharata B Rao wrote:
>> Print information message about the allocation fallback order
>> for each NUMA node during boot.
>>
>> No functional changes here. This makes it easier to illustrate
>> the problem in the node fallback list generation, which the
>> next patch fixes.
>>
>> Signed-off-by: Bharata B Rao <bharata@amd.com>
>> ---
>>  mm/page_alloc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index eeb3a9cb36bb..22f7ad6ec11c 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -6277,6 +6277,10 @@ static void build_zonelists(pg_data_t *pgdat)
>>  
>>  	build_zonelists_in_node_order(pgdat, node_order, nr_nodes);
>>  	build_thisnode_zonelists(pgdat);
>> +	pr_info("Fallback order for Node %d: ", local_node);
>> +	for (node = 0; node < nr_nodes; node++)
>> +		pr_cont("%d ", node_order[node]);
>> +	pr_cont("\n");
>>  }
>>  
>>  #ifdef CONFIG_HAVE_MEMORYLESS_NODES
>>
> 
> A small nit, checkpatch.pl throws up an warning. Should this use
> pr_info() instead ?
> 
> WARNING: Avoid logging continuation uses where feasible
> #29: FILE: mm/page_alloc.c:6282:
> +               pr_cont("%d ", node_order[node]);
> 
> WARNING: Avoid logging continuation uses where feasible
> #30: FILE: mm/page_alloc.c:6283:
> +       pr_cont("\n");
> 
> total: 0 errors, 2 warnings, 10 lines checked

Yes, I am aware of this, but then it made sense for the fallback list
to be printed in one line continuously. Hence used pr_cont().

Regards,
Bharata.
>