Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Bharata B Rao <bharata@amd.com>
Subject: Re: [FIX PATCH 2/2] mm/page_alloc: Use accumulated load when building
 node fallback list
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com,
        mgorman@suse.de, Krupa.Ramakrishnan@amd.com,
        Sadagopan.Srinivasan@amd.com
References: <20210830121603.1081-1-bharata@amd.com>
 <20210830121603.1081-3-bharata@amd.com>
Message-ID: <0d67b3b7-cf2f-61f3-c67a-76e85e05a3ee@amd.com>
Date:   Fri, 3 Sep 2021 10:13:59 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20210830121603.1081-3-bharata@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE5ZTzVHdm1WN1RUTEV4NXJ1bmQxSXltdnlJSG94L2NxN29GSDZ2WUErblls?=
 =?utf-8?B?a3J6SGZZVEUvMExhQUhqNmE5Q3ZMeVpnVFZMTkh4enYzWE12VFYxRFE2UjZl?=
 =?utf-8?B?RjFRWk5uZzZueElPck5GVjVacUdTcXZ0RXJ3NmlWbHlxV3RLVDZxTHlMYUox?=
 =?utf-8?B?UVhwNytjTFZkSlJwL1grNjBFMnFVUHNNeU9ISjBna1k1SElQeDNuUGF2RDYw?=
 =?utf-8?B?Q09MSkpSckMyQnhXbWJsbys1RjRRWHgyWDVBNzNTRTViWGpKaU90SlpZZ2Js?=
 =?utf-8?B?cmR5QUw5QjdDK2IxQnpQSGJPdnBLT0JnVnI4S0h6cWl1ZVdrYjFXR2pDcjEv?=
 =?utf-8?B?Zk8yZWJ2WkRwK2ZoNFlXcjd4dnROa0pmWmlRQ1pDcVdUMFhoNXpFcDZtaFRN?=
 =?utf-8?B?bis2YUFyR0kra1lEcFpxYnltWlFjNlJ0RzhETkZlT2VZTVBVanZtY1phdTFJ?=
 =?utf-8?B?ZGVvajg0NnJuenQxSC8vb3JrM09FWHZ4bEsxeUdjUERFc1l4UXFob0t6WE12?=
 =?utf-8?B?cUVSeVozb0dJaTVHUFRiMXFxUCtPZDVuRVBjTFNpaEV2MWhUY053WlBtOEs1?=
 =?utf-8?B?cmg3dTZvSGoweGEramhTVDJ2ZlViMVRxRndFSk11dmhPOFBJTVJqWmN5blBM?=
 =?utf-8?B?RkNrN0ZMUVhidFFnMklNaDNrYkQ0ejF6Q29RVmhVWUtUUzdmc1B2UW8zK25s?=
 =?utf-8?B?Qkp6UzBuZVZJYS9oSGJPUWVHMStQWDkzTDBSR0pkaFdEYmFVTEFSVEIwQkRp?=
 =?utf-8?B?NGcya05JTmZkUXVlQ2xOS2ZzZmV0WUMvRlByelFHSnN5VWpTWENZTWl3dnEx?=
 =?utf-8?B?SGRKSWJNa0w3M0pkVk0wcytrbFdFdHpLN2k5TEVGUTNtaWVUWm9tWnN6dGhx?=
 =?utf-8?B?QUtVZ0VzNmJUMDd1bUtuNG9UVnhYcHp3akpCS0hJUFlpcGk5ckF2dytWOFBY?=
 =?utf-8?B?VUhSa0grTUlzK3JNU0d3Nzh5eVFHL3F5a21TZWtVZkF0SnJGdEFpWWlqcU4x?=
 =?utf-8?B?N1oxWW5HcDhaZmpSU2lLL05uWHV0L2kxTWgxREtPd0ZvaFZ4bVJEbGZ5Nzkv?=
 =?utf-8?B?V1NqcjJOYWtOdmUwYkNYYSs3VnVRRy9scUZIZ3o5cjlGRzViakE2UnlwaHpL?=
 =?utf-8?B?bWVtTy9YOUlOZ21kZ05FekJ3cUVoUFVoZS9ZMTYyaHFTbDNETE40OXlVdjZw?=
 =?utf-8?B?NHlXL3l2dFlxQUZGYnhtZWcybjVUYVpnK1pwSmZzVmFNTTVFOVZDZnlTVTZH?=
 =?utf-8?B?a1VkbGNGNHNuS1RDWHNjaVhzT3grNFZKU3pLVjZpcVVHeWNRN0tuQ3BaVmdX?=
 =?utf-8?B?NnQ3c0pMVWdiS1lCdndPblBMVDdpUkkvVnhVZlJKS1Z4QnAxT1U2TVVpbjNo?=
 =?utf-8?B?UTdsNGI3NXY4RUlNcklVZUFjR1EyZTJyWnZVR29YcXZRV3BRYTJOVHNYajVD?=
 =?utf-8?B?QmZzZWR6VjNkTDkyNFFDVWY0MXo5WGhwOElqZzY0Yk51aEVwMHNiQ2lvVStj?=
 =?utf-8?B?MlVRSTZTZklvRE9EMlc0bHpqL3ZoemhZbUptdThXcGFGUkpaMzFYd0tZUWtl?=
 =?utf-8?B?KzJLUGpOckw1WVkxS0tlN1ZibHdQM0YwcHBTMmZna1FoWnZrZmhOWGdTQ1Z4?=
 =?utf-8?B?aTcwTDVjVnRkbk0zdlJ3ejZFaUtWSVNDQmdoWjNQZWJ3T3hOejhhRVB3NU1y?=
 =?utf-8?B?QjRYaVRIOW5yWC9JOUdMVmtyck96YTJtU1gwQmNSeitIYm9WK0puaXVPamNu?=
 =?utf-8?Q?+iQ3O6smLUPhU67o2TtRSP7WyyStfHToTo+hRLE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 403a61b5-a9a0-4140-ae8c-08d96e957acd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4289.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 04:44:14.0143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XOQ+w8BXH3UEHdTPmXAIx0eeYC9zz4U6wSPgvOWOeoKBl7afPfhtz1St8lo07otLzYzSkqMN5Mszp/iL845AHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4694
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/30/2021 5:46 PM, Bharata B Rao wrote:
> From: Krupa Ramakrishnan <krupa.ramakrishnan@amd.com>
> 
> In build_zonelists(), when the fallback list is built for the nodes,
> the node load gets reinitialized during each iteration. This results
> in nodes with same distances occupying the same slot in different
> node fallback lists rather than appearing in the intended round-
> robin manner. This results in one node getting picked for allocation
> more compared to other nodes with the same distance.
> 
> As an example, consider a 4 node system with the following distance
> matrix.
> 
> Node 0  1  2  3
> ----------------
> 0    10 12 32 32
> 1    12 10 32 32
> 2    32 32 10 12
> 3    32 32 12 10
> 
> For this case, the node fallback list gets built like this:
> 
> Node	Fallback list
> ---------------------
> 0	0 1 2 3
> 1	1 0 3 2
> 2	2 3 0 1
> 3	3 2 0 1 <-- Unexpected fallback order

FWIW, for a dual-socket 8 node system with the following distance matrix,

node   0   1   2   3   4   5   6   7
  0:  10  12  12  12  32  32  32  32
  1:  12  10  12  12  32  32  32  32
  2:  12  12  10  12  32  32  32  32
  3:  12  12  12  10  32  32  32  32
  4:  32  32  32  32  10  12  12  12
  5:  32  32  32  32  12  10  12  12
  6:  32  32  32  32  12  12  10  12
  7:  32  32  32  32  12  12  12  10

the fallback list looks like this:

Before
=======
Fallback order for Node 0: 0 1 2 3 4 5 6 7
Fallback order for Node 1: 1 2 3 0 5 6 7 4
Fallback order for Node 2: 2 3 0 1 6 7 4 5
Fallback order for Node 3: 3 0 1 2 7 4 5 6
Fallback order for Node 4: 4 5 6 7 0 1 2 3
Fallback order for Node 5: 5 6 7 4 0 1 2 3
Fallback order for Node 6: 6 7 4 5 0 1 2 3
Fallback order for Node 7: 7 4 5 6 0 1 2 3

After the fix
==============
Fallback order for Node 0: 0 1 2 3 4 5 6 7
Fallback order for Node 1: 1 2 3 0 5 6 7 4
Fallback order for Node 2: 2 3 0 1 6 7 4 5
Fallback order for Node 3: 3 0 1 2 7 4 5 6
Fallback order for Node 4: 4 5 6 7 0 1 2 3
Fallback order for Node 5: 5 6 7 4 1 2 3 0
Fallback order for Node 6: 6 7 4 5 2 3 0 1
Fallback order for Node 7: 7 4 5 6 3 0 1 2

So the problem becomes more pronounced for bigger NUMA systems.

Regards,
Bharata.