Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp213837pxb; Fri, 3 Sep 2021 00:01:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK1jZljU3KQT/fjyllfn1Z8R9JixFjUAaQDA9MxCXoVoP/FhwjPt859G9uJj8/6AcCcC4b X-Received: by 2002:a50:9e41:: with SMTP id z59mr2452941ede.376.1630652460304; Fri, 03 Sep 2021 00:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630652460; cv=none; d=google.com; s=arc-20160816; b=uCdUtasTMYeRYdWJgM+llqEo7IW9OEukuiyWpU/Gd71iB0zSAWvJnwkTSp5FjmODYB vtFsXKxGLSu7Tdb5MtSqA8/KhX/9rWDDzWITceNoxXgBS/59VJStjJhS1t1VNCCIwjQ5 OlvVS5EmqFDLtE0VCkMdkgr2/zdkrLFJ3beu6ERkQBMffBLc5TZQL9/42JIxFZMtUUr5 gyxWiu8HUxzm6qTsUttGh0cJRzj2eAR4ECvRMmPPb9FIc7FNn682PEYqFhbxLwIHPnyr zyKXRKUeFsJxB6eU7yHI54DiBRlOPOQBq3JzgdA6Dp4gaif7JhUtX10f88HwTYvIUqXw sStw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=gBewvpk3InG0vM/wR8Z3wxo1RkrtAf3PMQleuPTEpXc=; b=Gggyg42N7nSLaHwOH8plYrIxCRM/3/ihJDG3NJtiK0OY7gldF4zm8emjstxvqwIigb 8NfoQFaFcdU/q3bC6F/h40Ty16xTqvA3ZSEQaXkfw3CteStmc/TF7+te8+wYZU5uS5Dl otZJ2dFRaLJDDsTrN1S4YtPsP9ZW83FOdss4TtLy+nZYjgAMvpwtn5LTybcSaOcpvFCI CsnXWWyylT7cnzgUoXSjkmpawlDgTIOtDcQiQ0XZOWkoUNRUW4E6pRkWsmw2Yflg0LCO kMgjT39M9kDSOhw6B4JkoVWh7Qe+AgRnSR/ar+nC9UTgvyaF36wIpDmtkLZx1PZVPPta +cpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XN2ippLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf2si4590680ejb.500.2021.09.03.00.00.35; Fri, 03 Sep 2021 00:01:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XN2ippLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347469AbhICHAO (ORCPT + 99 others); Fri, 3 Sep 2021 03:00:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:59504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346599AbhICHAO (ORCPT ); Fri, 3 Sep 2021 03:00:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35FEE60F9C; Fri, 3 Sep 2021 06:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630652354; bh=Q4+XwPN+M1cvWkQuGrtu9reB+WwKcJKnoIF/ojmKBVM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XN2ippLWQO03bK2sMb6hqrkdTyYHIhPz9iZwFpJgB7QBDo8rWvQ4xqnbL5gU9Es2s 17jxFHAd/XT1DrU/jkwXtW363y+iTEMpxGiofl69XGp09ZR/v8OB0cLb2gy2y+fvQd jCQap+vXUfakWwWdbRWu31f+HpaqITe3E6TdfwEZaF3YbdSm8e6LXoEqmgO/OkZOmF V2pUpB+c5km+hBzOoSkrPfxcnoD/tqDq+E39QrFolaS4cJRsmRLCcqDeGwAs/BGCWx xZiel+RBUcWpHQ+RN7pS9FO8aydVvafLD0De1OWSP02PbRMMCwOXbqJIH5w4e2VV3j 67ghs2Cawuepw== Message-ID: <3c0a8a858a805789b9c71b7e54e316403fc41d5e.camel@kernel.org> Subject: Re: [PATCH v2] KVM: x86: Handle SRCU initialization failure during page track init From: Jarkko Sakkinen To: tcs.kernel@gmail.com, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Haimin Zhang Date: Fri, 03 Sep 2021 09:59:12 +0300 In-Reply-To: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com> References: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-09-03 at 10:37 +0800, tcs.kernel@gmail.com wrote: > From: Haimin Zhang >=20 > Check the return of init_srcu_struct(), which can fail due to OOM, when > initializing the page track mechanism. Lack of checking leads to a NULL > pointer deref found by a modified syzkaller. >=20 > Signed-off-by: Haimin Zhang > Signed-off-by: Sean Christopherson > Signed-off-by: Vitaly Kuznetsov > Reported-by: TCS Robot I'd drop reported-by. It's not a person (I guess) and the desc is self-contained already. Anyway, Acked-by: Jarkko Sakkinen /Jarkko