Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 3 Sep 2021 08:57:07 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     James Bottomley <James.Bottomley@hansenpartnership.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window
Message-ID: <YTHVUxc5xZzr77er@infradead.org>
References: <fc14fbbf0d7c27b7356bc6271ba2a5599d46af58.camel@HansenPartnership.com>
 <CAHk-=wi99u+xj93-pLG0Na7SZmjvWg6n60Pq9Wt9PgO6=exdUA@mail.gmail.com>
 <26c12f13870a2276f41aebfea6e467d576f70860.camel@HansenPartnership.com>
 <YTGkLhfYWcvj4YRn@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YTGkLhfYWcvj4YRn@infradead.org>
Precedence: bulk

On Fri, Sep 03, 2021 at 05:27:26AM +0100, Christoph Hellwig wrote:
> On Thu, Sep 02, 2021 at 04:23:43PM -0700, James Bottomley wrote:
> > > 
> > > Just checking that was fine, and I notice how *many* places do that.
> > > 
> > > Should the blk_execute_rq() function even take that "struct gendisk
> > > *bd_disk" argument at all?
> 
> No, it shouldn't.  rq->rq_disk should go away and use rq->q->disk
> instead.  This has been on my TODO list, but didn't make the cut for
> this merge window.

Here is a quick draft of that:

http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-remove-rq_disk