Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <93705335a3e6dcdb56de601df566445aa5bcb28e.camel@sipsolutions.net>
Subject: Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to
 pointer
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Yang Li <yang.lee@linux.alibaba.com>, jdike@addtoit.com
Cc:     richard@nod.at, anton.ivanov@cambridgegreys.com,
        linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Fri, 03 Sep 2021 10:20:13 +0200
In-Reply-To: <1630655468-71684-1-git-send-email-yang.lee@linux.alibaba.com>
References: <1630655468-71684-1-git-send-email-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
> 
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
> 

> -	memset(data, 0xff, sizeof(data));
> +	memset(data, 0xff, sizeof(*data));

Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)

A Fixes: tag would be nice, but otherwise

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

johannes